D9792: even slimmer scrollbars

zzag added a comment. I'm sorry, but these scrollbars have too thin sliders. F5801991: scrollbar.png Slider occupies only 15% of space in horizontal direction, that's a "big" waste of space. REPOSITORY R31 Breeze REVISION DETAIL https://ph

D9792: even slimmer scrollbars

rikmills added a comment. In https://phabricator.kde.org/D9792#193697, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9792#193473, @rikmills wrote: > > > In Neon and Kubuntu CI with Qt 5.9.3 > > > > https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/

D9792: even slimmer scrollbars

hpereiradacosta added a comment. Fixed with https://commits.kde.org/breeze/fc830e4710a9994a13911ac6cbc60ffda8f27715 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: rikmills, davidedmundson, ngraham,

D9792: even slimmer scrollbars

hpereiradacosta added a comment. In https://phabricator.kde.org/D9792#193473, @rikmills wrote: > In Neon and Kubuntu CI with Qt 5.9.3 > > https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console > > 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In mem

D9792: even slimmer scrollbars

rikmills added a comment. In Neon and Kubuntu CI with Qt 5.9.3 https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In member function ‘virtual bool Breeze::Style::drawScrollBarSliderControl(const QStyle

D9792: even slimmer scrollbars

mart added a comment. landed just in master post 5.12 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: davidedmundson, ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D9792: even slimmer scrollbars

This revision was automatically updated to reflect the committed changes. Closed by commit R31:d4b07d9e1daf: even slimmer scrollbars (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25385&id=25590 REVISION DETAIL https://phabricator.k

D9792: even slimmer scrollbars

davidedmundson added a comment. Please merge after 5.12 branches. REPOSITORY R31 Breeze BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: davidedmundson, ngraham, colomar, abetts, plasma-devel, ZrenB

D9792: even slimmer scrollbars

hpereiradacosta accepted this revision. hpereiradacosta added a comment. Ship it ! Thanks ! REPOSITORY R31 Breeze BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: ngraham, colomar, abetts, plasma-de

D9792: even slimmer scrollbars

mart added inline comments. INLINE COMMENTS > mart wrote in breezestyle.cpp:5016 > it works ok for the qwidget case, unfortunately in the case of qml, > _animations will always be empty, so i still have to check > option->styleObject anyways this is the shortest form i could come up which work

D9792: even slimmer scrollbars

mart updated this revision to Diff 25385. mart added a comment. - shorter form REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25240&id=25385 BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 AFFECTED FILES kstyle/breezes

D9792: even slimmer scrollbars

mart added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:5016 > Ok. Just checked: this whole code should still work if replaced by: > > const bool widgetMouseOver( _animations->scrollBarEngine().isHovered( > widget, QStyle::SC_ScrollBarGroove ) ); > > (used else

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:5016 > +// in case this QStyle is used by QQuickControls QStyle wrapper > +else if( option->styleObject ) widgetMouseOver = > option->styleObject->property("hover").toBool(); > + Ok. Just checked: this whol

D9792: even slimmer scrollbars

colomar added a comment. Dunno why I only noticed it now, but of course then this is not the right place to fix it. Sorry for the noise. REPOSITORY R31 Breeze BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta,

D9792: even slimmer scrollbars

hpereiradacosta added a comment. In https://phabricator.kde.org/D9792#190540, @ngraham wrote: > In https://phabricator.kde.org/D9792#190538, @colomar wrote: > > > Looks great! > > My only concern would be that in the mouseover state the contrast between the grip and groove is quite

D9792: even slimmer scrollbars

ngraham added a comment. In https://phabricator.kde.org/D9792#190538, @colomar wrote: > Looks great! > My only concern would be that in the mouseover state the contrast between the grip and groove is quite low. This could make the two difficult to distinguish, especially for color bli

D9792: even slimmer scrollbars

colomar added a comment. Looks great! My only concern would be that in the mouseover state the contrast between the grip and groove is quite low. This could make the two difficult to distinguish, especially for color blind users. Could perhaps the contrast in terms of brightness be increas

D9792: even slimmer scrollbars

mart marked an inline comment as done. REPOSITORY R31 Breeze BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, a

D9792: even slimmer scrollbars

mart updated this revision to Diff 25240. mart added a comment. fix the math REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25152&id=25240 BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 AFFECTED FILES kstyle/breezesty

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:5046 > +if (StyleConfigData::animationsEnabled()) { > +color.setAlphaF(color.alphaF() * (0.7 + grooveAnimationOpacity)); > +} This generates some warnings here, because 0.7 + grooveAnimationOpaci

D9792: even slimmer scrollbars

mart added a comment. so, a slightly different approach now, maybe it's a tad cleaner: don't try to draw the handle twice and cross fade it, but draw it smaller and then animate the handle size (and opacity) on mouse over REPOSITORY R31 Breeze BRANCH phab/slimScrollbars REVISION DETAIL

D9792: even slimmer scrollbars

mart updated this revision to Diff 25152. mart added a comment. - const opacity REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25151&id=25152 BRANCH phab/slimScrollbars REVISION DETAIL https://phabricator.kde.org/D9792 AFFECTED FILES kstyle/b

D9792: even slimmer scrollbars

mart updated this revision to Diff 25151. mart added a comment. - use the same slider, animate its size REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25089&id=25151 BRANCH phab/slimScrollbars REVISION DETAIL https://phabricator.kde.org/D9792 A

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > mart wrote in breezestyle.cpp:5041 > i like the second option, calling by hand drawScrollBarSliderControl, tough > it would still need to call the superclass drawScrollBarComplexControl? which > then would have to know about not drawing t

D9792: even slimmer scrollbars

mart added inline comments. INLINE COMMENTS > mart wrote in breezestyle.cpp:5041 > you mean making drawScrollBarSliderControl a complete noop? i like the second option, calling by hand drawScrollBarSliderControl, tough it would still need to call the superclass drawScrollBarComplexControl? whic

D9792: even slimmer scrollbars

mart added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:5041 > This whole code feels hackish. > In principle we know (elsewhere in the code), if any part of the scrollbar is > hovered, since it is used to make the groove appear. > I checked that this is done in a

D9792: even slimmer scrollbars

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I like it. I think it falls in line with a less obtrusive bar and one that demands attention. REPOSITORY R31 Breeze BRANCH phab/slimScrollbars REVISION DETAIL https://phabricator.kd

D9792: even slimmer scrollbars

hpereiradacosta added a comment. Also, checking the patch online, it also indirecly changes color handling. In the previous implementation, focus color was used to render the 'non-mouse-over' scrollbar for the widget with focus. This is not the case anymore with this patch, because "disabled

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:5041 > This whole code feels hackish. > In principle we know (elsewhere in the code), if any part of the scrollbar is > hovered, since it is used to make the groove appear. > I checked that this is

D9792: even slimmer scrollbars

hpereiradacosta added a comment. Hi, That looks nice. I don't think it needs a separate settings, since once again the hit area is the same as before. Then: would be nice to have VDG oppinion on that, and see if we can make the code less hackish (on the mouse-over detection side).

D9792: even slimmer scrollbars

mart added a comment. left sidebar: QML, main area: QWidgets F5633964: Spectacle.nS6609.png on mouse over F5633969: Spectacle.lx6609.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org

D9792: even slimmer scrollbars

mart edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hei

D9792: even slimmer scrollbars

mart added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D9792: even slimmer scrollbars

mart created this revision. mart added reviewers: Plasma, Kirigami, VDG. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY the scrollbar handle will be very slim normally, and