D9892: cmake: Use the official CMake variable for building as a static plugin.

croick added inline comments. INLINE COMMENTS > CMakeLists.txt:69 > +if (PLASMA_ENABLED) > +install(DIRECTORY styles/Plasma DESTINATION > ${KDE_INSTALL_QMLDIR}/org/kde/kirigami.2/styles) > +endif() When trying to install it using kdesrc-build, it complains about not finding

D9892: cmake: Use the official CMake variable for building as a static plugin.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:8c34dde112e7: cmake: Use the official CMake variable for building as a static plugin. (authored by mart). CHANGED

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart updated this revision to Diff 25594. mart added a comment. try to diff against the proper stuff REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9892?vs=25589=25594 BRANCH mart/static REVISION DETAIL https://phabricator.kde.org/D9892 AFFECTED

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart added a comment. now the library definition is not duplicated and both the cmake and qmake example do usa the static plugin REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9892 To: mart, #kirigami, lepagevalleeemmanuel Cc: apol, plasma-devel, davidedmundson,

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart updated this revision to Diff 25589. mart added a comment. - don't duplicate target_link_libraries - properly use the static plugin in the example - the pro makes a static library - use proper static plugins for the cmake example - toplevel qmake with subfolders - proper name

D9892: cmake: Use the official CMake variable for building as a static plugin.

lepagevalleeemmanuel added a comment. I tried the patch on my CI and it compiled and linked. I also reviewed the changes between my patchset and this diff and approve the change, I also agree with Apol about the `target_link_libraries` issue. It should be mutualized between the `if` and

D9892: cmake: Use the official CMake variable for building as a static plugin.

apol added a comment. In https://phabricator.kde.org/D9892#191707, @mart wrote: > In https://phabricator.kde.org/D9892#191590, @apol wrote: > > > I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it? > > > may make sense...

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart added a comment. In https://phabricator.kde.org/D9892#191590, @apol wrote: > I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it? may make sense... i would save it for another poatch tough this is big enough already :)

D9892: cmake: Use the official CMake variable for building as a static plugin.

apol added a comment. > I did consider it and went ahead in ring-kde and put every QML in QRC even in non static builds. I think it makes sense, but makes debugging a bit harder and I didn't want to change too much things to fix the static plugin. Shipping assets in QRC doesn't seem to be

D9892: cmake: Use the official CMake variable for building as a static plugin.

lepagevalleeemmanuel added a comment. In https://phabricator.kde.org/D9892#191590, @apol wrote: > I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it? (this code is originally from me, then improved by notmart and is part of

D9892: cmake: Use the official CMake variable for building as a static plugin.

apol added a comment. I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it? INLINE COMMENTS > CMakeLists.txt:47 > +set_target_properties(kirigamiplugin PROPERTIES LIBRARY_OUTPUT_DIRECTORY > ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2)

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart added a reviewer: lepagevalleeemmanuel. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9892 To: mart, #kirigami, lepagevalleeemmanuel Cc: plasma-devel, apol, davidedmundson, mart, hein

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY This is the first step in actually creating a valid Qt static plugin.