broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in package.cpp:594
> Just curious: what does the modulo operator on a string?
It explicitly uses `QStringBuilder` for concatenation which `operator+` only
does if you define `QT_USE_QSTRINGBUILDER`
REPOSITORY
R290 KPackage
REV
graesslin added a comment.
There are a few unrelated changes, but otherwise looks good.
INLINE COMMENTS
> package.cpp:360
> //Nested loop, but in the medium case resolves to just one iteration
> -//qDebug() << "prefixes:" << prefixes.count() << prefixes;
> +// qDebug() << "prefix
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:8336ad60d9a5: Properly do strings in the kpackage
framework (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9104?vs=23262&id=23266
REVI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
strings
REVISION DETAIL
https://phabricator.kde.org/D9104
To: apol, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of using implicit casts, use the ones we need as suggested for KF5.
TEST PLAN
test
On Mon, Dec 22, 2014 at 4:01 PM, David Edmundson
wrote:
> No objections from me
ok, opened a sysadmin ticket for the move
--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
No objections from me
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Monday 10 November 2014, Marco Martin wrote:
> Hi all,
> since at akademy there seemed the interest in it,
> I have been working on some classes i extracted from libplasma to be on
> their own, those related to Plasma::Package, since several applications
> have the interest of having scriptable
On Monday 22 December 2014 10:21:21 Marco Martin wrote:
> On Saturday 20 December 2014, David Faure wrote:
> > > in the branch mart/kpluginmetadata there is an experiment in porting
> > > away
> > > from kservice, tough if i go all the way it should have a complete own
> > > copy of the plugin inde
On Saturday 20 December 2014, David Faure wrote:
> > in the branch mart/kpluginmetadata there is an experiment in porting away
> > from kservice, tough if i go all the way it should have a complete own
> > copy of the plugin indexing (and indexing tool) since if it doesn't
> > depend from kservice
On Monday 10 November 2014 20:33:27 Marco Martin wrote:
> On Monday 10 November 2014, Marco Martin wrote:
> > * porting all the internal and api use of KPluginInfo to KPluginMetadata
> > * removing all the query functionality, (since it needs
> > KPluginTrader::applyConstraints) and making instead
On Monday 10 November 2014, Marco Martin wrote:
> * porting all the internal and api use of KPluginInfo to KPluginMetadata
> * removing all the query functionality, (since it needs
> KPluginTrader::applyConstraints) and making instead KPluginTrader able to
> find packages as well
>
> Opinions? com
Hi all,
since at akademy there seemed the interest in it,
I have been working on some classes i extracted from libplasma to be on their
own, those related to Plasma::Package, since several applications have the
interest of having scriptable or anyways non-binary content shippable over
ghns.
you
On Friday 19 September 2014, Marko Käning wrote:
> Hi Marco,
>
> is kpackage successfully building on Linux already?
>
> I tried this on my OSX/CI system and got an error…
>
> Are you interested in me reporting about build issues on OSX already, or is
> this still too early?
yes, here builds fi
Hi Marco,
is kpackage successfully building on Linux already?
I tried this on my OSX/CI system and got an error…
Are you interested in me reporting about build issues on OSX already, or is
this still too early?
Greets,
Marko
___
Plasma-devel mailing
El Divendres, 19 de setembre de 2014, a les 13:43:47, Marco Martin va
escriure:
> Hi all,
> After the discussions done at akademy and here about a standalone framework
> for Package, due to the potential interest by other applications in order to
> ship their own scripts/extensions/themes/graphics
Hi all,
After the discussions done at akademy and here about a standalone framework
for Package, due to the potential interest by other applications in order to
ship their own scripts/extensions/themes/graphics assets i did the surgical
operation, after living for a while in scratch it's now in
17 matches
Mail list logo
