Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-29 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 29, 2014, 4:34 p.m.) Status -- This change has been m

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/#review67541 --- Ship it! If the translators won't object, ship it from me whi

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
> On Sept. 27, 2014, 2:05 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 257-263 > > > > > > The result of both of these i18ncs is exactly the same; plus both

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 27, 2014, 2:53 p.m.) Review request for Plasma, Kai Uwe Br

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 27, 2014, 2:38 p.m.) Review request for Plasma, Kai Uwe Br

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
> On Sept. 27, 2014, 2:05 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 257-263 > > > > > > The result of both of these i18ncs is exactly the same; plus both

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/#review67538 --- applets/digital-clock/package/contents/ui/DigitalClock.qml

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-27 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 27, 2014, 1:51 p.m.) Review request for Plasma, Kai Uwe Br

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-25 Thread Kai Uwe Broulik
> On Sept. 25, 2014, 9:33 vorm., Kai Uwe Broulik wrote: > > Can you provide a screenshot of the tooltip? > > Jeremy Whiting wrote: > I'm using the same function to create the time format. but with a > different argument. I guess I could make two separate functions instead, but > why not ju

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-25 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 25, 2014, 11:49 a.m.) Review request for Plasma, Kai Uwe B

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-25 Thread Jeremy Whiting
> On Sept. 25, 2014, 3:33 a.m., Kai Uwe Broulik wrote: > > Can you provide a screenshot of the tooltip? I'm using the same function to create the time format. but with a different argument. I guess I could make two separate functions instead, but why not just use the same one, when 90% of the

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/#review67406 --- Can you provide a screenshot of the tooltip? applets/digital

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-24 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 24, 2014, 8:12 p.m.) Review request for Plasma, Kai Uwe Br