Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-28 Thread Lukas Appelhans
Am Mittwoch 28 April 2010 18:10:54 schrieb Ingomar Wesp: > Lukas Appelhans wrote: > > It's just as easy as changing the .desktop file and putting your name > > into it instead of mine :) > > Oh, well, I should manage to do that ;) > > > And of course taking care of it... :) > > I'll treat it gen

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-28 Thread Ingomar Wesp
Lukas Appelhans wrote: > It's just as easy as changing the .desktop file and putting your name into > it instead of mine :) Oh, well, I should manage to do that ;) > And of course taking care of it... :) I'll treat it gently ;) > (You'll also need an SVN-Account) I've already got one, so that

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-27 Thread Lukas Appelhans
Am Dienstag 27 April 2010 21:48:48 schrieb Ingomar Wesp: > Lukas Appelhans wrote: > > Can you make the configuration of the rows first and then have the force > > setting (aka swap the place of them), that'd make more sense to me as the > > user reads the options from top to bottom, not knowing tha

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-27 Thread Ingomar Wesp
Lukas Appelhans wrote: > Can you make the configuration of the rows first and then have the force > setting (aka swap the place of them), that'd make more sense to me as the > user reads the options from top to bottom, not knowing that there are any > row/column settings... :) That's a good idea,

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-27 Thread Lukas Appelhans
Am Montag 26 April 2010 15:48:27 schrieb Ingomar Wesp: > >>> And I think the column setting is unnecessary... no? :) > >> > >> I'm afraid I'm not sure what you are referring to. > >> Do you mean the ability to set the maximum number of columns in vertical > >> formfactors? > > > > No, in horizont

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-27 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3786/ --- (Updated 2010-04-27 09:56:42.272687) Review request for Plasma. Changes --

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-26 Thread Ingomar Wesp
>>> And I think the column setting is unnecessary... no? :) >> >> I'm afraid I'm not sure what you are referring to. >> Do you mean the ability to set the maximum number of columns in vertical >> formfactors? > > No, in horizontal formfactors there's an option to force the number of > columns, it

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-26 Thread Lukas Appelhans
Am Montag 26 April 2010 13:11:43 schrieben Sie: > > On None, Lukas Appelhans wrote: > > > Hey! > > > > > > Great work! I had a look over the code and tested it and it works > > > greatly! > > > > > > 2 things: > > > Why do we use a custom layout instead of a QGridLayout? > > > And I think the col

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-26 Thread Ingomar Wesp
> On None, Lukas Appelhans wrote: > > Hey! > > > > Great work! I had a look over the code and tested it and it works greatly! > > > > 2 things: > > Why do we use a custom layout instead of a QGridLayout? > > And I think the column setting is unnecessary... no? :) > > > > Anyway, as the freeze

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-25 Thread Lukas Appelhans
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3786/#review5225 --- - Lukas On 2010-04-23 19:08:34, Ingomar Wesp wrote: > > ---

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-24 Thread Lukas Appelhans
Am Samstag 24 April 2010 12:45:16 schrieb Ingomar Wesp: > Lukas Appelhans wrote: > > For keeping the history we usually use svn copy and then change the files > > > > :) svn move only works with svn paths, not with local paths... > > Please correct me if I'm wrong, but as far as I know "svn move"

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-24 Thread Ingomar Wesp
Lukas Appelhans wrote: > For keeping the history we usually use svn copy and then change the files > :) svn move only works with svn paths, not with local paths... Please correct me if I'm wrong, but as far as I know "svn move" *does* work for working copy paths and yields the same result as "svn

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-23 Thread Lukas Appelhans
Am Freitag 23 April 2010 21:08:34 schrieb Ingomar Wesp: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3786/ > --- > > Review request

Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

2010-04-23 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3786/ --- Review request for Plasma. Summary --- This is my proposed patch for the re