Re: Review Request: Adding filename as tooltip for frame applet

2010-10-29 Thread Shantanu Tushar Jha
> On 2010-10-28 13:25:15, Anne-Marie Mahfouf wrote: > > It's fine. Maybe there should be a setting showing the tooltip or not, for > > example when a user has several picture frames the tooltip is shown on > > another one which can be annoying. > > Any feedback from other people about having i

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-28 Thread Sujith H
> On 2010-10-28 13:25:15, Anne-Marie Mahfouf wrote: > > It's fine. Maybe there should be a setting showing the tooltip or not, for > > example when a user has several picture frames the tooltip is shown on > > another one which can be annoying. > > Any feedback from other people about having i

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-28 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8409 --- It's fine. Maybe there should be a setting showing the tooltip or

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-20 Thread Sujith H
> On 2010-10-20 17:24:50, Ingomar Wesp wrote: > > I'm not the maintainer of the applet, so I'm sorry that I can only comment > > on the code itself, not on whether it should go into the applet. > > > > I noticed a few issues: > > - The includes are still in the header. Since you've removed the

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-20 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 17:44:12.910669) Review request for Plasma and Anne-Mari

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-20 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8275 --- I'm not the maintainer of the applet, so I'm sorry that I can only

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-20 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 15:47:47.555193) Review request for Plasma and Anne-Mari

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-20 Thread Sujith H
> On 2010-10-20 09:57:56, Ingomar Wesp wrote: > > Since the ToolTipContent is copied in ToolTipManager::setContent anyway, I > > wouldn't declare it as a member variable, but just allocate a > > ToolTipContent on the stack as needed. This way, you wouldn't have to > > introduce a new member va

Re: Review Request: Adding filename as tooltip for frame applet

2010-10-20 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8253 --- Since the ToolTipContent is copied in ToolTipManager::setContent a

Review Request: Adding filename as tooltip for frame applet

2010-10-19 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- Review request for Plasma and Anne-Marie Mahfouf. Summary --- Added the