Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review9006 --- Ship it! looks good except for one small issue (see below), but

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-15 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 16, 2011, 6:20 a.m.) Review request for Plasma. Changes --

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8987 --- plasma/applets/folderview/folderview.cpp

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-15 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 15, 2011, 3:16 p.m.) Review request for Plasma. Changes --

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-14 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 15, 2011, 7:33 a.m.) Review request for Plasma. Changes --

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8951 --- plasma/applets/folderview/folderview.cpp

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-13 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8950 --- plasma/applets/folderview/folderview.cpp

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-13 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 14, 2011, 3:21 a.m.) Review request for Plasma. Changes --

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-13 Thread Sujith Haridasan
> On Dec. 12, 2011, 3:45 p.m., Aaron J. Seigo wrote: > > plasma/applets/folderview/folderview.cpp, lines 409-413 > > > > > > this needs to be indented properly. > > > > also, instead of a knotification, whi

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-12 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8892 --- nice :) this has been needed for some time and indeed causes sta

Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-12 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- Review request for Plasma. Description --- Adding patch for the TODO,