Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-12-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review23075 --- This review has been submitted with commit

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review22744 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 26, 2012, 10:36

Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/ --- Review request for Plasma. Description --- On this patch i am

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review22561 --- plasmate/CMakeLists.txt

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Giorgos Tsiapaliokas
On Nov. 26, 2012, 1:43 p.m., Diego Casella wrote: plasmate/CMakeLists.txt, line 102 http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102 I'm wondering if we really need to add a kdepimutils dependency for a simple email validation... Thoughts about that?

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Antonis Tsiapaliokas
On Nov. 26, 2012, 1:43 p.m., Diego Casella wrote: plasmate/CMakeLists.txt, line 102 http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102 I'm wondering if we really need to add a kdepimutils dependency for a simple email validation... Thoughts about that?

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review22572 --- plasmate/CMakeLists.txt

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Diego Casella
On Nov. 26, 2012, 8:53 p.m., Diego Casella wrote: plasmate/CMakeLists.txt, line 102 http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102 I'm wondering if we really need to add a kdepimutils dependency for a simple email validation... Thoughts about that?

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-26 Thread Diego Casella
On Nov. 26, 2012, 1:43 p.m., Diego Casella wrote: plasmate/CMakeLists.txt, line 102 http://git.reviewboard.kde.org/r/107470/diff/1/?file=96184#file96184line102 I'm wondering if we really need to add a kdepimutils dependency for a simple email validation... Thoughts about that?