---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108224/
---
Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
Descr
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108224/#review24788
---
I don't like having a link dependency on plasmagenericshell. If
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
On Monday 07 January 2013, Martin Gräßlin wrote:
> > if that's so, then all that needs be done is to add the shadows by
> > name in the rendering in the tabbox. shadow-top, etc. this can be
> > done easily in the QML itself, and the problem would be solved.
>
> erm how?
>
> Plasm
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
On Monday, January 7, 2013 07:43:22 Weng Xuetian wrote:
> Well.. since my mail to kcd is still being moderated I guess I'd also post
> this patch here.
looks nice and straighforward. huzzah.
--
Aaron J. Seigo
signature.asc
Description: This is a digitally signed message part.
__
On Monday 07 January 2013 12:51:47 Marco Martin wrote:
> On Monday 07 January 2013, Martin Gräßlin wrote:
> > > if that's so, then all that needs be done is to add the shadows by
> > > name in the rendering in the tabbox. shadow-top, etc. this can be
> > > done easily in the QML itself,
Well.. since my mail to kcd is still being moderated I guess I'd also post
this patch here.
RFC: QML shadow patch, and handle mask correctly.
Screen shot.
http://wstaw.org/m/2013/01/07/plasma-desktopoj1171.png
The non-composite side is not affected as far as I tested. Shadow will not
be shown if
14 matches
Mail list logo
