Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- Review request for Plasma and Martin Gräßlin. Description --- I think

Re: Review Request: replace old kickoff with kickoff-qml

> On Sept. 15, 2012, midnight, Daniel Nicoletti wrote: > > Hi, > > I took a quick look over the diffs and using search I could not find what I > > was looking so let me question you :) > > Kickoff-C++ has context menus, used to add applications to favorites, clean > > history, and the feature I

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review18978 --- Hi, I took a quick look over the diffs and using search I could

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Sept. 15, 2012, 4:41 p.m.) Review request for Plasma and Martin G

Re: Review Request: replace old kickoff with kickoff-qml

I'll take a look later, but don't you think it's best to expose the context menu options as data engines services? 2012/9/15 Greg T >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106448/ > Review request for Plasma and Martin Gräßlin. > By G

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review19150 --- wow, what a large patch :-) I still see a lot of code written b

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Sept. 20, 2012, 4:10 p.m.) Review request for Plasma and Martin G

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review19954 --- any updates on this? what are the major blocker still remaining

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? well, to summarize it: - classic menu broken - some minor functionality missing - martin didn't tested it? I think we can address those points also post-review.

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing > - martin didn't tested it? > >

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing > - martin didn't tested it? > >

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing > - martin didn't tested it? > >

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing > - martin didn't tested it? > >

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing > - martin didn't tested it? > >

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 11, 2012, 6:08 p.m.) Review request for Plasma and Martin Gr

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20206 --- ksplash/ksplashqml/SplashWindow.cpp

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 13, 2012, 8:25 p.m.) Review request for Plasma and Martin Gr

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20565 --- At the time I write this, patch R5 won't apply on kde-workspace

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 19, 2012, 6:12 a.m.) Review request for Plasma and Martin Gr

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20585 --- Ship it! Definitely good enough to patch R6 into "master", I t

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20586 --- One tiny nit about the appearance of the search bar and "tradem

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 20, 2012, 8:41 a.m.) Review request for Plasma and Martin Gr

Re: Review Request: replace old kickoff with kickoff-qml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 21, 2012, 10:23 a.m.) Review request for Plasma and Martin G

Re: Review Request: replace old kickoff with kickoff-qml

> On Oct. 19, 2012, 7:47 p.m., Richard Stockton wrote: > > One tiny nit about the appearance of the search bar and "trademark area": > > It is like it was in 4.9, very transparent. Upon first resize, however, the > > background of this area changes into a soft gray -- which IMO, is much > > ea

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

You mean all of them? We have planned to create a dataengine for adding launcher items to the panel but why would you want to expose a 'Sort menu from A-Z'? It's strongly tied to the kickoff model. On Sunday 16 September 2012 00:09:49 Daniel Nicoletti wrote: > I'll take a look later, but don't you

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

On Sunday 16 September 2012, Gregor Tätzner wrote: > You mean all of them? We have planned to create a dataengine for adding > launcher items to the panel but why would you want to expose a 'Sort menu > from A-Z'? It's strongly tied to the kickoff model. yes, stuff like sorting should be just inte

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

Hmm, well I thought you had a dataengine for the applications model, so uninstall, favorite, sort would all be exposed as services, but it seems it's not the case, sure it makes sence since from my experience dataengines are slow with a good amount of data. Anyway I just tought having a dataengine

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

On Sunday 16 September 2012, Daniel Nicoletti wrote: > Hmm, well I thought you had a dataengine for the applications model, > so uninstall, favorite, sort would all be exposed as services, but it > seems it's not the case, sure it makes sence since from my experience > dataengines are slow with a g