Re: Review Request: support brightness keys in the battery applet.

2009-01-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/335/#review328 --- Ship it! Thanks for having a look into it. (I've not tested it

Re: Review Request: support brightness keys in the battery applet.

2009-01-19 Thread Will Stephenson
On 2009-01-19 08:24:39, Sebastian Kügler wrote: Thanks for having a look into it. (I've not tested it yet.) Don't ship it! dannyK says your brightness keys patch will be problematic with most current machines, as they do brightness control in hardware. apparently there's a hal property

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Artur Souza (MoRpHeUz)
Hi =) On Sun, Jan 18, 2009 at 1:19 AM, Matt Rogers ma...@kde.org wrote: This patch adds support for laptop brightness keys on X11. Qt doesn't support these keys yet, so this has to be implemented in a platform specific way and I have provided support for them on X11. Would be a good idea to

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Michael Jansen
On Sunday 18 January 2009 15:23:23 Artur Souza (MoRpHeUz) wrote: Hi =) On Sun, Jan 18, 2009 at 1:19 AM, Matt Rogers ma...@kde.org wrote: This patch adds support for laptop brightness keys on X11. Qt doesn't support these keys yet, so this has to be implemented in a platform specific way

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Artur Souza (MoRpHeUz)
On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen k...@michael-jansen.biz wrote: Why not use KActions here? Any reason for that? Actually KActions would do the job, yes... =) Cheers, -- --- Artur Duque de Souza OpenBossa Research Labs INdT -

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Aaron J. Seigo
On Sunday 18 January 2009, Artur Souza (MoRpHeUz) wrote: On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen k...@michael-jansen.biz wrote: Why not use KActions here? Any reason for that? Actually KActions would do the job, yes... =) given that Qt doesn't know about these keys, it probably

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/335/#review324 --- other than the coding style (we use the kdelibs style) this patch

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Michael Jansen
On Sunday 18 January 2009 19:38:19 Aaron J. Seigo wrote: On Sunday 18 January 2009, Artur Souza (MoRpHeUz) wrote: On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen k...@michael-jansen.biz wrote: Why not use KActions here? Any reason for that? Actually KActions would do the job, yes...

Re: Review Request: support brightness keys in the battery applet.

2009-01-18 Thread Matt Rogers
On Sunday 18 January 2009 13:10:11 you wrote: On Sunday 18 January 2009 19:38:19 Aaron J. Seigo wrote: On Sunday 18 January 2009, Artur Souza (MoRpHeUz) wrote: On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen k...@michael-jansen.biz wrote: Why not use KActions here? Any reason for

Review Request: support brightness keys in the battery applet.

2009-01-17 Thread Matt Rogers
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/335/ --- Review request for Plasma. Summary --- This patch adds support for