---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/
---
(Updated Sept. 22, 2016, 8:41 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/#review99472
---
Closing as this review request is more than 2 years old.
If
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/#review65100
---
My suggestion: just push this if there are no major
On Ago. 23, 2014, 5:58 p.m., Mark Gaiser wrote:
My suggestion: just push this if there are no major objections since doing
that now will have some benefits:
- It is in time for plasma 5.1
- You get some more exposure of users/devs testing it besides just you and
the few that run
On Aug. 23, 2014, 5:58 p.m., Mark Gaiser wrote:
My suggestion: just push this if there are no major objections since doing
that now will have some benefits:
- It is in time for plasma 5.1
- You get some more exposure of users/devs testing it besides just you and
the few that run
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/
---
(Updated Aug. 22, 2014, 8:26 a.m.)
Review request for Plasma, Aaron J.
On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
On Ago. 12, 2014, 11:19 a.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/#review64369
---
For me it looks fine, with some questions:
1) Is this
On Aug. 12, 2014, 1:19 p.m., Christian Esken wrote:
For me it looks fine, with some questions:
1) Is this completely decoupled from KMix? I do not see a open mixer to
open the main application.
2) Is it supposed to be integrated in KMix
3) In general, the question is how to progress
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/
---
(Updated May 4, 2014, 9:46 p.m.)
Review request for Plasma, Aaron J.
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
I also haven't heard about further development here. Diego as original
submitter or somebody else would
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 23, 2014, 12:09 a.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
On March 23, 2014, 12:09 a.m., Mark Gaiser wrote:
Is there still an intention on getting this in KDE 4.xx?
Just wondering since it seems to be much better then the current kmix popup.
Christian Esken wrote:
I also haven't heard about further development here. Diego as original
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/#review53775
---
Is there still an intention on getting this in KDE 4.xx?
Just
On Sept. 2, 2013, 10:32 p.m., Sebastian Kügler wrote:
I've installed the applet, and had a look in more detail. It's coming along
really nicely, and already feels a lot better than the QWidget-based kmix.
:)
Some issues I've found:
- Resizing the popup dialog doesn't resize its
On Sept. 2, 2013, 10:32 p.m., Sebastian Kügler wrote:
I've installed the applet, and had a look in more detail. It's coming along
really nicely, and already feels a lot better than the QWidget-based kmix.
:)
Some issues I've found:
- Resizing the popup dialog doesn't resize its
On Sept. 2, 2013, 10:32 p.m., Sebastian Kügler wrote:
I've installed the applet, and had a look in more detail. It's coming along
really nicely, and already feels a lot better than the QWidget-based kmix.
:)
Some issues I've found:
- Resizing the popup dialog doesn't resize its
On Sunday, September 01, 2013 10:27:27 Diego Casella wrote:
@sebas ping?
It's on my list, sorry for the delay.
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment91
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote:
File Attachment: Vertical Control
http://git.reviewboard.kde.org/r/112208/#fcomment92
Clipping
Diego Casella wrote:
This falls in the known issues - resizing stuff: it is kinda hard to
get the sizes right but the applet
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review39222
---
I've installed the applet, and had a look in more detail. It's
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
On Aug. 28, 2013, 9 p.m., Xuetian Weng wrote:
File Attachment: Control Icon and Label left aligned
http://git.reviewboard.kde.org/r/112208/#fcomment89
It would be nice to have a line here.
svg: widgets/line and element horizontal-line would work here
There's already
On Aug. 29, 2013, 4:05 a.m., Bhushan Shah wrote:
Can't we have it in branch or hosted somewhere on git?
yep, seems like it would be a good idea indeed ... casella-kmix-qml-applet is
the branch I made.
- Diego
---
This is an
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment90
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment87
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38812
---
File Attachment: Control Icon and Label left aligned
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38813
---
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml
On Aug. 28, 2013, 9:10 p.m., Xuetian Weng wrote:
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml, line 55
http://git.reviewboard.kde.org/r/112208/diff/1/?file=183953#file183953line55
if volume is changed from kmix, not from the applet, this would issue a
duplicate
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38823
---
Can't we have it in branch or hosted somewhere on git?
-
On Aug. 26, 2013, 3:38 p.m., Igor Poboiko wrote:
File Attachment: Vertical Control
http://git.reviewboard.kde.org/r/112208/#fcomment83
Do we need it?
(there is volume level percentage under the tooltip)
It isn't consistent with horizontal view where there
On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote:
File Attachment: Menu Actions
http://git.reviewboard.kde.org/r/112208/#fcomment84
Maybe we could align this in the same way as the batter applet does?
Diego Casella wrote:
The menu comes from a right-click from within the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
---
(Updated Aug. 27, 2013, 8:39 a.m.)
Review request for Plasma, Aaron J.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
---
(Updated Aug. 27, 2013, 8:40 a.m.)
Review request for Plasma, Aaron J.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38727
---
File Attachment: Control Icon and Label left aligned
On Aug. 27, 2013, 10:57 a.m., Martin Klapetek wrote:
File Attachment: Control Icon and Label left aligned
http://git.reviewboard.kde.org/r/112208/#fcomment86
I wonder if we still need the speaker icons. The way I see it they
represent two things - one is how loud is this sound
On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote:
File Attachment: Menu Actions
http://git.reviewboard.kde.org/r/112208/#fcomment80
KMix and Phonon are jargon and have to go.
Proposal:
Mixer Setup
Audio Setup
Seems more in line with
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
---
(Updated Aug. 24, 2013, 3:07 p.m.)
Review request for Plasma, Aaron J.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
---
(Updated Aug. 24, 2013, 3:11 p.m.)
Review request for Plasma, Aaron J.
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment77
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment79
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment72
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
On Aug. 22, 2013, 10:46 p.m., Aaron J. Seigo wrote:
File Attachment: Applet Config Options
http://git.reviewboard.kde.org/r/112208/#fcomment73
Do we even really need horizontal/vertical orientation for the sliders
as a configuration option? Other than because we can what is the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/
---
Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin,
On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote:
Overall, it looks pretty good. There's a number of UI, code and coding
style issues there, which will need sorting.
As to coding style, please have a look at
http://community.kde.org/Plasma/QMLStyle
I've pointed some of the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38390
---
File Attachment: Applet Config Options
64 matches
Mail list logo
