Re: Review Request 116625: Oxygen as default font

2014-03-19 Thread Sebastian Kügler
> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. > > Hrvoje Senjan wrote: > i was under the impression that consensus was to go with (only) r116633. >

Re: Review Request 116625: Oxygen as default font

2014-03-19 Thread Sebastian Kügler
> On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: > > startkde.cmake, line 76 > > > > > > Why not just change the defaults in frameworkintegration instead of > > writing directly into users settings? > > Marti

Re: Review Request 116625: Oxygen as default font

2014-03-19 Thread Sebastian Kügler
> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. > > Hrvoje Senjan wrote: > i was under the impression that consensus was to go with (only) r116633. >

Re: Review Request 116625: Oxygen as default font

2014-03-18 Thread Hrvoje Senjan
> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. i was under the impression that consensus was to go with (only) r116633. at least kdeglobals injection *shoul

Re: Review Request 116625: Oxygen as default font

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review53378 --- This review has been submitted with commit c504562c4dc3782879

Re: Review Request 116625: Oxygen as default font

2014-03-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Status -- This change has been m

Re: Review Request 116625: Oxygen as default font

2014-03-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52895 --- Ship it! Sorry for the delay, good to go. - Àlex Fiestas O

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Aleix Pol Gonzalez
> On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote: > > Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? > > > > OTOH, I would say it's fine installing the font from frameworks > > integration, although it makes little difference since frameworks > > integrati

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Martin Gräßlin
> On March 6, 2014, 12:34 p.m., Aleix Pol Gonzalez wrote: > > Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? > > > > OTOH, I would say it's fine installing the font from frameworks > > integration, although it makes little difference since frameworks > > integrati

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
> On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote: > > Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? > > > > OTOH, I would say it's fine installing the font from frameworks > > integration, although it makes little difference since frameworks > > integrati

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52240 --- Is the ttf's the sources of the fonts? We shouldn't distribute

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fi

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
> On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: > > startkde.cmake, line 76 > > > > > > Why not just change the defaults in frameworkintegration instead of > > writing directly into users settings? > > Marti

Re: Review Request 116625: Oxygen as default font

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52225 --- I don't like that the fonts are copied as binaries into our re

Re: Review Request 116625: Oxygen as default font

2014-03-05 Thread Martin Gräßlin
> On March 6, 2014, 3:06 a.m., Hrvoje Senjan wrote: > > startkde.cmake, line 76 > > > > > > Why not just change the defaults in frameworkintegration instead of > > writing directly into users settings? I also do

Re: Review Request 116625: Oxygen as default font

2014-03-05 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52219 --- startkde.cmake

Review Request 116625: Oxygen as default font

2014-03-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- Review request for Plasma. Repository: kde-workspace Description --