Re: Review Request 118017: Fix expansion of ~

2014-05-07 Thread David Faure
On May 6, 2014, 10:01 p.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Alexander Richardson wrote: Okay, I guess this review can be dropped then, right? Yes, I think so. Feel free to commit the unit tests though, that's always good to

Re: Review Request 118017: Fix expansion of ~

2014-05-07 Thread David Faure
On May 6, 2014, 10:01 p.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Alexander Richardson wrote: Okay, I guess this review can be dropped then, right? David Faure wrote: Yes, I think so. Feel free to commit the unit tests

Re: Review Request 118017: Fix expansion of ~

2014-05-07 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 7, 2014, 4:06 p.m.) Status -- This change has been

Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- Review request for Plasma. Repository: kio-extras Description ---

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 --- I'm unsure about the isMalformed check. Did you try the

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Doesn't pass before - Alexander

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't pass

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't pass

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
On May 6, 2014, 12:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57458 --- See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 7, 2014, 12:01 a.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Okay, I guess this review can be dropped then, right? - Alexander --- This is an automatically generated e-mail.