Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58636 --- This review has been submitted with commit ce166ca451c5ce808a

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/ --- (Updated May 28, 2014, 10:04 a.m.) Status -- This change has been ma

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

> On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/dialog.cpp, line 800 > > > > > > Isn't comparison more efficient using QLatin1String? > > Martin Klapetek wrote: > Last time I've hea

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

> On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/dialog.cpp, line 800 > > > > > > Isn't comparison more efficient using QLatin1String? > > Martin Klapetek wrote: > Last time I've hea

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

> On May 27, 2014, 8:36 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/dialog.cpp, line 800 > > > > > > Isn't comparison more efficient using QLatin1String? > > Martin Klapetek wrote: > Last time I've hear

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

> On May 28, 2014, 12:38 a.m., David Edmundson wrote: > > That's frickin' clever! > > We can remove a lot of hacks thanks to this. > > > > Do we even need the last clause? Surely any child window shouldn't close > > the parent? You mean the QMenuClassWindow part? It's a bit tricky opening a Q

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

> On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/dialog.cpp, line 800 > > > > > > Isn't comparison more efficient using QLatin1String? Last time I've heard it's not anymore in Qt5 thanks

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58624 --- Ship it! not sure if is safe to assume to not close when any

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58613 --- That's frickin' clever! We can remove a lot of hacks thanks t

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58609 --- src/plasmaquick/dialog.cpp

Review Request 118361: Don't hide Dialog when opening QMenu from it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/ --- Review request for Plasma. Repository: plasma-framework Description ---