Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 25, 2014, 10:14 a.m.) Review request for Plasma. Changes

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63124 --- Ship it! src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63128 --- Ship it! Ship It! - Marco Martin On July 25, 2014, 10:14

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 25, 2014, 10:57 a.m.) Status -- This change has been

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63152 --- To me, at least on Nvidia seems that graphics gets completely

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Aleix Pol Gonzalez
On July 25, 2014, 1:55 p.m., Marco Martin wrote: To me, at least on Nvidia seems that graphics gets completely broken for popup contents. I think it should watch for widow change and delete the cache/rebuild the textures in that case Do you have a picture? Here (intel) it looks

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
On July 25, 2014, 1:55 p.m., Marco Martin wrote: To me, at least on Nvidia seems that graphics gets completely broken for popup contents. I think it should watch for widow change and delete the cache/rebuild the textures in that case Aleix Pol Gonzalez wrote: Do you have a

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
On July 25, 2014, 1:55 p.m., Marco Martin wrote: To me, at least on Nvidia seems that graphics gets completely broken for popup contents. I think it should watch for widow change and delete the cache/rebuild the textures in that case Aleix Pol Gonzalez wrote: Do you have a

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
On July 25, 2014, 1:55 p.m., Marco Martin wrote: To me, at least on Nvidia seems that graphics gets completely broken for popup contents. I think it should watch for widow change and delete the cache/rebuild the textures in that case Aleix Pol Gonzalez wrote: Do you have a

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
On July 25, 2014, 1:55 p.m., Marco Martin wrote: To me, at least on Nvidia seems that graphics gets completely broken for popup contents. I think it should watch for widow change and delete the cache/rebuild the textures in that case Aleix Pol Gonzalez wrote: Do you have a

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-25 Thread Marco Martin
On July 25, 2014, 1:55 p.m., Marco Martin wrote: To me, at least on Nvidia seems that graphics gets completely broken for popup contents. I think it should watch for widow change and delete the cache/rebuild the textures in that case Aleix Pol Gonzalez wrote: Do you have a

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63049 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Marco Martin
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Aleix Pol Gonzalez
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 24, 2014, 11:14 a.m.) Review request for Plasma. Changes

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Marco Martin
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Aleix Pol Gonzalez
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread David Edmundson
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Marco Martin
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-24 Thread Aleix Pol Gonzalez
On July 24, 2014, 10:55 a.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 45 https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45 Having spoken to you offline this does make sense, but it needs documentation as to why it's

Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review62967 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 23, 2014, 3:35 p.m.) Status -- This change has been

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review62973 --- Ignore the marking as submitted. I had two reviewboard tabs

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Marco Martin
On July 23, 2014, 2:38 p.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 391 https://git.reviewboard.kde.org/r/119425/diff/1/?file=292155#file292155line391 this means every object performs a method on a singleton. Arguably following ones

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
On July 23, 2014, 2:38 p.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 391 https://git.reviewboard.kde.org/r/119425/diff/1/?file=292155#file292155line391 this means every object performs a method on a singleton. Arguably following ones

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
On July 23, 2014, 2:38 p.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 391 https://git.reviewboard.kde.org/r/119425/diff/1/?file=292155#file292155line391 this means every object performs a method on a singleton. Arguably following ones

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Marco Martin
On July 23, 2014, 2:38 p.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 391 https://git.reviewboard.kde.org/r/119425/diff/1/?file=292155#file292155line391 this means every object performs a method on a singleton. Arguably following ones

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
On July 23, 2014, 2:38 p.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 391 https://git.reviewboard.kde.org/r/119425/diff/1/?file=292155#file292155line391 this means every object performs a method on a singleton. Arguably following ones

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Marco Martin
On July 23, 2014, 2:38 p.m., David Edmundson wrote: src/declarativeimports/core/framesvgitem.cpp, line 391 https://git.reviewboard.kde.org/r/119425/diff/1/?file=292155#file292155line391 this means every object performs a method on a singleton. Arguably following ones

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 24, 2014, 12:44 a.m.) Review request for Plasma. Changes