---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/#review66834
---
Ship it!
I haven't actually tried it out, but I really like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/
---
(Updated Sept. 18, 2014, 3:28 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/#review66724
---
src/plasmaquick/dialog.cpp
On Sept. 17, 2014, 11:24 a.m., Vishesh Handa wrote:
src/plasmaquick/dialog.cpp, line 922
https://git.reviewboard.kde.org/r/120235/diff/1/?file=312579#file312579line922
I'm really not sure what is going to happen in this case -
We set the resizeOrigin to Window, call
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/
---
(Updated Sept. 17, 2014, 2:32 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/#review66744
---
The following tests are broken -
1. dialog_positioning.qml
On Sept. 17, 2014, 2:54 p.m., Vishesh Handa wrote:
The following tests are broken -
1. dialog_positioning.qml
2. dialog_positioning2.qml - The animation seems incorrect. Maybe that was
always different and I did not notice?
3. dialog_visualParentChange.qml
1 and 3 were casued by
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/
---
(Updated Sept. 17, 2014, 4:03 p.m.)
Review request for Plasma.
On Sept. 17, 2014, 2:54 p.m., Vishesh Handa wrote:
src/plasmaquick/dialog.cpp, line 301
https://git.reviewboard.kde.org/r/120235/diff/2/?file=312805#file312805line301
Would this actually do anything?
resizeOrigin = MainItem;
// do stuff which changes the size and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/#review66756
---
Do all of the tests now pass?
src/plasmaquick/dialog.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/
---
(Updated Sept. 17, 2014, 4:53 p.m.)
Review request for Plasma.
On Sept. 17, 2014, 4:28 p.m., Vishesh Handa wrote:
Do all of the tests now pass?
yes.
also without resizeorigin but by disconnecting/reconnecting (i tend to like
more using a variable as semaphore rather than have to manually rebuild the
connection status as it being actually more error
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/#review66684
---
We currently have the following ways of changing the dialog
On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote:
We currently have the following ways of changing the dialog size
1. By changing the mainItem size
2. By actually changing the size of the dialog via QML
3. Window Managers
(3) is not something that is exposed to the user since
On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote:
We currently have the following ways of changing the dialog size
1. By changing the mainItem size
2. By actually changing the size of the dialog via QML
3. Window Managers
(3) is not something that is exposed to the user since
On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote:
We currently have the following ways of changing the dialog size
1. By changing the mainItem size
2. By actually changing the size of the dialog via QML
3. Window Managers
(3) is not something that is exposed to the user since
17 matches
Mail list logo
