Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: > > what's the status of this? > > Andrei Amuraritei wrote: > Hi there, this compiles and works, as best I could test it. Still needs > work to port away from kde4support libs. > Sadly my time with it has been null, too busy with work

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Jan. 2, 2015, 11:30 a.m.) Status -- This change has been ma

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Dec. 11, 2014, 10:24 a.m., Marco Martin wrote: > > what's the status of this? > > Andrei Amuraritei wrote: > Hi there, this compiles and works, as best I could test it. Still needs > work to port away from kde4support libs. > Sadly my time with it has been null, too busy with work

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Dec. 11, 2014, 10:24 a.m., Marco Martin wrote: > > what's the status of this? > > Andrei Amuraritei wrote: > Hi there, this compiles and works, as best I could test it. Still needs > work to port away from kde4support libs. > Sadly my time with it has been null, too busy with work

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: > > what's the status of this? Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and other stuff still. - Andrei ---

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- what's the status of this? - Marco Martin On Oct. 17, 2014,

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Oct. 13, 2014, 2:02 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package_plugin.cpp, line 21 > > > > > > I think this should just go into comic_package.cpp to follow all the > > other exports, th

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 3:08 a.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Oct. 13, 2014, 3:02 p.m., Martin Klapetek wrote: > > dataengines/comic/CMakeLists.txt, line 12 > > > > > > Is the KDELibs4Support needed only because of the KStandardDirs? If > > yes, then let's port away fr

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 17, 2014, 2:59 a.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review68304 --- dataengines/comic/CMakeLists.txt

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 12, 2014, 7:06 p.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 12, 2014, 6:53 p.m.) Review request for Plasma, David Edmun

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 20, 2014, 4 p.m., Bhushan Shah wrote: > > dataengines/comic/CMakeLists.txt, line 82 > > > > > > Why this is commented out? The file does not exist anymore; It had only the EXPORT macro in it anyway and

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review67074 --- dataengines/comic/CMakeLists.txt

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 9:33 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package.cpp, line 49 > > > > > > You're building this class as MODULE (ie. a plugin) but you don't > > define any plugin macro (K

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package.cpp, line 49 > > > > > > You're building this class as MODULE (ie. a plugin) but you don't > > define any plugin macro (

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package.cpp, line 49 > > > > > > You're building this class as MODULE (ie. a plugin) but you don't > > define any plugin macro (

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66979 --- Progressing nicely. A piece of advice - leave the codestyle ch

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:17 p.m., Martin Klapetek wrote: > > You need to select the "Update diff" to update the diff, not "Add file" ;) Done :) - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edm

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edm

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66978 --- You need to select the "Update diff" to update the diff, not "

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:15 p.m.) Review request for Plasma, David Edm

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:24 a.m., Martin Klapetek wrote: > > dataengines/comic/comicprovider.h, lines 37-39 > > > > > > Let's remove this macro, it's not just a substitute for > > K_PLUGIN_FACTORY. So remove and r

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66919 --- Hey, thanks for working on this! Couple remarks below, but pre

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 7:53 a.m.) Review request for Plasma, David Edmu