Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69387 --- src/plasma/private/applet_p.cpp

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69385 --- src/plasma/data/notifications/plasmashell.notifyrc

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote: > > src/plasma/private/applet_p.cpp, line 240 > > > > > > The notification should have the plasmoid icon, no? indeed. knotification doesn't have api for just

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 9:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? hmm, really? > On Oct. 29, 2014, 9:39 a.m., Martin

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69388 --- out of interest: what's the bool transient about? src/plasma

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? > > Marco Martin wrote: > hmm, really? out of

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? > > Marco Martin wrote: > hmm, really? > > Mar

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- (Updated Oct. 29, 2014, 10:16 a.m.) Review request for Plasma. Reposito

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 9:49 a.m., Martin Gräßlin wrote: > > src/plasma/private/applet_p.cpp, lines 239-241 > > > > > > not sure whether it's allowed in frameworks: > > > > const QStringList actions({i18n("U

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:49 a.m., Martin Gräßlin wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, lines 7-8 > > > > > > Isn't "Plasmoid" a little bit too techy? > > Marco Martin wrote: > changed (e

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69421 --- I tried to do it in a single squashed commit again on gerrit:

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? > > Marco Martin wrote: > hmm, really? > > Mar

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69405 --- On gerrit you had some code where the destructor had : if (del

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 30, 2014, 3:38 p.m., David Edmundson wrote: > > On gerrit you had some code where the destructor had : if (deletingStatus) > > cleanUpAndDelete > > we need this in case one shuts down during the 1 minute after removing an > > applet? > > > > This will presumably require every look an

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- (Updated Oct. 30, 2014, 5:55 p.m.) Review request for Plasma. Repositor

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69541 --- src/plasma/plasma.h

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 30, 2014, 7:28 p.m., David Edmundson wrote: > > src/plasma/plasma.h, line 256 > > > > > > this compiles? oddly and scary.. yes O.o - Marco --

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- (Updated Oct. 30, 2014, 7:34 p.m.) Review request for Plasma. Repositor

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69596 --- final round of minor comments. src/plasma/private/applet_p.c

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 31, 2014, 4:04 p.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.h, line 375 > > > > > > so why not put it in containmentinterface.h? more complicated bookeeping. in conta

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- (Updated Oct. 31, 2014, 4:31 p.m.) Review request for Plasma. Repositor

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69598 --- Ship it! Ship It! - David Edmundson On Oct. 31, 2014, 4:31

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- (Updated Oct. 31, 2014, 4:49 p.m.) Status -- This change has been ma