Re: Review Request 121473: Port mouse dataengine

2014-12-14 Thread Fredrik Höglund
On Dec. 13, 2014, 4:33 p.m., Andrea Scarpino wrote: > > I know this has already been submitted thanks to Bhushan, but I really have > > to add a -2 here. > > > > This code has clearly not been ported at all! > > > > Did you even test this before you pushed it, or is this a case of "It > > bui

Re: Review Request 121473: Port mouse dataengine

2014-12-14 Thread Andrea Scarpino
On Dec. 13, 2014, 5:33 p.m., Andrea Scarpino wrote: > > I know this has already been submitted thanks to Bhushan, but I really have > > to add a -2 here. > > > > This code has clearly not been ported at all! > > > > Did you even test this before you pushed it, or is this a case of "It > > bui

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/#review71925 --- dataengines/mouse/cursornotificationhandler.cpp

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- (Updated Dec. 13, 2014, 12:50 p.m.) Status -- This change has been m

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- (Updated Dec. 13, 2014, 1:47 p.m.) Review request for Plasma. Changes -

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/#review71916 --- Ship it! Ship It! dataengines/mouse/CMakeLists.txt

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- (Updated Dec. 13, 2014, 1:08 p.m.) Review request for Plasma. Changes -

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- (Updated Dec. 13, 2014, 1:05 p.m.) Review request for Plasma. Changes -

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- (Updated Dec. 13, 2014, 12:53 p.m.) Review request for Plasma. Changes

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- (Updated Dec. 13, 2014, 12:49 p.m.) Review request for Plasma. Changes

Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/ --- Review request for Plasma. Repository: plasma-workspace Description ---