Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- (Updated Jan. 23, 2015, 1:14 p.m.) Status -- This change has been

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/#review74598 --- Ship it! the changed stuff itself looks sensible - Marco

Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- Review request for Plasma and Kai Uwe Broulik. Repository: kdeclarative

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/#review74546 --- Nitpick: Too many whitespaces other then +1. Makes sense to

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- (Updated Jan. 22, 2015, 4:54 p.m.) Review request for Plasma and Kai Uwe

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/#review74548 --- src/qmlcontrols/kcoreaddons/formats.h

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
On Jan. 22, 2015, 5:02 p.m., David Edmundson wrote: src/qmlcontrols/kcoreaddons/formats.h, line 92 https://git.reviewboard.kde.org/r/122200/diff/3/?file=344270#file344270line92 do these work? They are not used anywhere in plasma. But my guess would be they don't. - Martin

Re: Review Request 122200: Add overload method for Formats::formatDuration taking int

2015-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ --- (Updated Jan. 22, 2015, 4:52 p.m.) Review request for Plasma and Kai Uwe