---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
---
(Updated April 6, 2015, 6:09 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review78341
---
Hello?
- Martin Klapetek
On March 24, 2015, 1:19 p.m.,
On April 1, 2015, 4:45 p.m., Martin Klapetek wrote:
Hello?
C++ code looks good to me, QML needs to be reviewed by someone else
- Martin
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review78362
---
Ship it!
In principle I would prefer setting the position by
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review78360
---
Ship it!
Some really minor nit picky things below, feel free
On April 1, 2015, 4:48 p.m., Kai Uwe Broulik wrote:
applets/notifications/plugin/notificationshelper.h, line 35
https://git.reviewboard.kde.org/r/122842/diff/4/?file=356478#file356478line35
If you already have WRITE and NOTIFY, just add a READ too
MEMBER creates an implicit READ
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review78385
---
Thank you for adding usability!
If the checkbox is disabled,
On March 24, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote:
File Attachment: New Screenshot - notifications_config.png
https://git.reviewboard.kde.org/r/122842/#fcomment375
We usually have a title over here.
Ah yeah, I thought there's something missing. That should be a different patch
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
---
(Updated March 24, 2015, 1:19 p.m.)
Review request for Plasma.
Changes
On March 24, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote:
File Attachment: New Screenshot - notifications_config.png
https://git.reviewboard.kde.org/r/122842/#fcomment376
We usually have a title over here.
Martin Klapetek wrote:
Ah yeah, I thought there's something missing.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77996
---
File Attachment: New Screenshot - notifications_config.png
On March 24, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
Nice!
I'm not sure whether a global setting should be in the applet configuration
but fair enough. The Default keeps the previous behavior where it sort-of
follows your panel?
Yes.
On March 24, 2015, 5:22 p.m., Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review78005
---
Nice!
I'm not sure whether a global setting should be in the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
---
(Updated March 11, 2015, 7:09 p.m.)
Review request for Plasma.
Changes
On März 11, 2015, 6:46 nachm., Kai Uwe Broulik wrote:
applets/notifications/package/contents/ui/ScreenPositionSelector.qml, line
37
https://git.reviewboard.kde.org/r/122842/diff/3/?file=354437#file354437line37
Default init it to [] in case somebody forgets to assign to it
For
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77310
---
PlasmaExtra components maybe? I'm still unsure about the
On March 11, 2015, 7:06 p.m., Kai Uwe Broulik wrote:
PlasmaExtra components maybe? I'm still unsure about the notifications on a
per-applet basis :/
We could make them share the config?
- Martin
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
---
(Updated March 11, 2015, 6:55 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77312
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/
---
Review request for Plasma.
Bugs: 344841
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review77114
---
File Attachment: Screenshot - notification_pos.png
21 matches
Mail list logo
