Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 23, 2015, 12:04 p.m.) Status -- This change has been

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77964 --- Ship it! Ship It! - David Edmundson On March 13, 2015, 12:

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 13, 2015, 12:04 p.m.) Review request for KDE Frameworks an

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 7 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 122886: QML-only KCM base

> On March 10, 2015, 11:30 a.m., Marco Martin wrote: > > src/quickaddons/configmodule.h, line 43 > > > > > > I don't particularly like the KDeclarative namespace here since the > > library is called QuickAddons,

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks and

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.h, line 373 > > > > > > I guess you copy and pasted all these. > > KConfigXT isn't relevant at all here. yes, is pretty

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- src/quickaddons/configmodule.h

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 11, 2015, 5:05 p.m.) Review request for KDE Frameworks and

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77309 --- src/quickaddons/CMakeLists.txt

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs

Re: Review Request 122886: QML-only KCM base

> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs

Re: Review Request 122886: QML-only KCM base

> On March 10, 2015, 11:33 a.m., Marco Martin wrote: > > src/quickaddons/configmodule.cpp, line 167 > > > > > > I didn't test things that need authentication yet (if some good soul > > ports a module that uses i

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77248 --- src/quickaddons/configmodule.cpp

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77247 --- src/quickaddons/configmodule.h

Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative