Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-20 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80655 --- Ship it! Ship It! - Eike Hein On May 18, 2015, 7:40 p.m.,

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-18 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 18, 2015, 7:40 e.m.) Review request for Plasma and Eike

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80550 --- Aside from the string issue I think this is fine now.

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-17 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 17, 2015, 8:01 e.m.) Review request for Plasma and Eike

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-13 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 13, 2015, 3:45 e.m.) Review request for Plasma and Eike

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-13 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80309 --- The implementation is fine (modulo the nitpick) and I'm on

Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-12 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80256 --- applets/taskmanager/package/contents/ui/main.qml (line 237)