Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-27 Thread Martin Klapetek
> On May 18, 2015, 10:46 a.m., Martin Klapetek wrote: > > Fwiw, I think it would be much better if the dataengine actually signalled > > the disk space change rather than polling, then the applet could just > > handle the incoming "changed" signals -> less polling around. > > Yoann Laissus wro

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-27 Thread Yoann Laissus
> On mai 18, 2015, 8:46 matin, Martin Klapetek wrote: > > Fwiw, I think it would be much better if the dataengine actually signalled > > the disk space change rather than polling, then the applet could just > > handle the incoming "changed" signals -> less polling around. What mechanism do you

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80566 --- Fwiw, I think it would be much better if the dataengine actual

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated May 17, 2015, 11:01 a.m.) Status -- This change has been ma

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80511 --- Ship it! Ship It! - Kai Uwe Broulik On Mai 17, 2015, 9:42

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Yoann Laissus
> On mai 16, 2015, 10:33 après-midi, Kai Uwe Broulik wrote: > > I think it should be refreshed whenever you hover a device, not every 5 > > seconds needlessly consuming resources when you don't look at it. You're right. The refresh is now triggered only when the device notifier is visible. -

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated mai 17, 2015, 9:42 matin) Review request for Plasma. Changes -

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80492 --- I think it should be refreshed whenever you hover a device, no

Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-16 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- Review request for Plasma. Repository: plasma-workspace Description ---