Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81486 --- +1 *evil laughing up my sleeve* dataengines/notifications/n

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81489 --- A better option would be to call registerService() with QDBus

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Martin Klapetek
> On June 15, 2015, 9:29 p.m., Lukáš Tinkl wrote: > > A better option would be to call registerService() with > > QDBusConnectionInterface::ReplaceExistingService and > > DBusConnectionInterface::AllowReplacement It's the "attempt to replace it." part of it that I'm not entirely happy with. P

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-17 Thread Xuetian Weng
> On June 15, 2015, 7:29 p.m., Lukáš Tinkl wrote: > > A better option would be to call registerService() with > > QDBusConnectionInterface::ReplaceExistingService and > > DBusConnectionInterface::AllowReplacement > > Martin Klapetek wrote: > It's the "attempt to replace it." part of it tha

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/ --- (Updated June 22, 2015, 8:54 a.m.) Status -- This change has been ma