Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On 9月 14, 2015, 8:12 p.m., Aleix Pol Gonzalez wrote: > > Do you have a developer account? Otherwise I'll submit the patch for you. Yes I got it a few days ago :) I'd like to submit this by myself. Thanks again. - Takahiro --- This is

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated Sept. 14, 2015, 12:39 p.m.) Status -- This change has been

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review85371 --- Ship it! Do you have a developer account? Otherwise I'll

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On 9月 3, 2015, 12:41 a.m., Aleix Pol Gonzalez wrote: > > Good stuff! > > > > +1 Thanks Aleix:) Could I have more comments from any other guys? :) - Takahiro --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 9月 11, 2015, 10:01 p.m.) Review request for Plasma. Changes

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 9月 3, 2015, 12:18 a.m.) Review request for Plasma. Changes

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On 9月 2, 2015, 11:14 p.m., Alex Richardson wrote: > > startkde/kstartupconfig/kdostartupconfig.cpp, line 86 > > > > > > `QByteArray buf = keys.readLine()` > > > > I don't see the point of preallocation

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84772 --- Good stuff! +1 - Aleix Pol Gonzalez On Sept. 2, 2015,

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On Aug. 31, 2015, 7 p.m., Aleix Pol Gonzalez wrote: > > To be honest, I don't see how this should make a difference... > > Takahiro Hashimoto wrote: > I'm sorry for lacking of my explanation... > > > Please see the difference of QString::fromLocal8Bit(const QByteArray > )

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84764 --- startkde/kstartupconfig/kdostartupconfig.cpp (line 86)

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On Sept. 2, 2015, 3:14 p.m., Alex Richardson wrote: > > startkde/kstartupconfig/kdostartupconfig.cpp, line 86 > > > > > > `QByteArray buf = keys.readLine()` > > > > I don't see the point of

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 9月 1, 2015, 1:33 a.m.) Review request for Plasma. Changes

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84659 --- To be honest, I don't see how this should make a

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On 9月 1, 2015, 2 a.m., Aleix Pol Gonzalez wrote: > > To be honest, I don't see how this should make a difference... I'm sorry for lacking of my explanation... Please see the difference of QString::fromLocal8Bit(const QByteArray ) implementation between Qt 5.5 and 5.6 (5.5)

Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- Review request for Plasma. Bugs:

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 8月 22, 2015, 8:06 p.m.) Review request for Plasma. Bugs:

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 8月 22, 2015, 8:07 p.m.) Review request for Plasma. Bugs: