Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-25 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/ --- (Updated Nov. 25, 2015, 2:04 p.m.) Status -- This change has been

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-17 Thread Sebastian Kügler
On Monday, November 16, 2015 04:16:26 PM Johan Ouwerkerk wrote: > > Are we just disabling it and then be done? > > That is not what this change is about. The change rectifies an inconsistency > between the top level cmake configure stuff which checks the build > environment for dependencies, and

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-17 Thread Sebastian Kügler
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote: > > Ship It! > > Johan Ouwerkerk wrote: > Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep > branch at: g...@github.com:cmacq2/plasma-desktop.git > > Johan Ouwerkerk wrote: > Please note: I do not have

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-16 Thread Johan Ouwerkerk
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote: > > Ship It! > > Johan Ouwerkerk wrote: > Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep > branch at: g...@github.com:cmacq2/plasma-desktop.git > > Johan Ouwerkerk wrote: > Please note: I do not have

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-16 Thread Sebastian Kügler
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote: > > Ship It! > > Johan Ouwerkerk wrote: > Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep > branch at: g...@github.com:cmacq2/plasma-desktop.git > > Johan Ouwerkerk wrote: > Please note: I do not have

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-16 Thread Martin Gräßlin
> On Nov. 10, 2015, 2:26 a.m., David Edmundson wrote: > > Ship It! > > Johan Ouwerkerk wrote: > Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep > branch at: g...@github.com:cmacq2/plasma-desktop.git > > Johan Ouwerkerk wrote: > Please note: I do not have

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-14 Thread Johan Ouwerkerk
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote: > > Ship It! > > Johan Ouwerkerk wrote: > Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep > branch at: g...@github.com:cmacq2/plasma-desktop.git Please note: I do not have commit access (just a KDE identity

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-09 Thread Johan Ouwerkerk
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote: > > Ship It! Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep branch at: g...@github.com:cmacq2/plasma-desktop.git - Johan --- This is an automatically

Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-09 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126013/#review88208 --- Ship it! Ship It! - David Edmundson On Nov. 10, 2015,