Re: Review Request 127498: Cleanup warnings

2016-04-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/ --- (Updated April 1, 2016, 8:47 a.m.) Status -- This change has been

Re: Review Request 127498: Cleanup warnings

2016-03-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/ --- (Updated March 31, 2016, 7:14 p.m.) Review request for Plasma.

Re: Review Request 127498: Cleanup warnings

2016-03-31 Thread David Rosca
> On March 31, 2016, 1:47 p.m., Sebastian Kügler wrote: > > src/card.cpp, line 47 > > > > > > Perhaps we can just drop this conditional and make it require PA >= 5.0? > > > > The reason is to reduce

Re: Review Request 127498: Cleanup warnings

2016-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/#review94153 --- Fix it, then Ship it! Ship It! src/card.cpp (line 47)

Re: Review Request 127498: Cleanup warnings

2016-03-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/ --- (Updated March 26, 2016, 9:07 a.m.) Review request for Plasma. Changes

Review Request 127498: Cleanup warnings

2016-03-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/ --- Review request for Plasma. Repository: plasma-pa Description ---