---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---
(Updated May 25, 2016, 11:03 a.m.)
Status
--
This change has been
> On May 22, 2016, 11:49 a.m., David Faure wrote:
> > Looks fine to me, except for the reasoning in the commit log. It's
> > perfectly fine to reimplement an existing virtual method from a base class
> > into a derived class, this doesn't break ABI.
>
> Kai Uwe Broulik wrote:
> But Abi
> On Mai 22, 2016, 11:49 vorm., David Faure wrote:
> > Looks fine to me, except for the reasoning in the commit log. It's
> > perfectly fine to reimplement an existing virtual method from a base class
> > into a derived class, this doesn't break ABI.
But Abi wiki page says you cannot if it's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95698
---
Fix it, then Ship it!
Looks fine to me, except for the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---
(Updated Mai 19, 2016, 9:37 nachm.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---
(Updated Mai 19, 2016, 9:35 nachm.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95628
---
+1
src/ktoolbar.cpp (line 815)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---
Review request for KDE Frameworks and Plasma.
Repository: kxmlgui
