Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

> On June 5, 2016, 2:11 p.m., Thomas Pfeiffer wrote: > > First of all, as for any visual changes: Please provide before/after > > screenshots so that designers can do visual reviews. > > > > Second: I am strictly against making this an option. Either it's an > > improvement, then it should alw

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/#review96200 --- First of all, as for any visual changes: Please provide befor

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

> On 六月 4, 2016, 4:02 p.m., Yichao Yu wrote: > > LGTM, this should be added to the configure UI. The tab for popup menu > > should work. The .ui file needs to be updated to include the checkbox for > > this and a corresponding rule should be added to the .cpp file (There > > should already be

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

> On June 4, 2016, 10:02 p.m., Yichao Yu wrote: > > LGTM, this should be added to the configure UI. The tab for popup menu > > should work. The .ui file needs to be updated to include the checkbox for > > this and a corresponding rule should be added to the .cpp file (There > > should already

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/#review96189 --- LGTM, this should be added to the configure UI. The tab for p

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

> On June 4, 2016, 5:52 p.m., Yichao Yu wrote: > > qt4/style/qtcurve.cpp, line 6171 > > > > > > Hm? Shouldn't this use the option? Of course it should, thanks, missed that one. - René J.V. -

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/ --- (Updated June 4, 2016, 9:53 p.m.) Review request for KDE Software on Mac

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/#review96183 --- qt4/style/qtcurve.cpp (line 6171)

Review Request 128097: optional mode to draw checked menu items with only a check mark

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/ --- Review request for KDE Software on Mac OS X, Plasma and Yichao Yu. Reposi