Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 15, 2016, 10:47 a.m.) Status -- This change has been m

Re: Review Request 128108: update weather applet ui

> On Juni 8, 2016, 12:11 vorm., Friedrich W. H. Kossebau wrote: > > applets/weather/package/contents/ui/WeatherListView.qml, line 39 > > > > > > Instead of making the rectangle transparent, turn it into a normal

Re: Review Request 128108: update weather applet ui

> On June 14, 2016, 5:45 a.m., Andreas Kainz wrote: > > can I get a ship it to get it in plasma 5.7, or any feedback what I have to > > improve. Ah, pardon, missed that your last comment actually came with an update to the patch. Looks good codewise, besides that one issue which I just reopene

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96450 --- can I get a ship it to get it in plasma 5.7, or any feedback

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 10, 2016, 10:37 p.m.) Review request for Plasma and Friedri

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96349 --- With the latest diff I get these runtime errors on the consol

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 8, 2016, 10:25 p.m.) Review request for Plasma and Friedric

Re: Review Request 128108: update weather applet ui

> On June 8, 2016, 12:11 a.m., Friedrich W. H. Kossebau wrote: > > applets/weather/package/contents/ui/main.qml, lines 117-118 > > > > > > There is still "units.Spacing" set for the bottomMargin, which will > >

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96287 --- Pretty good for your first QML patch :) But there are a few

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 7, 2016, 11:46 a.m.) Review request for Plasma and Friedric

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96254 --- almost good to go, still a couple of issues applets/weather

Re: Review Request 128108: update weather applet ui

> On Juni 6, 2016, 7:39 vorm., Sebastian Kügler wrote: > > applets/weather/package/contents/ui/TopPanel.qml, line 34 > > > > > > add a spacer Item instead of putting in magical numbers > > Andreas Kainz wrote: >

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 6, 2016, 8:41 p.m.) Review request for Plasma and Friedrich

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 6, 2016, 8:36 p.m.) Review request for Plasma and Friedrich

Re: Review Request 128108: update weather applet ui

> On Juni 6, 2016, 7:39 vorm., Sebastian Kügler wrote: > > applets/weather/package/contents/ui/TopPanel.qml, line 34 > > > > > > add a spacer Item instead of putting in magical numbers what's a spacer item? - A

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96217 --- applets/weather/package/contents/ui/TopPanel.qml (line 34) <

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96215 --- applets/weather/package/contents/ui/WeatherListView.qml (lin

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 6, 2016, 6:48 a.m.) Review request for Plasma and Friedrich

Re: Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 6, 2016, 6:47 a.m.) Review request for Plasma and Friedrich

Review Request 128108: update weather applet ui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- Review request for Plasma and Friedrich W. H. Kossebau. Repository: kdepl