Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 5, 2016, 10:02 a.m.) Status -- This change has been ma

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98121 --- Ship it! Ship It! - David Edmundson On Aug. 4, 2016, 9:

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 4, 2016, 9:11 p.m.) Review request for KDE Frameworks and P

Re: Review Request 128597: support a size for adding applets

> On Aug. 4, 2016, 1:28 p.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 248 > > > > > > QSize::isNull > > > > "Returns true if both the width and height is

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98103 --- src/scriptengines/qml/plasmoid/containmentinterface.cpp (lin

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 4, 2016, 12:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98101 --- I got to the signal and stopped reading. This is a trillion

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 4, 2016, 11:44 a.m.) Review request for KDE Frameworks and

Re: Review Request 128597: support a size for adding applets

> On Aug. 4, 2016, 11:01 a.m., David Edmundson wrote: > > This makes no sense. > > > > An AppletInterface (which you're emitting the signal for) already has a > > width and height property. > > > > (it does have an x,y, but there're relative to the applet container not the > > containment) >

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98095 --- This makes no sense. An AppletInterface (which you're emitti

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98094 --- src/scriptengines/qml/plasmoid/containmentinterface.h (line

Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor