Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Sept. 14, 2016, 11:04 a.m.) Status -- This change has been

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review99162 --- Ship it! Good solution, makes total sense. - Sebastian Kü

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review99161 --- Fix it, then Ship it! Make sure to update your commit mess

Re: Review Request 128707: Add support for captive portals

> On Zář. 14, 2016, 8:36 dop., Kai Uwe Broulik wrote: > > kded/portalmonitor.cpp, line 58 > > > > > > Is it ensured that this notification doesn't constantly pop up, ie. > > does connectivity only change once I c

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Zář. 14, 2016, 9:02 dop.) Review request for Network Management,

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review99159 --- kded/portalmonitor.cpp (line 35)

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Zář. 14, 2016, 7:05 dop.) Review request for Network Management,

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98920 --- >From my perspective using www.kde.org for the browser part o

Re: Review Request 128707: Add support for captive portals

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DD

Re: Review Request 128707: Add support for captive portals

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DD

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Zář. 6, 2016, 7:37 dop.) Review request for Network Management,

Re: Review Request 128707: Add support for captive portals

> On Zář. 5, 2016, 3:47 odp., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > > > > > I am wondering how hard this waill affect kde.org web server. This > > patch has the potentional to create a DDo

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98901 --- kded/portalmonitor.h (line 22)

Re: Review Request 128707: Add support for captive portals

> On Srp. 31, 2016, 2 odp., Kai Uwe Broulik wrote: > > I just logged into an airport wifi and although I couldn't access the > > internet and was redirected to a login site, NM would *not* detect it as > > Portal... what am I missing? I guess this - https://plus.google.com/u/0/+HonzaGrulich/po

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98809 --- I just logged into an airport wifi and although I couldn't ac

Re: Review Request 128707: Add support for captive portals

> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote: > > I'm not happy with the QWebEngineView as that's going to crash on Wayland. > > Every application using QWebEngine needs to be on xcb unfortunately. So > > that means that we cannot really use anything of QWebEngine in Plasma > > (which i

Re: Review Request 128707: Add support for captive portals

> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote: > > I'm not happy with the QWebEngineView as that's going to crash on Wayland. > > Every application using QWebEngine needs to be on xcb unfortunately. So > > that means that we cannot really use anything of QWebEngine in Plasma > > (which i

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98490 --- I'm not happy with the QWebEngineView as that's going to cras

Re: Review Request 128707: Add support for captive portals

> On Aug. 18, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > While I really appreciate that we get support for this I don't think just > > opening a webview automatically is a good idea. > > > > Can we perhaps show a notification [1] "log in to this network" with a > > button that will then open

Re: Review Request 128707: Add support for captive portals

> On Aug. 18, 2016, 12:37 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 44 > > > > > > You should delete m_view here in case this module is unloaded from > > kded5. > > Jan Grulich wrote: > Is

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98475 --- kded/service.cpp (line 31)

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Srp. 18, 2016, 12:47 odp.) Review request for Network Management

Re: Review Request 128707: Add support for captive portals

> On Srp. 18, 2016, 12:37 odp., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 44 > > > > > > You should delete m_view here in case this module is unloaded from > > kded5. Isn't this purpose of QScopedPo

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98470 --- kded/portalmonitor.cpp (line 44)

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98468 --- kded/portalmonitor.cpp (line 25)

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98467 --- Fix it, then Ship it! kded/portalmonitor.cpp (line 51)

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Srp. 18, 2016, 11:42 dop.) Review request for Network Management

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98462 --- kded/service.cpp (line 49)

Re: Review Request 128707: Add support for captive portals

> On Srp. 18, 2016, 10:27 dop., Kai Uwe Broulik wrote: > > While I really appreciate that we get support for this I don't think just > > opening a webview automatically is a good idea. > > > > Can we perhaps show a notification [1] "log in to this network" with a > > button that will then open

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Srp. 18, 2016, 10:58 dop.) Review request for Network Management

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98460 --- While I really appreciate that we get support for this I don'

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98459 --- kded/portalmonitor.h (line 43)

Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- Review request for Network Management, Plasma, KDE Usability, and Lamarque