D24855: Rename "Close Edit Mode" tooltip to just "Close"

2019-10-29 Thread Björn Feber
GB_2 updated this revision to Diff 68986. GB_2 added a comment. "Close" -> "Finish Customizing Layout" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24855?vs=68514&id=68986 BRANCH arcpatch-D24855 REVISION DETAIL https://phabricator.kde.org/D24

D25053: Don't show "Customize Layout..." menu item in panel context menu

2019-10-29 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY "Edit Panel..." already enters the edit mode, so there's no need to clutter the context menu with anot

D24744: Remove unneeded options in GTK KCM

2019-10-30 Thread Björn Feber
GB_2 added a comment. I'd be fine with that (we could always add it later in the Application Style KCM when we have it for Qt). REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plas

D25053: Don't show "Customize Layout..." menu item in panel context menu

2019-10-30 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:968a136f4243: Don't show "Customize Layout..." menu item in panel context menu (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25053?vs=

D24855: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout"

2019-10-30 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a74c3657a071: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout" (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24855?vs=689

D25055: [containments/desktop] Delete the "Tweaks" page and its options

2019-10-30 Thread Björn Feber
GB_2 added a comment. In D25055#556751 , @mart wrote: > I would prefer keeping the press to move stuff Is there a reason to disable it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, m

D25055: [containments/desktop] Delete the "Tweaks" page and its options

2019-10-30 Thread Björn Feber
GB_2 added a comment. I wonder, can that be added to mouse actions instead of a page with only one option? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jra

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-10-30 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, rag

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-10-31 Thread Björn Feber
GB_2 updated this revision to Diff 69127. GB_2 added a comment. Move into AudioStream REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65691&id=69127 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-10-31 Thread Björn Feber
GB_2 updated this revision to Diff 69128. GB_2 added a comment. Remove unneeded properties REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=69127&id=69128 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTE

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-10-31 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:da268696a6af: [Task Manager] Toggle mute when the audio indicator is clicked (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=6912

D24744: Remove unneeded options in GTK KCM

2019-11-10 Thread Björn Feber
GB_2 added a comment. Ok, then we should keep it in the GTK KCM until we have the option for Qt applications. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00

D24798: Migrate QQC1 to QQC2

2019-11-14 Thread Björn Feber
GB_2 added a comment. In D24798#562431 , @guoyunhe wrote: > Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. Yeah, that is a general pre

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-11-16 Thread Björn Feber
GB_2 added a comment. @hein If you really still think we shouldn't do this then I can change this patch to only affect the "Show Only Minimized" option and close the bug as INTENTIONAL. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma,

D25351: [Style KCM] Change name to KDE/Qt Application Style

2019-11-17 Thread Björn Feber
GB_2 added a comment. I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the toolbar style)? I wouldn't rename the KCM until we are sure that we don't want to merge the two KCMs. REPOSITORY R1

D25351: [Style KCM] Change name to KDE/Qt Application Style

2019-11-17 Thread Björn Feber
GB_2 added a comment. In D25351#563677 , @ngraham wrote: > I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the remaining KCM can keep its current name ("Application Style"). I'm in favor of that, but we

D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows

2019-11-17 Thread Björn Feber
GB_2 added a comment. Ping :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma, davidedmundson, mart Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-18 Thread Björn Feber
GB_2 added a comment. In D25381#564370 , @ngraham wrote: > +1 conceptually, this will be nice to finally have fixed. > > But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if w

D25381: Make QPushButton/QToolButton the same height as QLineEdit

2019-11-18 Thread Björn Feber
GB_2 added a comment. Plus in the screenshot it looks like it's still not quite the same heihgt. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

2019-11-29 Thread Björn Feber
GB_2 added a comment. In D25361#566193 , @ngraham wrote: > I share you concern about this KCM becoming a dumping ground. But I don't see a better place for this setting right now. And I think it does make some sense for it to hold general behavi

D25633: Fix Cuttlefish mouse click selection in icon grid

2019-11-30 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Fixes the selection preview being changed before the selection rectangle changes. TEST PLAN Click o

D25635: Add icon to browser integration do not remind menu item

2019-11-30 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7791325: Plasma Browser Integration Do Not Remind Menu Item Icon.png

D25635: Add icon to browser integration do not remind menu item

2019-11-30 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R856:e37eef54ab35: Add icon to browser integration do not remind menu item (authored by GB_2). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25635?vs

D25633: Fix Cuttlefish mouse click selection in icon grid

2019-11-30 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R118:dd263acd2f62: Fix Cuttlefish mouse click selection in icon grid (authored by GB_2). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25633?vs=70626&id=70637 REVIS

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2019-12-03 Thread Björn Feber
GB_2 added a comment. Works now :-) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliez

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2019-12-03 Thread Björn Feber
GB_2 added a comment. In D24275#571532 , @cblack wrote: > In D24275#571531 , @GB_2 wrote: > > > Works now :-) > > > With the cmake or the meson? Meson. REPOSITORY R99 KDE Gtk Configur

D25844: Add grouping options in Icons-only Task Manager

2019-12-10 Thread Björn Feber
GB_2 added a comment. I already made a patch for this: D23242 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25945: Sync dark theme preference for GTK3 applications

2019-12-14 Thread Björn Feber
GB_2 added a comment. Works perfectly fine for me without waiting. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Z

D25670: Synchronize decorations buttons order in GTK headerbars

2019-12-14 Thread Björn Feber
GB_2 added a comment. Works great! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, h

D22684: [Klipper] Fix clipboard history management

2019-12-16 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: GB_2, davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, Zre

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-17 Thread Björn Feber
GB_2 added a comment. Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, al

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

2019-12-17 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg, #plasma Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, les

D25945: Sync dark theme preference for GTK3 applications

2019-12-17 Thread Björn Feber
GB_2 added a comment. In D25945#577731 , @gikari wrote: > In D25945#577677 , @cblack wrote: > > > For flatpaks not respecting the setting preference, have you checked that the dark theme variant is i

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

2019-12-21 Thread Björn Feber
GB_2 added a comment. Can you please try to further investigate this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBo

D19788: [service runner] throw out kde3 "compat" code

2019-03-15 Thread Björn Feber
GB_2 added a comment. This is bug 383287 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, move the KCM below the Application Style KCM, drop the word GNOME, update strings a

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:1 > All this not saying they're right or wrong but unrelated to the change at > stake. I'll remove the things that weren't here before, but this is just sorting the desktop entry to make it consistent with other

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 53994. GB_2 added a comment. Clean desktop file REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53967&id=53994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FILE

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:59 > Then do it so I can accept the patch I already did it. > apol wrote in gtkconfigkcmodule.cpp:65 > That's fine, but you can do it in a separate patch. I'm already updating the strings here. I always did this

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 54026. GB_2 added a comment. Add back word GNOME and update GHNS button tooltip REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53994&id=54026 BRANCH master REVISION DETAIL https://phabricat

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 54032. GB_2 added a comment. Improve and clean UI REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54026&id=54032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FI

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 54033. GB_2 added a comment. Fix groupbox widths REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54032&id=54033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FIL

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-17 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R99:36dd29f8b65a: Improve the look of the GTK Application Style KCM UI (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=5403

D19788: [service runner] throw out kde3 "compat" code

2019-03-18 Thread Björn Feber
GB_2 added a comment. GTK+ was recently renamed to GTK (https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg0.html). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel,

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080. Please also change the user images to the colorful Konqi and Katie ones. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.k

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. In D19469#435183 , @rooty wrote: > In D19469#435175 , @GB_2 wrote: > > > The file size is quite big (you can change the compression in Spectacle) and I think the resolution shou

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. BTW, it's still not 1920x1080. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, a

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. In D19469#435216 , @rooty wrote: > In D19469#435215 , @GB_2 wrote: > > > BTW, it's still not 1920x1080. > > > Noted. (Why is that relevant though?) Much more common

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. In D19469#435220 , @rooty wrote: > F6703853: image.png > > This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for or

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-03-31 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406079 Move these two buttons to the left/top of the panel edit mode toolbar. Horizontal

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-03-31 Thread Björn Feber
GB_2 added a comment. In D20144#441083 , @ngraham wrote: > +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-03-31 Thread Björn Feber
GB_2 added a comment. In D20144#441087 , @ngraham wrote: > Maybe just switch the buttons' positions and add a spacer between them, then? I can try putting a spacer or seperator between the 2 buttons, but if I switch the positions of thos

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-04-01 Thread Björn Feber
GB_2 updated this revision to Diff 55225. GB_2 added a comment. Add separator and spacer between the two buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20144?vs=55139&id=55225 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D19077: Redesign the theme preview window

2019-04-02 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D19829: kicker: add option to make root level icons visible

2019-04-02 Thread Björn Feber
GB_2 added a comment. In D19829#432852 , @i.Dark_Templar wrote: > Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it ma

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-02 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, ale

D19077: Redesign the theme preview window

2019-04-02 Thread Björn Feber
GB_2 added a comment. I like B too. BTW, can "Background:" and the background selection button be centered like in a form layout? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2, mmusta

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-04-02 Thread Björn Feber
GB_2 added subscribers: rooty, filipf, abetts, ndavis. GB_2 added a comment. In D20144#441802 , @ngraham wrote: > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them? T

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-04-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:da0adfedcab0: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2014

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber
GB_2 added a comment. Is this okay with a form layout? F6753594: Adjusted SDDM KCM Background Label and Button.png If yes, I will take over this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber
GB_2 added a comment. @rooty Can you please reopen this? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: rooty, #vdg, #plasma, filipf, ngraham, GB_2 Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber
GB_2 commandeered this revision. GB_2 edited reviewers, added: rooty; removed: GB_2. GB_2 added a comment. Ok, thanks. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham, rooty Cc: GB_2, abetts, plasm

D20266: Add new notification plasmoid

2019-04-05 Thread Björn Feber
GB_2 added a comment. Amazing! INLINE COMMENTS > FullRepresentation.qml:247 > +opacity: 0.6 > +text: list.count === 0 ? i18n("No unread notifications.") : > i18n("Notifications") > +} Please remove the dot to make it consistent with other Plasmoids. REPOSITO

D20266: Add new notification plasmoid

2019-04-05 Thread Björn Feber
GB_2 added a comment. I made a better timeout indicator that you can use: F6755221: TimeoutIndicator.qml This is how it looks like: F6755222: Circular Timeout.mp4 REPOSITORY R120 Plasma Workspace REVISION DETA

D19209: [sddm-kcm] Adjust Background label and button

2019-04-06 Thread Björn Feber
GB_2 added a comment. I think I can leave it how it is now. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham

D18419: Adjust some KCMs to implement new Appearance section layout

2019-04-08 Thread Björn Feber
GB_2 added a comment. In D18419#400163 , @davidedmundson wrote: > > Improve text on existing QWidgets KCMs to conform to the HIG > > After this. > > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG > > After

D19209: [sddm-kcm] Adjust Background label and button

2019-04-08 Thread Björn Feber
GB_2 closed this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20093: Show a context menu on pressAndHold

2019-04-08 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20093 To: apol, #plasma, mart Cc: GB_2, davidedmundson, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20043: digitalclock: have it display a context menu onPressAndHold

2019-04-08 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace BRANCH digiclock REVISION DETAIL https://phabricator.kde.org/D20043 To: apol, #plasma, ngraham Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

2019-04-09 Thread Björn Feber
GB_2 added a comment. In D18419#446564 , @davidedmundson wrote: > From my last comment > > >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > > > > > This is by /far/ the mo

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-09 Thread Björn Feber
GB_2 added a comment. In D17410#446874 , @Codezela wrote: > This icon have a lot of details for this small size we need more clear one I guess The icon was added here: D20367 I think it's still ok, b

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-09 Thread Björn Feber
GB_2 added a comment. Nice, thank you so much! INLINE COMMENTS > ConfigOverlay.qml:392 > +iconSource: "preferences-desktop-default-applications" > +text: i18n("Alternatives...") > +enabled: > currentApplet.applet.action("alternative

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 commandeered this revision. GB_2 edited reviewers, added: davidedmundson; removed: GB_2. GB_2 added a comment. Sure! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngrah

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 added a comment. BTW, @davidedmundson or someone else: How do I get the icon name/source here: `iconSource: plasmoid.action("alternatives").icon`? It currently returns a QIcon, but I want the name/source of it from QML. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55958. GB_2 edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55856&id=55958 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2, #

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55959. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55958&id=55959 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2, #plasma,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55960. GB_2 added a comment. Try to fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55959&id=55960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containmen

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. In D17410#448756 , @davidedmundson wrote: > > It currently returns a QIcon, but I want the name/source of it from QML. > > What for? So I can use the same icon that is in the context menu REPOSITORY R119 Plasm

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. in the toolbutton icon source/name property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvid

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. In D17410#448842 , @davidedmundson wrote: > Toolbutton should be able to take a qicon as a source Nope, when I use `iconSource: plasmoid.action("alternatives").icon` this happens: `ConfigOverlay.qml:392:21: Unable

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. It seems like Elisa has a function to do this: https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083 Maybe something like this could be added to KDE/Plasma Franeworks? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.k

D18546: [Desktop Toolbox] Use "tools" icon

2019-04-12 Thread Björn Feber
GB_2 added a comment. I think this revision can be abandoned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18546 To: ngraham, #vdg, #plasma Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreut

D19829: kicker: add option to make root level icons visible

2019-04-12 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-13 Thread Björn Feber
GB_2 added a comment. Or we could just leave it how it is now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhans

D18419: Adjust some KCMs to implement new Appearance section layout

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Port the KCM to the new GriedView KCM design. F6771665: Improved Plymouth Boot Splash Screen KCM UI.p

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D20536 TEST PLAN Open the avatar gallery. REPOSITOR

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ok, the problem is that now the default user icon doesn't work with a dark theme. I think we should just provide it in `breeze-icons`, so it is the default user icon that also gets selected when you click `Clear Avatar`. REPOSITORY R128 User Manager REVISION DETAIL

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56265. GB_2 added a comment. Remove monochrome icon REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20564?vs=56264&id=56265 BRANCH change-default-user-avatar (branched from master) REVISION DETAIL https://phabric

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56266. GB_2 added a comment. Prevent deprecation warning REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52351&id=56266 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.or

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 added a comment. In D19077#442323 , @mart wrote: > In D19077#422017 , @filipf wrote: > > > @mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r", whic

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56268. GB_2 added a comment. Try to fix diff REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56266&id=56268 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077 AF

D15423: System settings: make date/time format preview consistent

2019-04-15 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg Cc: GB_2, davidedmundson, abetts, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

2019-04-15 Thread Björn Feber
GB_2 added a comment. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, pla

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-04-15 Thread Björn Feber
GB_2 updated this revision to Diff 56312. GB_2 added a comment. Fix initial selection bug and add load indication REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=56222&id=56312 BRANCH improve-the-look-of-the-plymouth-boot-splash-screen-kcm-u

D19077: Redesign the theme preview window

2019-04-15 Thread Björn Feber
GB_2 updated this revision to Diff 56314. GB_2 added a comment. Fix "No Preview" icon REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56310&id=56314 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D190

D19077: Redesign the theme preview window

2019-04-15 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. Now it's great. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty,

D20576: Add new notifications KCM

2019-04-17 Thread Björn Feber
GB_2 added a comment. Hmm, it seems like the Plasma theme `list-remove` is different from the normal Breeze icon theme `list-remove`. I think we should have the icon from the Plasma theme in the Breeze icon theme too, but with a different name, so we don't overwrite the existing one. REPOSI

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-17 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Li

D20576: Add new notifications KCM

2019-04-17 Thread Björn Feber
GB_2 added a comment. In D20576#451805 , @ngraham wrote: > Yeah, I was thinking of the Breeze icon theme one, which IMO looks better: > > F6777816: Screenshot_20190417_074431.png > > I agree that the

<    1   2   3   4   5   6   7   >