D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#448756 , @davidedmundson wrote: > > It currently returns a QIcon, but I want the name/source of it from QML. > > What for? So I can use the same icon that is in the context menu REPOSITORY R119

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. in the toolbutton icon source/name property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#448842 , @davidedmundson wrote: > Toolbutton should be able to take a qicon as a source Nope, when I use `iconSource: plasmoid.action("alternatives").icon` this happens: `ConfigOverlay.qml:392:21:

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. It seems like Elisa has a function to do this: https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083 Maybe something like this could be added to KDE/Plasma Franeworks? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 56312. GB_2 added a comment. Fix initial selection bug and add load indication REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=56222=56312 BRANCH improve-the-look-of-the-plymouth-boot-splash-screen-kcm-ui

D19077: Redesign the theme preview window

GB_2 updated this revision to Diff 56314. GB_2 added a comment. Fix "No Preview" icon REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56310=56314 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077

D19077: Redesign the theme preview window

GB_2 accepted this revision. GB_2 added a comment. Now it's great. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty,

D20612: [RFC] [Kickoff] Modernize settings window layout

GB_2 added a comment. In D20612#451981 , @ngraham wrote: > Use `onPressed` And `Layout.preferredHeight` (still doesn't fix the button height though) Just use `implicitWidth` and `implicitHeight`. REPOSITORY R119 Plasma Desktop

D18546: [Desktop Toolbox] Use "tools" icon

GB_2 added a comment. I think this revision can be abandoned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18546 To: ngraham, #vdg, #plasma Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Port the KCM to the new GriedView KCM design. F6771665: Improved Plymouth Boot Splash Screen KCM

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added a comment. In D20549#466129 , @davidedmundson wrote: > What is "the rest" ? The open inline comments. REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham,

D21430: [Plasma Integration] Switch default UI font to Noto Sans Display

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See T10980 for more info. TEST PLAN Noto Sans Display should

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

GB_2 updated this revision to Diff 58730. GB_2 added a comment. Also update KRDB REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21429?vs=58727=58730 BRANCH switch-default-ui-font-to-noto-sans-display (branched from master) REVISION DETAIL

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 updated this revision to Diff 58720. GB_2 added a comment. Remove workaround and put tooltip into property REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21417?vs=58689=58720 BRANCH

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 updated this revision to Diff 58721. GB_2 added a comment. Remove unneeded parent property REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21417?vs=58720=58721 BRANCH actionlistitem-make-qml-imports-and-tooltip-consistent (branched

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See T10980 for more info. TEST PLAN Noto Sans Display should

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 updated this revision to Diff 58733. GB_2 added a comment. Clean indentation REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21417?vs=58721=58733 BRANCH actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

D21435: [ActionTextField] Make QML tooltip consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY T10873 TEST PLAN Hover over for example the Discover search

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

GB_2 added a comment. In D21429#470715 , @hein wrote: > Why? Read the task mentioned in the description... > See T10980 for more info. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21436: Use onClicked for Home button

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 407636 FIXED-IN: 5.16.0 Buttons should use onClicked instead of onPressed. TEST PLAN

D21417: [ActionListItem] Make QML imports and tooltip consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7b778dbe90fe: [ActionListItem] Make QML imports and tooltip consistent (authored by GB_2). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY T10862 and T10873 TEST

D21507: Remove DefaultListItemBackground animation

GB_2 added a comment. In D21507#472356 , @ngraham wrote: > I would guess that the code is somewhere in https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml Removing all animations there doesn't affect it :(

D21507: Remove DefaultListItemBackground and MenuItem animation

This revision was automatically updated to reflect the committed changes. Closed by commit R858:59d06ca5df04: Remove DefaultListItemBackground and MenuItem animation (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D21507: Remove DefaultListItemBackground and MenuItem animation

GB_2 added a comment. In D21507#472482 , @mart wrote: > no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed Thanks! REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH

D21507: Remove DefaultListItemBackground animation

GB_2 updated this revision to Diff 58947. GB_2 added a comment. Change MenuItem too REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21507?vs=58922=58947 BRANCH remove-defaultlistitembackground-animation (branched from master)

D21507: Remove DefaultListItemBackground and MenuItem animation

GB_2 added a comment. In D21507#472482 , @mart wrote: > no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed Ok, but if the DefaultListItemBackground animation there doesn't get removed there is

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17372 To: ngraham, #plasma, #vdg Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D21507: Remove DefaultListItemBackground animation

GB_2 added a subscriber: mart. GB_2 added a comment. In D21507#472295 , @ngraham wrote: > Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably

D21436: Use onClicked for Home button

This revision was automatically updated to reflect the committed changes. Closed by commit R134:66f3bec02825: Use onClicked for Home button (authored by GB_2). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21436?vs=58739=58791 REVISION

D21435: [ActionTextField] Make QML tooltip consistent

GB_2 added a comment. @mart Can I land this? REPOSITORY R169 Kirigami BRANCH actiontextfield-make-qml-tooltip-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D21435 To: GB_2, #plasma, #vdg, #kirigami, ngraham Cc: ngraham, mart, ognarb, #vdg,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D19829: kicker: add option to make root level icons visible

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f5ad1bfc33a4: kicker: add option to make root level icons visible (authored by i.Dark_Templar, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10362: Change reveal password button logic

GB_2 added a comment. In D10362#202592 , @elvisangelaccio wrote: > Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). > > Would it be possible to implement this feature

D10362: Swap reveal password button logic

GB_2 updated this revision to Diff 59081. GB_2 added a comment. Change reveal password button logic REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=26701=59081 BRANCH change-reveal-password-button-logic (branched from master)

D10362: Swap reveal password button logic

GB_2 added a comment. Changed `onClicked` to `onPressedChanged` REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc:

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 added a comment. In D21417#470381 , @apol wrote: > But BasicListItem already is a Control. > https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html Ok, weird. If I do it without the Control it shows this error:

D21435: [ActionTextField] Make QML tooltip consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5bf8cff95c7: [ActionTextField] Make QML tooltip consistent (authored by GB_2). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21435?vs=58738=58916 REVISION

D21507: Remove DefaultListItemBackground animation

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This makes it consistent with the QWidget style. TEST PLAN Hover over QQC2 combobox items.

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

GB_2 added a comment. In D21414#471285 , @ngraham wrote: > Actually now that I think about it, this should probably go into Plasma 5.16. However since I asked you to add a colon to the end of a string, technically that's a string change and

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. So when this lands I guess we need to remove the font option from the GTK KCM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: GB_2, abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D21134: [Notifications] Tweak paddings

GB_2 added a comment. In D21134#478796 , @alex-l wrote: > Just a mockup but is this middle ground solution good enough? I absolutely love it! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21134 To:

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

GB_2 added a comment. Great! I'd only change the name of these avatars: Boss Konqi -> Banker Konqi Hacker Konqi -> Developer Konqi / Programmer Konqi REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21939 To: ndavis, #vdg, #plasma Cc: GB_2, ngraham,

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

GB_2 added a comment. I think `plasma-sddm.conf` is a better filename. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham, #plasma Cc: GB_2,

D20797: [dict] Modernize configuration window

GB_2 added inline comments. INLINE COMMENTS > ConfigDictionaries.qml:33 > > SystemPalette { > id: syspal This can be removed when you chang the the other color properties. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20797 To: filipf, dfaure,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D20923: Rank Kickoff desktopsessions search results over services

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5f5b21c562a8: Rank Kickoff desktopsessions search results over services (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20923: Rank Kickoff desktopsessions search results over services

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 405268 Users more frequently want to log out rather than change desktop session settings.

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. I would accept it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Provide alternatives, so you can quickly switch between the two widgets. TEST PLAN Switch to an

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 added a comment. In D20878#457623 , @filipf wrote: > Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed: > > F6798674: image.png

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c6a6fe1870e: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout… (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9dcc29663bd7: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57274. GB_2 added a comment. Invert checkbox in UI logic instead, fix font preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20906?vs=57216=57274 BRANCH

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8690a41b02ad: Provide alternatives for Show Desktop and Minimize All Windows widgets (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

GB_2 updated this revision to Diff 57184. GB_2 added a comment. org.kde.plasma.showdesktop -> org.kde.plasma.windowmanagement REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20895?vs=57173=57184 BRANCH

D20902: Add SDDM theme login load feedback

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Currently, when you log in you can see a short freeze which looks bad. This patch adds some feedback

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf7a430da31d: [desktoppackage] Port to QQC2 and fix Get New Widgets... button text (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY - Port to QQC2 - Fix "Get New Widgets..." button text TEST PLAN Try pressing Esc in the widget

D19829: kicker: add option to make root level icons visible

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Works great. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel,

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

GB_2 updated this revision to Diff 57207. GB_2 added a comment. Add QQC2 import name where it was missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20904?vs=57205=57207 BRANCH desktoppackage-port-to-qqc2-and-fix-get-new-widgets-button-text

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout - Improve some strings - Follow the KDE HIG - Improve look of

D20902: Add SDDM theme login load feedback

GB_2 closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20902 To: GB_2, #plasma, #vdg, ngraham Cc: abetts, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D20904: [desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text

GB_2 added a comment. In D20904#458191 , @ngraham wrote: > I would not even change `QQC` and `QtControls` to `QQC2`. That way the diff will be even smaller. Is the diff being smaller more important than making it consistent? REPOSITORY

D20902: Add SDDM theme login load feedback

GB_2 added a comment. In D20902#458128 , @ngraham wrote: > There's no chance that this could glitch out and leave you in a state where it's not logging in but all the controls are disabled, right? I have used an edited theme with this

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57216. GB_2 marked 3 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20906?vs=57211=57216 BRANCH

D20908: RFC: Redesign QML applet configuration windows

GB_2 added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20564: Change default user avatar

GB_2 added a comment. Ping REPOSITORY R128 User Manager BRANCH change-default-user-avatar (branched from master) REVISION DETAIL https://phabricator.kde.org/D20564 To: GB_2, #plasma, #vdg, ngraham, afiestas, broulik Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen,

D20576: Add new notifications KCM

GB_2 added a comment. Here you go: https://phabricator.kde.org/D20700 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout (except for the mimetype table, there is no QQC2 equivalent) -

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57133. GB_2 added a comment. Fix some capitalizations, "Hide Files Matching" -> "Hide matching" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20878?vs=57132=57133 BRANCH

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57144. GB_2 added a comment. Don't set root size to childrenRect size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20878?vs=57133=57144 BRANCH

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

GB_2 updated this revision to Diff 57040. GB_2 added a comment. Move Minimize All too, so there is an alternative REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20818?vs=56973=57040 BRANCH arcpatch-D20818 REVISION DETAIL

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b6d785370d53: Add the Show Desktop applet (moved from kdeplasma-addons) (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

This revision was automatically updated to reflect the committed changes. Closed by commit R114:00cd377ecc57: Remove the Show Desktop applet (its in plasma-desktop now) (authored by GB_2). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D20820: Add Show Desktop applet to default panel

GB_2 updated this revision to Diff 57059. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20820?vs=56976=57059 BRANCH add-showdesktop-applet-to-default-panel (branched from master) REVISION DETAIL

D20820: Add Show Desktop applet to default panel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4d3bfe3c0d31: Add Show Desktop applet to default panel (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20820?vs=57059=57060 REVISION

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added inline comments. INLINE COMMENTS > advanceconfig.ui:226 > + > + > + It would be nice if you added the icon `view-refresh` to this button... > advanceconfig.ui:233 > + > + > + ...and here the icon `document-revert` or `edit-undo`. >

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added inline comments. INLINE COMMENTS > kcm_sddm.actions:301 > +Name=Sync Settings > +Description=Syncs user settings with SDDM settings > +Policy=auth_admin I think the long form of sync would be better in the description: Synchronizes REPOSITORY R123 SDDM Configuration Panel (KCM)

D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf,

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added a comment. In D22191#489838 , @ndavis wrote: > > Settings UI: > > F6953661: Screenshot_20190701_234413.png > > This control layout seems to imply that a user must press the "Sync" button

D10362: Change reveal password button logic

GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio,

D20564: Rename colorful user gallery avatar

GB_2 added a comment. In D20564#453472 , @davidedmundson wrote: > > Ping > > For future, the commit message is important. > > The person reviewing doesn't have the same context you have when you're making the change, if you can save the

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D20564: Rename colorful user gallery avatar

This revision was automatically updated to reflect the committed changes. Closed by commit R128:774c4c628d72: Rename colorful user gallery avatar (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20564?vs=56265=56676#toc REPOSITORY R128 User Manager CHANGES SINCE

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

GB_2 added a comment. Looks good UI-wise. INLINE COMMENTS > configGeneral.qml:136 > +} > +QtControls.RadioButton { > +id: noTextRadio Default radio buttons should be at the top. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20796 To:

D19011: Thunderbolt KCM and KDED module

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner,

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Should we really wait until those are merged and not have the new layout in Plasma 5.16? Merging these will take quite some time and I don't see how it would make a difference layout-wise. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#446564 , @davidedmundson wrote: > From my last comment > > >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > > > > > This is by /far/ the

D20817: [kdeplasma-addons] Move the Show Desktop applet

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Move the Show Desktop applet from `kdeplasma-addons` to `plasma-desktop`, so it can be added to the

D20818: [plasma-desktop] Move the Show Desktop applet

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Move the Show Desktop applet from `kdeplasma-addons` to `plasma-desktop`, so it can be added to the

D20820: Add Show Desktop applet to default panel

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY T7917 TEST PLAN The default panel should now have a Show

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/`arc` in the future: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Perfect. REPOSITORY R119 Plasma Desktop BRANCH modernize-pager-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D20796 To: ngraham,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, jguidon, hannahk,

D20576: Add new notifications KCM

GB_2 added a comment. In D20576#451805 , @ngraham wrote: > Yeah, I was thinking of the Breeze icon theme one, which IMO looks better: > > F6777816: Screenshot_20190417_074431.png > > I agree that

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 56435. GB_2 added a comment. Move `currentApplet.applet.prepareContextualActions();` to `onVisualParentChanged` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55960=56435 BRANCH arcpatch-D17410

<    1   2   3   4   5   6   7   >