D17410: Add alternatives button to applet configuration in panel edit mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c308122688ee: Add alternatives button to applet configuration in panel edit mode (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20576: Add new notifications KCM

GB_2 added a comment. Hmm, it seems like the Plasma theme `list-remove` is different from the normal Breeze icon theme `list-remove`. I think we should have the icon from the Plasma theme in the Breeze icon theme too, but with a different name, so we don't overwrite the existing one.

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 56446. GB_2 marked 8 inline comments as done. GB_2 added a comment. Address some comments REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=56312=56446 BRANCH

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added a comment. @broulik Do you want to commandeer this revision and do the rest? REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:211 > This isn't a signal, also why do you need to reload when saving? It's not > like any themes could magically appear here? It resets it if you cancel the action, so the apply button is enabled again and the selection

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

GB_2 added inline comments. INLINE COMMENTS > configAppearance.qml:130 > +RowLayout { > +Kirigami.FormData.label: i18n("Colored numbers on tiles:") > You could make it like this: `Tiles: [ ] Colored numbers: [ Button ]` REPOSITORY R114 Plasma Addons REVISION DETAIL

D20576: Add new notifications KCM

GB_2 added a comment. You can now use `edit-remove`, which got added in D20700 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel,

D20743: [Kicker] Modernize settings window

GB_2 accepted this revision. GB_2 added a comment. Looks good INLINE COMMENTS > ConfigGeneral.qml:194 > > -text: recentOrdering.currentIndex == 0 > -? i18n("Show recent documents") > -: i18n("Show often used

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

GB_2 added a comment. Does that mean I can land it? REPOSITORY R119 Plasma Desktop BRANCH move-showdesktop-applet (branched from master) REVISION DETAIL https://phabricator.kde.org/D20818 To: GB_2, #plasma, #vdg, ngraham, apol Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma,

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

GB_2 updated this revision to Diff 57039. GB_2 added a comment. Move Minimize All too, so there is an alternative REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20817?vs=56972=57039 BRANCH move-showdesktop-applet (branched from master) REVISION

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 60944. GB_2 marked 2 inline comments as done. GB_2 added a comment. - Split model reloading from the `load()` function - Emit `selectedPluginIndexChanged();` after reloading the model REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:88 > Ideally here we would reload the model and then set the newly installed theme > as current I think it should not select the newest installed theme instead of still having the current one selected, because in the "Get

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

GB_2 abandoned this revision. GB_2 added a comment. Oh, didn't know that existed, it wasn't mentioned anywhere in the bug report. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23127 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma,

D23127: [plasma-desktop] Add desktop context menu entry for Displays KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 355679 F7237121: Displays KCM Desktop Context Menu Entry.png

D23128: [plasma-workspace] Add desktop context menu entry for Displays KCM

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7237121: Displays KCM Desktop Context Menu Entry.png TEST

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added a comment. I think we should definitely add this shortcut, because it is very useful for the people mentioned and for other situations. I agree that it should be on by default, then it's already there when you need it. In D14830#472177

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in menu.cpp:117 > I'd change it to "Manage Displays..." to make the differentiate the name even > more from the "Configure Desktop..." menu entry. *to differentiate REPOSITORY R120 Plasma Workspace REVISION DETAIL

D14830: Add "Configure Displays" context menu entry on the desktop

GB_2 added inline comments. INLINE COMMENTS > menu.cpp:117 > > +m_displaySettingsAction = new > QAction(i18nc("plasma_containmentactions_contextmenu", "Configure > Displays..."), this); > + >

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 updated this revision to Diff 63611. GB_2 added a comment. Use a QMenu REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63460=63611 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. In D19822#442630 , @filipf wrote: > Just throwing out another possible solution: the PlasmaComponents Highlight thingy: > > F6747233: Screenshot_20190403_005556.png > >

D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. In D21815#490482 , @filipf wrote: > If keeping the new menu style we have to wait until all those patches get merged in Plasma. > > Might be better to just follow current style; updating it to the new one would be a

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. That is good enough IMO, but if anyone knows how to fix this, then please do :-) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. In D22896#505835 , @ngraham wrote: > Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button. It does that. Making it close when clicking anywhere

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7141216: System Settings Sidebar QQC2 Port.png Only issue

D22880: Rename "Plasma Theme" to "Plasma Style"

GB_2 added inline comments. INLINE COMMENTS > kcm_desktoptheme.desktop:41 > Name[zh_TW]=Plasma 主題 > Comment=Choose Plasma theme > Comment[ca]=Trieu el tema del Plasma You forgot to change the name here too. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22911: Improve the look of the Lock Screen KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG and make the desktop file consistent. F7150699: Improved Lock Screen KCM UI.png

D22911: Improve the look of the Lock Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm.ui:49 > Capitalize Automatically Ok, I just followed the style from D21610 , if it's wrong then it needs to be corrected ther too. > ngraham wrote in kcm.ui:78 > While we're at it, I might

D22911: Improve the look of the Lock Screen KCM UI

GB_2 updated this revision to Diff 63078. GB_2 added a comment. Address comments REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63030=63078 BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63872. GB_2 added a comment. Address comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63827=63872 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63968. GB_2 added a comment. Add tooltip to menu button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63872=63968 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. @mart is this good now? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol,

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 368430 Being able to disable grouping for the icons-only taskmanager makes sense, because it

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. In D23242#514239 , @hein wrote: > Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63800. GB_2 added a comment. "Only for specific applications" -> "Only for specific applications:" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63793=63800 BRANCH improved-activities-kcm-ui (branched

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63799. GB_2 added a comment. Bind checked property directly REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63614=63799 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63793. GB_2 added a comment. Remove unneeded import REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63792=63793 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and make the KCM show up in

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63817. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63800=63817 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63818. GB_2 added a comment. Fix "blocked" emblem icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63817=63818 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63827. GB_2 added a comment. Use standard shortcut for "Configure System Settings..." action REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63799=63827 BRANCH arcpatch-D22896 REVISION DETAIL

D17598: Improve "No internet connection!" error message

GB_2 added inline comments. INLINE COMMENTS > BrowsingPage.qml:73 > +horizontalAlignment: Text.AlignHCenter > +text: xi18nc("@info", "Unable to load > applicationsplease verify Internet connectivity") > +} I'd put a dot after "applications" and

D22885: Add global animation speed slider to workspace options KCM

GB_2 added a comment. In D22885#505635 , @broulik wrote: > Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means *faster* instead of "half the speed" as reading that line would suggest. > However, KWin seems to do it the

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63458. GB_2 added a comment. Add a "Show Most Used Page" button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63404=63458 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 added a comment. In D22896#509989 , @ngraham wrote: > Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes. Yeah, we that feature is also not

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 updated this revision to Diff 63460. GB_2 added a comment. "Configure" -> "Configure..." REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63458=63460 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

GB_2 added a subscriber: mart. GB_2 added a comment. Ping @mart, can you please help here? REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2,

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63614. GB_2 marked 7 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63611=63614 BRANCH arcpatch-D22896 REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63653. GB_2 added a comment. Ditch the extra property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63444=63653 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES

D23097: Add icon to the taskmanager grouping menu entry

GB_2 added a comment. I think the icon `view-group` fits better. INLINE COMMENTS > ContextMenu.qml:577 > text: i18n("Allow this program to be grouped") > - > +icon: "object-group" > onClicked: tasksModel.requestToggleGrouping(menu.modelIndex)

D23097: [Task Manager] Add icon to the grouping menu entry

GB_2 updated this revision to Diff 63585. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63584=63585 BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23097: [Task Manager] Add icon to the grouping menu entry

GB_2 updated this revision to Diff 63584. GB_2 added a comment. Fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23097?vs=63580=63584 BRANCH arcpatch-D23097 REVISION DETAIL https://phabricator.kde.org/D23097 AFFECTED FILES

D23097: [Task Manager] Add icon to the grouping menu entry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6bf630cce15a: [Task Manager] Add icon to the grouping menu entry (authored by simonkr, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23097: [Task Manager] Add icon to the grouping menu entry

GB_2 added a comment. Don't forget the inline comment ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23097 To: simonkr, #plasma, #vdg, hein Cc: GB_2, #vdg, plasma-devel, #plasma, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a subscriber: mart. GB_2 added a comment. @mart can you help here? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 405956 F7262289: System Settings Sidebar Show Intro Page Button.png

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 64057. GB_2 added a comment. Move `setActionMenuVisible` to the `Private` class REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63968=64057 BRANCH arcpatch-D22896 REVISION DETAIL

D22896: Port System Settings sidebar to QQC2

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R124:b42479962795: Port System Settings sidebar to QQC2 (authored by GB_2). REPOSITORY R124 System Settings CHANGES

D21524: Keep existing configurations' strings               

GB_2 added a comment. Ping. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari, apol, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23285: Prevent dragging QQC2 ComboBox contents outside menu

GB_2 created this revision. GB_2 added reviewers: Plasma, Frameworks, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY You should not be able to drag the items outside the menu, it looks weird. This fixes it.

D23285: Prevent dragging QQC2 ComboBox contents outside menu

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents outside menu (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. In D23049#511210 , @ngraham wrote: > Hmm, if software making use of this needs to manually add a label, that seems to defeat part of the point of using a standard component. The label in the example was just

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 63662. GB_2 added a comment. Improve example REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63653=63662 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. Visually +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2 Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma, filipf, ngraham Cc: GB_2, Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel,

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

GB_2 added a comment. I just tried it on Wayland and it looks like for some reason instead of a number it shows some kind of UUID. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n,

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

GB_2 added inline comments. INLINE COMMENTS > account.ui:227 > > - > - > - > - 0 > - 0 > - > - > + > Add the icon `document-edit` REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbd0465c3b1c: Improve the look of the Activities KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63818=64686 REVISION

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. Ping. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart,

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. Ping @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 marked 2 inline comments as done. GB_2 added a comment. This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png REPOSITORY R124 System Settings REVISION DETAIL

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#520127 , @mart wrote: > SidebarMode::setActiveCategory may need to be modified to make it like it tough Looks like it. INLINE COMMENTS > SidebarMode.cpp:498 > +if (introPageVisible) { > +

D23389: Use "Make default" buttons to switch the default device

GB_2 added inline comments. INLINE COMMENTS > ListItemBase.qml:230 > +PlasmaComponents.Button { > +text: PulseObject.default ? i18n("Default device") : > i18n("Make Default") > +iconName: PulseObject.default ? "favorite" : ""

D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. In D23174#519704 , @ngraham wrote: > Hooray! > > Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons? Unfortunately, I don't know the code base

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 64217. GB_2 added a comment. Improve look REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63662=64217 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES Mainpage.dox

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 64682. GB_2 added a comment. Use a bool property setter and disable button when on intro page REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64071=64682 BRANCH

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Makes sense to me UI- and behavior-wise. INLINE COMMENTS > LockScreenUi.qml:443 > +font.pointSize: theme.defaultFont.pointSize + 1 > +

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

GB_2 added a comment. Ping. REPOSITORY R124 System Settings BRANCH use-new-kirigami-section-header (branched from master) REVISION DETAIL https://phabricator.kde.org/D23052 To: ngraham, #plasma, #vdg, GB_2 Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 65509. GB_2 added a comment. Use Plasma highlight effect REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=55003=65509 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED

D23910: startplasma: Respect KDEWM again

GB_2 added a comment. BTW, I wonder if we can rename it to `PLASMAWM` in Plasma 6/the future. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23910 To: heikobecker, #plasma, apol, davidedmundson Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > OutputPanel.qml:33 > +text: i18n("Settings for %1", element.display) > +visible: kcm.numberOfOutputs > 1 > +} `element.count > 1` > OutputPanel.qml:42 > onClicked: element.enabled = checked > + visible:

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D23389: Use "Make default" buttons to switch the default device

GB_2 added a comment. In D23389#525358 , @ngraham wrote: > See the new `FIXME`: I can't figure out how to get the non-default device's button to become unchecked. It seems like the binding is broken. The non-default button disables itself

D23389: Use "Make default" buttons to switch the default device

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:231 > I tried that, but it looked sort of weird. I kind of like how the presence of > the icon helps to show what's the default device. Maybe you can also use `star-shape` REPOSITORY R115 Plasma Audio Volume

D23798: Polish Displays KCM UI

GB_2 added a comment. In D23798#528804 , @ngraham wrote: > Did you test the patch with those suggestions? They don't work. Oh, sorry then. I didn't actually have two screens to test this. It just looked like it worked for one.

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

GB_2 added a comment. In D23283#526239 , @ngraham wrote: > Thanks for the review, @gb_2. Have you tested it out? I did a lot of testing, but even more testing would be appreciated since I know this has the potential to introduce some

D23984: [System Settings] redesign intro page

GB_2 added a comment. As you can see in my design, I'd not add a rectangle in the backround, it looks weird to me and less clean than before. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23984: [System Settings] redesign intro page

GB_2 added a comment. What about a design like this? F7363944: System Settings Intro Page Mockup.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23984: [System Settings] redesign intro page

GB_2 added inline comments. INLINE COMMENTS > introPage.qml:92 > wrapMode: Text.NoWrap > text: i18n("Frequently used:") > } Maybe change to "Frequently Used", so it's a header? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added inline comments. INLINE COMMENTS > Tools.qml:108 > +QQC2.Label { > +text: i18n("Colorscheme:") > } "Color scheme" REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26,

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See M144 and T10047 . This

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added inline comments. INLINE COMMENTS > Preview.qml:82 > > -Item { height: units.gridUnit / 2 } > - > -PlasmaExtras.Heading { > -level: 3 > -elide: Text.ElideRight > +Kirigami.Heading { > +level: 1 Maybe add `wrapMode:

D23952: Remove panel toolbox and clean up editing options

GB_2 added a comment. In D23952#532034 , @ngraham wrote: > Hmm, after applying and compiling all three patches and then restarting plasmashell, I still see the panel toolbox. That's because you still have the files and manually compiling

D23952: Remove panel toolbox clean up editing options

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY With D23951 we greatly improve the discoverability of the panel

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

GB_2 updated this revision to Diff 66102. GB_2 added a comment. Don't hide "Lock Widgets" for panels REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23950?vs=66094=66102 BRANCH

D23798: Polish Displays KCM UI

GB_2 added a comment. I have a suggestion for the "save output properties" option. INLINE COMMENTS > Panel.qml:90 > > Kirigami.FormData.label: i18n("Save values of an output:") > Kirigami.FormData.buddyFor: globalRetentionRadio "Save output properties:" >

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:123 > And I could use some help with the issue detailed in the comment here. You don't need any of that. Just do `kcm.outputModel.count > 1`. BTW, I'd also use a different minimum height if this component is hidden.

D23803: [Folder View] Add subtle shadows to icons

GB_2 added a comment. In D23803#528128 , @cfeck wrote: > Isn't Qt Quick amazing? Indeed! REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL

D23776: Add icon to "Move to Desktop" task manager context menu item

GB_2 updated this revision to Diff 65590. GB_2 added a comment. Also fix "Move to Activity" capitalization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23776?vs=65587=65590 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23776

<    1   2   3   4   5   6   7   >