D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65540. GB_2 added a comment. This revision is now accepted and ready to land. Change `onPressedChanged` back to `onClicked` and only show the button when there is text inside the TextField, like in the PolKit dialog REPOSITORY R242 Plasma Framework

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

2019-09-07 Thread Björn Feber
GB_2 added a comment. In D23776#527312 , @ngraham wrote: > Any reason not to add an icon for Move to Activity as well? Forgot that, will do. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23776 To:

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65595. GB_2 added a comment. Also add icon for "Move to Activity" item REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23776?vs=65590=65595 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23776

D23776: Add icon to "Move to Desktop/Activity" task manager context menu item and fix capitalizations

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ffee9c4097a3: Add icon to Move to Desktop/Activity task manager context menu item and fix… (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65541. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65540=65541 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILES

D22168: [plasma-desktop] Use new activities icon

2019-09-06 Thread Björn Feber
GB_2 updated this revision to Diff 65531. GB_2 added a comment. Rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22168?vs=60866=65531 BRANCH arcpatch-D22168 REVISION DETAIL https://phabricator.kde.org/D22168 AFFECTED FILES

D22167: [plasma-workspace] Use new activities icon

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9ad1b5502e1a: [plasma-workspace] Use new activities icon (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22167?vs=60865=65533 REVISION

D22168: [plasma-desktop] Use new activities icon

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:267b9134c8b1: [plasma-desktop] Use new activities icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22168?vs=65531=65534 REVISION

D22169: [plasma-active-window-control] Use new activities icon

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R884:c29390fab0c4: [plasma-active-window-control] Use new activities icon (authored by GB_2). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D22170: [latte-dock] Use new activities icon

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R878:c264a0a9e3fe: [latte-dock] Use new activities icon (authored by GB_2). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22170?vs=60869=65536 REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-07 Thread Björn Feber
GB_2 added a comment. In D23712#526883 , @cblack wrote: > I preferred the sidebar as well, but a sidebar with the necessary width to fit the label + the largest icon name in Breeze without layout issues would be obscenely large, and would take

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65551. GB_2 added a comment. Use `length` property and stop revealing password if field is empty REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65541=65551 BRANCH arcpatch-D10362 REVISION

D23799: Get rid of khtml usage (kill classic mode)

2019-09-09 Thread Björn Feber
GB_2 added a comment. +1, let's also focus on fixing bugs for the other two views. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel Cc: GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D10362: Change reveal password button logic

2019-09-09 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb18347e4dea: Change reveal password button logic (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65592=65681

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-09-09 Thread Björn Feber
GB_2 updated this revision to Diff 65691. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65509=65691 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES

D23798: Polish KCM UI

2019-09-09 Thread Björn Feber
GB_2 added a comment. +1 INLINE COMMENTS > Screen.qml:65 > onClicked: kcm.identifyOutputs() > text: i18n("Identify") > focusPolicy: Qt.NoFocus Icon: "documentinfo" > Screen.qml:71 > onClicked: resetTotalSize() > text:

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

2019-09-09 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6fbfc3ded129: Add icons to Kicker/Kickoff context menu items and correct capitalizations (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65585. GB_2 added a comment. Fix normal text fields REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65551=65585 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362

D23798: Polish Displays KCM UI

2019-09-17 Thread Björn Feber
GB_2 added a comment. In D23798#533361 , @ngraham wrote: > Thanks! Needs final approval from @romangg or someone else from #KWin before landing. Of course. REPOSITORY R104 KScreen BRANCH

D23798: Polish Displays KCM UI

2019-09-17 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in Panel.qml:90 > "Output" is a bit too technical I think, and"Monitor" doesn't cover the case > of projectors. Personally I like "Display" but I'm open to being convinced > otherwise. +1 for display REPOSITORY R104 KScreen

D24033: Add Meta+Space as a default shortcut to activate KRunner

2019-09-17 Thread Björn Feber
GB_2 added a comment. In D24033#533505 , @romangg wrote: > I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications. > >

D23798: Polish Displays KCM UI

2019-09-17 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. UI LGTM! REPOSITORY R104 KScreen BRANCH clean-up-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin, GB_2 Cc: filipf,

D23952: Remove panel toolbox and clean up editing options

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66159. GB_2 added a comment. - Add back "Show Alternatives..." item and remove reference to panel toolbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23952?vs=66105=66159 BRANCH arcpatch-D23952 REVISION

D23785: Rename activities context menu item in taska manager to "Show in Activities"

2019-09-08 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Sync with change in D23779 . TEST PLAN Open the context menu

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

2019-09-08 Thread Björn Feber
GB_2 planned changes to this revision. GB_2 added a comment. I'll try to work more on this in the future. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n,

D23785: Rename activities context menu item in task manager to "Show in Activities"

2019-09-08 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b411c132d77b: Rename activities context menu item in task manager to Show in Activities (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

2019-09-08 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7331506: Kicker⁄Kickoff Context Menu Items Icons and Correct Capitalizations.png

D23794: HiDPI icon pixmap

2019-09-08 Thread Björn Feber
GB_2 added a comment. Please add subscribers and reviewers next time. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23794 To: guoyunhe, #plasma Cc: GB_2, #plasma, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel,

D23776: Add icon to "Move to Desktop" task manager context menu item

2019-09-07 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7327853: Move to Desktop Task Manager Context Menu Item Icon.png

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65592. GB_2 added a comment. Don't hide button if revealing password, like in the PolKit dialog and simplify code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65585=65592 BRANCH

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

2019-07-28 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > KNSBackend.cpp:214 > }; > -auto actualCategory = new Category(m_displayName, > QStringLiteral("plasma"), filters, backendName, categories, QUrl(), true); > +const auto iconName = knsrcPlasma.contains(fileName)? >

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

2019-08-05 Thread Björn Feber
GB_2 added a comment. In D21978#497409 , @filipf wrote: > Ping, I'm still seeing the issue with the other patch landed. Me too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-08-05 Thread Björn Feber
GB_2 added a comment. The `icons` folder can be deleted since it's not used anymore I think. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf,

D22940: Add a label to the lockscreen config's "Show media controls" checkbox and make the QML imports consistent

2019-08-05 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7164807 TEST PLAN Open the Appearance tab of the Screen

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-08 Thread Björn Feber
GB_2 updated this revision to Diff 63338. GB_2 added a comment. Rebase on master REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63180=63338 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

2019-07-31 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > main.qml:118 > +RowLayout { > Kirigami.FormData.label: i18n("Night Color temperature:") > enabled: activator.checked Lowercase c? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

2019-07-31 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Don't use a minus, because there is no plus next to it. F7127189: Kickoff Remove from Favorites Icon.png

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 updated this revision to Diff 62933. GB_2 added a comment. Drop word "the" in descriptions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62930=62933 BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from

D22871: Use better Global Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 added a comment. In D22871#505311 , @ngraham wrote: > Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even just, "General"? It's already in a section with the word "Behavior" in it, after all. I'll name it

D22871: Use better Global Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 updated this revision to Diff 62930. GB_2 added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Use name "General Behavior" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62892=62930

D22879: Rename "Look and Feel" KCM to "Global Theme"

2019-08-01 Thread Björn Feber
GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. We should probably also change the name in the KDE Store and Look and Feel Explorer. INLINE COMMENTS > metadata.desktop:2 > [Desktop Entry] > -Comment=Test Look and Feel

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Björn Feber
GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. The KDE Store category name should probably be updated too. REPOSITORY R119 Plasma Desktop BRANCH plasma-theme-to-plasma-style (branched from master) REVISION DETAIL

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 added a comment. In D22871#505360 , @ngraham wrote: > If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22880: Rename "Plasma Theme" to "Plasma Style"

2019-08-01 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in plasma-themes.knsrc:42 > > The KDE Store category name should probably be updated too. > > You mean here? What does this actually do? I mean in the actual store online :-) REPOSITORY R119 Plasma Desktop BRANCH

D22871: Use better Global Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Consistently call the KCM "Global Workspace Behavior" and use `preferences-desktop` as the icon

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

2019-08-01 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > zzag wrote in main.qml:118 > but it depends on how you look at it. "Night color temperature" might be a > better string. As it speaks about color temperature and not temperature of > "Night Color." Agreed. REPOSITORY R119 Plasma Desktop BRANCH

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

2019-08-01 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY "Desktop" to users means the desktop folder, so use a more appropriate name for this category. TEST

D21860: Set a font for gtk applications in the fonts kcm

2019-08-01 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

2019-08-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d90e82ef7c19: [Kicker/Kickoff] Use better Remove from Favorites icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22861?vs=62869=62888

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-07-28 Thread Björn Feber
GB_2 added a comment. Ping @broulik I think we should finally land this and make more changes later in case there are still any issues left. REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: davidedmundson,

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

2019-08-05 Thread Björn Feber
GB_2 updated this revision to Diff 63117. GB_2 added a comment. Put checkbox id property above text property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22940?vs=63099=63117 BRANCH

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

2019-08-05 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b4ccffec69ec: Add label to the lockscreen configs Show media controls checkbox and make… (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22953: Make the System Settings category headers look consistent with other Kirigami lists

2019-08-05 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7167951: Consistent System Settings Category Headers.png

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

2019-08-05 Thread Björn Feber
GB_2 updated this revision to Diff 63125. GB_2 added a comment. Add translation context REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22940?vs=63117=63125 BRANCH

D22953: Make the System Settings category headers look consistent with other Kirigami lists

2019-08-05 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:1fff71c11e63: Make the System Settings category headers look consistent with other Kirigami… (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

2019-08-06 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7172863: Consistent Notifications KCM Category Headers.png

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

2019-08-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:91ec99d32e90: Make the Notifications KCM category headers look consistent with other Kirigami… (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

2019-08-06 Thread Björn Feber
GB_2 added a comment. In D22977#507716 , @ngraham wrote: > Once all is said and done we should really make an actual Kirigami component that has these visual settings by default so we don't need to adjust it in 10 places if we ever decide to

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63403. GB_2 added a comment. Use Qt Labs Platform menu (need to wait until https://bugreports.qt.io/browse/QTBUG-77404 is fixed) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63338=63403 BRANCH

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63404. GB_2 added a comment. Rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63403=63404 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master)

D22879: Rename "Look and Feel" KCM to "Global Theme"

2019-08-09 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > metadata.desktop:2 > [Desktop Entry] > -Comment=Test Look and Feel package > +Comment=Test Global Theme package > Comment[ast]=Paquete d'aspeutu y sentir de prueba Lowercase "global theme". REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63429. GB_2 added a comment. Use correct background color REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63428=63429 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

2019-08-09 Thread Björn Feber
GB_2 added a comment. In D23049#509339 , @ognarb wrote: > Something is probably wrong with the version numbers. Yeah, I don't know which I should choose and why, I just copied it from the other list items. REPOSITORY R169 Kirigami

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63425. GB_2 added a comment. Remove duplicate AbstractListItem REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63424=63425 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ListSection.qml:28 > coherent -> consistent I just copied it from the other list items :-) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg Cc: ngraham, #vdg, plasma-devel,

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63430. GB_2 added a comment. Rename to ListSectionHeader REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63429=63430 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds a standard ListSection component to make ListView sections look consistent. F7181620:

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63426. GB_2 added a comment. Update copyright REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63425=63426 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 added a comment. In D23049#509301 , @ngraham wrote: > Maybe call it a `ListSectionHeader` or just `SectionHeader`? I think just the word section is more accurate, because that's what the property that it will be used in is called

D23049: Add Kirigami ListSection component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63428. GB_2 added a comment. Set `sectionDelegate` to `true` REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63426=63428 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63432. GB_2 added a comment. Use Kirigami 2.10 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63430=63432 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

2019-08-09 Thread Björn Feber
GB_2 added a comment. In D23049#509439 , @ngraham wrote: > Idea: add a `RowLayout` inside the `contentItem` and put the `Heading` in there, then expose a property called like "CustomItems" that allows the implementation to add additional items

D23049: Add Kirigami ListSectionHeader component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63442. GB_2 added a comment. Add `customItems` list REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63432=63442 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63443. GB_2 added a comment. Update `customItems` description REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63442=63443 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D23049: Add Kirigami ListSectionHeader component

2019-08-09 Thread Björn Feber
GB_2 updated this revision to Diff 63444. GB_2 added a comment. Add example code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63443=63444 BRANCH add-listsection-component (branched from master) REVISION DETAIL

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-08-01 Thread Björn Feber
GB_2 updated this revision to Diff 62899. GB_2 added a comment. Clean up debug messages REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=62050=62899 BRANCH arcpatch-D20549 REVISION DETAIL https://phabricator.kde.org/D20549 AFFECTED FILES

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-08-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R258:894f6706afef: Improve the look of the Plymouth Boot Splash Screen KCM UI (authored by GB_2). REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

2019-08-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:c9f7aaa0765c: Rename Desktop Behavior category to Workspace Behavior (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Björn Feber
GB_2 updated this revision to Diff 63079. GB_2 added a comment. Correct ki18ncp comment REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63078=63079 BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL

D22911: Improve the look of the Lock Screen KCM UI

2019-08-04 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R133:bf5040930785: Improve the look of the Lock Screen KCM UI (authored by GB_2). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63079=63083 REVISION

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-06 Thread Björn Feber
GB_2 updated this revision to Diff 63180. GB_2 added a comment. Close menu when clicking anywhere in the window. Most likely not the best solution. REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=62976=63180 BRANCH

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-08 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > broulik wrote in SidebarMode.cpp:570 > Not a huge fan of this. > Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and > `ComboBox` popup? Not really, seems like the KQuickStyleItem only has access to the QML window of the

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-07-18 Thread Björn Feber
GB_2 updated this revision to Diff 61991. GB_2 added a comment. - use more bindings - set `sourceSize` on the thumbnail REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=60944=61991 BRANCH arcpatch-D20549 REVISION DETAIL

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-07-19 Thread Björn Feber
GB_2 updated this revision to Diff 62043. GB_2 added a comment. Move progress bar above GHNS button REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=61991=62043 BRANCH arcpatch-D20549 REVISION DETAIL https://phabricator.kde.org/D20549

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-07-19 Thread Björn Feber
GB_2 updated this revision to Diff 62050. GB_2 added a comment. Make sure Apply button gets enabled when selecting a theme for the first time REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=62043=62050 BRANCH arcpatch-D20549 REVISION

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-21 Thread Björn Feber
GB_2 updated this revision to Diff 66577. GB_2 added a comment. Fix more REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24129?vs=66576=66577 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 AFFECTED FILES

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-21 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7401179: Fixed Display Configuration KCM Clipping.png The

D13881: oxygen-demo : add KMessage preview

2019-09-28 Thread Björn Feber
GB_2 added a comment. Looks fine IMO. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D13881 To: rjvbb, #vdg, plasma-devel Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D10263: Fix being unable to close the toolbox menu by clicking outside

2019-09-28 Thread Björn Feber
GB_2 added a comment. Can be abandoned because of D24265 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D20972: [sidebar] Make search field not glued to the separator

2019-09-28 Thread Björn Feber
GB_2 requested changes to this revision. GB_2 added a comment. This revision now requires changes to proceed. In D20972#517463 , @filipf wrote: > D23274 makes this unnecessary. It landed. REPOSITORY

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2019-09-28 Thread Björn Feber
GB_2 added a comment. Is there a reason this isn't landed yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: GB_2, elcste, shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, LeGast00n,

D23274: Add "Show intro page" button to System Settings sidebar

2019-09-28 Thread Björn Feber
GB_2 added a comment. This can be closed. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham, mart Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24264: edit mode action and dbus

2019-10-01 Thread Björn Feber
GB_2 added a comment. Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24264 To: mart, #plasma Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n,

D24246: Only show panel toolbox when desktop toolbox is open

2019-09-26 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This way the panel toolbox isn't always visible, because with D23951

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-26 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 To: GB_2, #plasma, #vdg, ngraham Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24161: Make KCM look more like applet

2019-09-27 Thread Björn Feber
GB_2 added a comment. I'd also align the mute button with the slider, like in the applet. INLINE COMMENTS > DeviceListItem.qml:89 > +Button { > +text: i18n("Default device") > +icon.name: "favorite" "Default Device" REPOSITORY R115

D24265: support global edit mode

2019-09-27 Thread Björn Feber
GB_2 added a comment. Nice! I guess D23951 is still relevant? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D24246: Only show panel toolbox when desktop toolbox is open

2019-09-26 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9533e674adc: Only show panel toolbox when desktop toolbox is open (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24246?vs=66906=66911

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-09-27 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson, filipf Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

<    1   2   3   4   5   6   7   >