D15429: Simplify cmake code: link to Qt5::GuiPrivate.

dfaure added a comment. I completely forgot about pushing it, thanks for the reminder and for the target branch information. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D15429 To: dfaure, kfunk, kossebau, br

Quiet Mode signal

x27;m not subscribed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure added a comment. No, the commit in 2006 wasn't buggy. There was special logic in KCmdLineArgs for the case of the "no" prefix (note how it said "ninteractive", the "no" was toggling the value). This is a porting error when going from KCmdLineArgs to QCommandLineParser. So it's "only

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure added a comment. Good find. However for users who didn't want a progress dialog, and who never got a conflict (e.g. if they were copying into an empty dir), kioclient was non-interactive, so I think our previous reasoning still holds. REPOSITORY R126 KDE CLI Utilities REVISION DETA

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure added a comment. Looks good except for the TODO comment. I think the comment that is actually needed is one about why we have a "noninteractive" option and it has no effect whatsoever ;) INLINE COMMENTS > kioclient.cpp:278 > +// interactive used to be the default, but due to

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I'm not sure anymore what the best default is. There are two different use cases, that's all. REPOSITORY R126 KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. Please add a KIO version ifdef to avoid breaking compilation with older versions of KIO. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham, kde-f

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure added a comment. OK, here's a bit of historical information, and then my opinion. The idea of that option was that when you click on a (e.g. HTTP) link to a PDF (e.g. in an email), the best application to view that PDF is Okular. Similarly, if it's an image, the best application

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. #include #if KIO_VERSION >= QT_VERSION_CHECK(5,55,0) ... #endif REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham, kde-framewo

D19588: [Notifications] Improve finished notification

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > anthonyfieroni wrote in Jobs.qml:117-120 > displayDestUrl = destUrl.replace(/^(file:\/{2})/, "") All of this is wrong. Removing file:/// leaves something th

D24810: Ensure defintion of XDG_DATA_DIRS

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Bug in the commit log: s/ also make XDG_DATA_DIRS/ also make XDG_CONFIG_DIRS/ INLINE COMMENTS > startplasma.cpp:195 > } > + // Additionally also set default value for XDG_C

D24810: Ensure defintion of XDG_DATA_DIRS

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please make sure the first line of the commit log says CONFIG and not DATA, too (the phab title still says DATA). INLINE COMMENTS > startplasma.cpp:197 > +if (!qEnvironmentVa

D13360: Touchpad KDED module: Convert to JSON metadata

dfaure added a comment. I didn't fully follow this saga, but AFAICS this patch was reverted (commit 3432c3342b1f801 , bug 395622), so we still rely on desktop files to load the touchpad kded module. Can this patch be

D24996: Create directory when saving the menu file

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for the fix! REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D24996 To: wbauer, dfaure Cc: dfaure, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

dfaure created this revision. dfaure added reviewers: kossebau, jriddell, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY I build kwindowsystem with -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.62.0, an

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

dfaure closed this revision. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25488 To: dfaure, kossebau, jriddell, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

dfaure added a comment. Thanks for the idea, done in https://commits.kde.org/kwayland-integration/3ce73d56ca5364242be3eb7cb1b5c4f5eaf47196 REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25488 To: dfaure, kossebau, jriddell, davi

D24238: Port the pager applet away from QtWidgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:674dd5f7e090: Port the pager applet away from QtWidgets (authored by dfaure). REPOSITORY R119 Plasma Desktop CHANGE

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Oh I see. Is there a non-deprecated method to get the overall geometry of all screens combined, or do we need to iterate over the list of screens? Surprising that this doesn't seem to be anywhere in the API !? REPOSITORY R119 Plasma Desktop REVISION DETA

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Further research leads to this possible patch http://www.davidfaure.fr/2019/windowmodel.cpp.diff REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: dfaure, hein, apol Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-De

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Fix pushed https://commits.kde.org/plasma-desktop/2b5e86323f180f0c51ef9af898a69a522bc379ad after the bug reporter confirmed it fixes the bug. Reopening this after it was committed is a bit weird. I can't close it, please do. REPOSITORY R119 Plasma Desktop REV

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Ah, right. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: davidedmundson, hein, apol, dfaure Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, al

Re: 2 kirigami fixes for a point release

That's an easy thing to enforce, and we know it makes a huge difference to > code. > > Even if no-one comments, the extra delay of it running on your own > system delivers a lot. I fully agree. (CC'ing the developer lists) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: 2 kirigami fixes for a point release

r the latter I guess that QtQuick doesn't make it easy, but that's part of the problem...). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentusagemodel.cpp:261 > > if (!url.isValid() || !(fileItem.isFile() || fileItem.isDir())) { > return QVariant(); How do you expect isFile()

D19500: [KDirModel] Fix job urls change signal connection

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If there was a unittest for this code, it wouldn't remain broken for so long... Feel free to add one :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D195

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK so this is about KFileItem::text() and KFileItem::iconName(). Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KF

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure added a comment. > If they point to files on a network drive, and the network or the drive is not responding Well that's exactly the problem with network mounts, and the reason they are a sucky technical solution. KIO's async jobs never have that problem. You will never be

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This needs a KIO version ifdef for KIO >= 5.57. `#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0)` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D19784: Avoid calling QT_LSTAT and accessing recent documents

This revision was automatically updated to reflect the committed changes. Closed by commit R119:408f03ca989e: Avoid calling QT_LSTAT and accessing recent documents (authored by hoffmannrobert, committed by dfaure). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Is the makeURL function still used, or should it be removed now? INLINE COMMENTS > urlinfo.h:39 > + */ > +UrlInfo(QString path) > +: line(0), column(0) const QStr

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure added inline comments. INLINE COMMENTS > arrowd wrote in urlinfo.h:39 > > const QString & > > There is `path.chop(match.capturedLength());`, which requires non-const > `QString`. > > > And what if it's a URL? At this point this string is pathOrUrl. > > Well, `if (QFile::exists(path))`

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > urlinfo.h:76 > + * - make relative paths absolute using the current working > directory > + * - prefer local file, if in doubt! > + */ remo

D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet

dfaure created this revision. dfaure added reviewers: mart, apol, broulik. Herald added a project: Plasma. dfaure requested review of this revision. REVISION SUMMARY This file checks for controlRoot being undefined, everywhere else. TEST PLAN `qmlscene tests/testComboBox.qml` showed MobileT

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I agree that we shouldn't remove the underlying feature, in fact it's still used on other protocols than http. But we have to ensure the default behaviour matches the KCM and

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure added a comment. Writing into the user's home dir is a "hack". There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked...) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D21959: Fix selectedNameFilter() multiple matches

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. +1 for the included unittest. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:80 > */ > -static QString kde2QtFilter(const QStringList &list, const QString &kde) > +static QSt

D21959: Fix selectedNameFilter() multiple matches

dfaure closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesj

D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet

dfaure closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21514 To: dfaure, mart, apol, broulik, ngraham Cc: astippich, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, al

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries h

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, I'm wrong (not the first time this happens) :-) `kwrite /home/dfaure/.zshrc:20` works `kwrite sftp://localhost/home/dfaure/.zshrc:20` doesn't work indeed. The patch looks fine

D21517: Fix "Type error" when creating a TextField with focus: true

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:e419e9b42287: Fix "Type error" when creating a TextField with focus: true (authored by dfaure). Herald added a project:

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure added a comment. Backported. https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel,

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure added a comment. See KFileItem::isSlow() REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert, #frameworks, dfaure, #dolphin Cc: meven, apol, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, h

Re: Unified git commit message guideline

uldn't do that in the git commit log itself. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D23228: Port away from deprecated KWindowSystem API

dfaure created this revision. dfaure added reviewers: zzag, graesslin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY Call the all-in-one method (which handles numeric keypad better), then spli

D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem

dfaure created this revision. dfaure added a reviewer: zzag. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Fixes the build after https://phabricator.kde.org/D23213 REPOSITORY R130 Frameworks integration plugin usin

D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem

dfaure closed this revision. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D23334 To: dfaure, zzag Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-moham

D23228: Port away from deprecated KWindowSystem API

dfaure closed this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag, graesslin, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23228: Port away from deprecated KWindowSystem API

dfaure added a comment. Thanks for the testing! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag, graesslin, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, le

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. Why not do this in KFileItem::isSlow() itself? (and enable SkipMimeTypeFromContent when isSlow is true) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: davidedmundson, ngraham, broulik, plasma-deve

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. What I mean is: 1. improve KFileItem::isSlow to use this Solid code 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true However maybe we don't want that in dolphin? Not sure. (In that case a new enum value can be added, to

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. My suggestion is (still) "improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true" [possibly with another flag if you think there are actually use cases for mime-magic over network mounts] Then all this code isn't needed. REPOSITORY

D23808: Don't create() windows that aren't native, upon receiving a palette change event.

dfaure created this revision. dfaure added reviewers: carewolf, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN run kmail or falkon, then run kcmshell5 fonts, change font size ASSERT: "!d->

D23823: [KMenuEdit] port away from KStandardDirs

dfaure created this revision. dfaure added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN only did smoke testing (kmenuedit starts and displays the tree, clicking on one item shows details). RE

D23823: [KMenuEdit] port away from KStandardDirs

dfaure closed this revision. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D23823 To: dfaure, mlaurent Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D23808: Don't create() windows that aren't native, upon receiving a palette change event.

dfaure closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D23808 To: dfaure, carewolf, davidedmundson, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himce

D24007: [QQC2 Desktop Style] Port away from deprecated methods in Qt 5.14

dfaure created this revision. dfaure added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D2400

D24007: [QQC2 Desktop Style] Port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24007 To: dfaure, mart, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohame

D24238: Port the pager applet away from QtWidgets

dfaure created this revision. dfaure added reviewers: hein, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Builds REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde

D24238: Port the pager applet away from QtWidgets

dfaure added inline comments. INLINE COMMENTS > broulik wrote in windowmodel.cpp:81 > Isn't that the combined geometry of all screens, not just a single screen? Oh indeed. But then this was the wrong thing to use anyway. You don't want to center the window in relation to the combined geometry,

D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14

dfaure created this revision. dfaure added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY It gives the following runtime warning: Warning: QT_AUTO_SCREEN_SCALE_FACTOR is deprecated. Inst

D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14

dfaure closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24255 To: dfaure, apol, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-moha

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

dfaure accepted this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D10024: Add supportedSchemes feature

dfaure added inline comments. INLINE COMMENTS > kfilewidget.h:498 > +/** > + * Set the URL schemes that the file widget should allow navigating to. > + * All of these public methods should indicate that the default list is *empty* and that empty means "all schemes are supported". I

D10025: Use KFileWidget::setSupportedSchemes when available

dfaure accepted this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D10025 To: mwolff, dfaure, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Indeed. Fixed in shared-mime-info 1.10 (commit 009f22a, https://bugs.freedesktop.org/show_bug.cgi?id=101667) Fix proposed for Qt: https://codereview.qt-project.org/218155 REPOSITO

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure added a comment. I've been hitting a very similar bug where a Qt app was trying to use a bold font, and this had no effect when running in a plasma workspace, because of this code in kfontsettingsdata.cpp. Testcase (couldn't be simpler...) http://www.davidfaure.fr/2018/qlabel_inh

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure added a comment. In https://phabricator.kde.org/D9070#197332, @rjvbb wrote: > What happens when you remove the `,Regular` That fixes the problem indeed. >> Workaround: enabling the line that calls QApplication::setDesktopSettingsAware(false). >> Proof that this c

D5932: KCM for controlling Night Color

dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:59 > find_package(LibTaskManager CONFIG REQUIRED) > +find_package(LibColorCorrect CONFIG REQUIRED) > find_package(KWinDBusInterface CONFIG REQUIRED) Why is it required? Can't this KCM be skipped if the lib isn't available? Also, t

D5932: KCM for controlling Night Color

dfaure added inline comments. INLINE COMMENTS > kcm_nightcolor.desktop:18 > +Name[de]=Nachtfarbe > +Comment=Adjust color temperatur at night to reduce eye strain > +Comment[de]=Passe Farbtemperatur nachts an um Augen zu entlasten Typo: temperatur -> temperature. REPOSITORY R119 Plasma Desktop

D5932: KCM for controlling Night Color

dfaure added a comment. Ah, the un-namespaced name made me think it was an external dependency. OK, sorry for the noise, I must have updated plasma-desktop without updating plasma-workspace, it works now after a run of kdesrc-build. REPOSITORY R119 Plasma Desktop REVISION DETAIL https:

D8917: Reduce the amount of spurious property changes on ColorScope

dfaure added inline comments. INLINE COMMENTS > colorscope.h:131 > +QObject *const m_parent; > +Plasma::Theme::ColorGroup m_actualGroup; > valgrind says this member isn't initialized, please fix. http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt REPOSITORY R242 Plasma Frame

D10016: [KFileTreeView] Manually expand tree when model tells us to

dfaure added a comment. Wow, I just wanted to say thank you. This bug has been bugging me for many years (though never enough to actually take the time to look into it...). You rock, Kai Uwe. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.k

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I think this patch makes sense, even though I'm sad that it doesn't actually fix the bug I was seeing (you call it broken config file, in that case that would mean that the code writing out

D12275: FunnelModel: fix invalid model API usage.

dfaure created this revision. dfaure added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY The new asserts added in qtbase in commit 00c09e752f (Qt 5.11) are trig

D12275: FunnelModel: fix invalid model API usage.

dfaure closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12275 To: dfaure, hein, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12774: Fix submenus not updating when switching between categories of the same size

dfaure added a comment. Oops, thanks for the fix. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12774 To: hein, #plasma, mart Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D5446: Implement support for selected mime type filters

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfiledialog_unittest.cpp:84 > + > +QMimeType headerMime = > QMimeDatabase().mimeTypeForName(QStringLiteral("text/x-chdr")); > +QMimeType jsonM

D5446: Implement support for selected mime type filters

dfaure added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kfiledialog_unittest.cpp:116 > No, selectedMimeTypeFilter() is only in 5.9 so that wouldn't compile Oh I see. The QCOMPARE is just so that a failure happens. Pretty pointless, it's not testing anything from Qt. I would jus

D5446: Implement support for selected mime type filters

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D5446 To: elvisangelaccio, #plasma, dfaure Cc: anthonyfieroni, plasma-devel, spstarr, progwol

D5560: Archive ioslave: Port away from KDELibs4Support

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5560 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5561: Filter ioslave: Port away from KDELibs4Support

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5561 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreut

D5562: Fish ioslave: Port away from KDELibs4Support

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice work. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5562 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensr

D5566: recentdocuments ioslave: Port away from KDELibs4Support

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5566 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5567: Settings ioslave: Port away from KDELibs4Support

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5567 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5568: SFTP ioslave: Port away from KDELibs4Support

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:836 > // Handle user canceled or dialog failed to open... > -if (!openPasswordDialog(info, errMsg)) { > +if (openPassword

D5568: SFTP ioslave: Port away from KDELibs4Support

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5568 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5569: thumbnail ioslave: Port away from KDELibs4Support

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Easy one ;-) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5569 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jen

D5564: Man ioslave: Port away from KDELibs4Support

dfaure added inline comments. INLINE COMMENTS > kio_man.cpp:247 > +QString lang = QLocale::languageToString((*it_loc).language()); > +if ( !lang.isEmpty() && lang!=QString("C") ) { > +QString dir = (*it_dir) + '/' + lang; keep the spaces around != > man2h

D5956: Make sure we always set a default mime filter in save mode

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH defaultFilterSaveMode (branched from Plasma/5.10) REVISION DETAIL https://phabricator.kde.org/D5956 To: elvisangelaccio, #plasma, dfaure Cc: pla

D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario

dfaure added a comment. Excellent finding, it helped me reduce further the most annoying Qt bug I'm experiencing right now (in kmail) --> https://bugreports.qt.io/browse/QTBUG-59017 REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6046 To: broulik, #plasma, #d

D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Ths hack isn't horrible (window() makes sense too), however 1. you might want to move the call to window() inside KRun itself so it applies to all apps 2. please add a link

D5957: Don't ignore initially selected mime type filter

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH initiallySelectedMime (branched from Plasma/5.10) REVISION DETAIL https://phabricator.kde.org/D5957 To: elvisangelaccio, #plasma, dfaure Cc: pla

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #29 from David Faure --- ... with which protocol exactly? -- You are receiving this mail because: You are the assignee for the bug.

D6163: [Icon Applet] Get favicon for website shortcuts

dfaure added a comment. Yeah the favicon for kde.org is bigger than the size limit from the kio code -- ironic, isn't it. I never took the time to find out if it could be reduced, or if the size limit should be increased, and whatever other websites and other webbrowsers do. As for KIO:

D6350: Use KFileWidget::setSelectedUrl, which exists since KF 5.33.

dfaure created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes support for ":" in filenames. BUG: 376365 REPOSITORY R135 Integration for Qt applications in Plasma BRANCH setSelectedUrl

D6351: KDE QFileDialog helper: support name filters without parenthesis.

dfaure created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The QFileDialog documentation says these are equivalent: dialog.setNameFilter("All C++ files (*.cpp *.cc *.C *.cxx *.c++)"); dialog.s

D6351: KDE QFileDialog helper: support name filters without parenthesis.

This revision was automatically updated to reflect the committed changes. Closed by commit R135:4736950ec2e7: KDE QFileDialog helper: support name filters without parenthesis. (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6351?vs=15765&id=15769#toc REPOSITORY R13

D6350: Use KFileWidget::setSelectedUrl, which exists since KF 5.33.

dfaure closed this revision. dfaure added a comment. Pushed in b785b9c (stupid `arc land` merged two commits) REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6350 To: dfaure, #plasma, fvogt, apol Cc: plasma-devel, ZrenBot, progwolff,

<    1   2   3   4   5   >