Akonadi Calendar Dataengine

Hi all, I just noticed that now - with KDE SC 4.4, I have a working Akonadi Calendar. Which by itself is pretty awesome of course. But wouldn't it be even ++aweseome if that was connected to my plasma-clock-foldout-calendar? So I set down and poked our pimsters and got all the info I need in

Re: Akonadi Calendar Dataengine

Marco Martin wrote: On Monday 05 April 2010, Frederik Gladhorn wrote: Hi all, I just noticed that now - with KDE SC 4.4, I have a working Akonadi Calendar. Which by itself is pretty awesome of course. But wouldn't it be even ++aweseome if that was connected to my plasma-clock-foldout

Re: Akonadi Calendar Dataengine

making it not easy to correctly filter in some cases. I'd be happy if anyone would write a quick calendar list plasmoid as example, it could simply show a list of dates and the corresponding event. Greetings, Frederik Aaron J. Seigo wrote: On April 5, 2010, Frederik Gladhorn wrote: Calendar

Re: Akonadi Calendar Dataengine

Aaron J. Seigo wrote: On April 6, 2010, Frederik Gladhorn wrote: Requests to it have to have the form: calendar:-mm-dd:-mm-dd where the two dates are a range. could we replace calendar: with events:? sounds good to me (done) another concern is that if you have two calendars

Re: Akonadi Calendar Dataengine

Hi, Aaron J. Seigo wrote: On April 6, 2010, Frederik Gladhorn wrote: So would eventsInMonth:2010-04-01 sound OK? I don't have strong feelings about this. yes, that'd be cool as well, and keep it consistent with holidays. events:2010-04-02 could then return the events for just one day

Re: Review Request 119163: Add basic accessibility properties

/ModelContextMenu.qml 74d81d1 Diff: https://git.reviewboard.kde.org/r/119163/diff/ Testing --- http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 119163: Add basic accessibility properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61844 --- On July 7, 2014, 5:27 p.m., Frederik Gladhorn wrote

Re: Review Request 119163: Add basic accessibility properties

/plasmacomponents/qml/Switch.qml 60f179d src/declarativeimports/plasmacomponents/qml/TabBar.qml 809318a Diff: https://git.reviewboard.kde.org/r/119163/diff/ Testing --- http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ Thanks, Frederik Gladhorn

Plasma, Accessibility and Keyboard

Hello, I've run Plasma Next just a little bit in the last few days and I'm pleasantly surprised, great work everyone. I'm also happy to see that http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ got a little attention. I guess it's a good idea to give some more background

Re: Review Request 119163: Add basic accessibility properties

60f179d src/declarativeimports/plasmacomponents/qml/TabBar.qml 809318a Diff: https://git.reviewboard.kde.org/r/119163/diff/ Testing --- http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ Thanks, Frederik Gladhorn ___ Plasma

Re: Plasma, Accessibility and Keyboard

Tirsdag 8. juli 2014 15.48.19 skrev David Edmundson: Do you consider accelerator keys (the pressing alt + the underlined letter) to be a useful accessibility feature? I think it's a generally useful feature, that makes it into a useful accessibility feature too - and generally shortcuts are

Re: Plasma, Accessibility and Keyboard

Just a quick follow-up: kickoff the default app launcher doesn't currently work with screen readers, even after spending some time on it. The reason is that it keeps the focus on some root item (I didn't check where it actually is). For accessibility I currently rely on getting focus changes

Review Request 119301: Basic accessibility for kicker

(once it has keyboard focus), before it's completely silent. The problem of getting the focus onto the applet when opening it via keyboard shortcut is still there. Which branch should this go? Thanks, Frederik Gladhorn ___ Plasma-devel mailing list

Re: Review Request 119301: Basic accessibility for kicker

, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119379: Lockscreen accessibility

--- Tested with Orca. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

ToolButtons and focus

Hello, I just looked at the screen locker from an accessibility point of view (it's kinda' buggersome when there's no way to get back into a session after it has been locked) and with a bit of nudging (see review request) I can use it nicely. Not perfect, but good enough to get back to work.

Re: Review Request 119379: Lockscreen accessibility

--- On July 20, 2014, 4:05 p.m., Frederik Gladhorn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119379/ --- (Updated July

Re: Review Request 119379: Lockscreen accessibility

/UserDelegate.qml 2221368 Diff: https://git.reviewboard.kde.org/r/119379/diff/ Testing --- Tested with Orca. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119870: Make TabGroup a focus scope

/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

handling work in KickOff. Patches for KickOff still need cleanup. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119874: Make Kicker's root item a FocusScope

to the line edit since that one has focus: true. Diffs - applets/kicker/package/contents/ui/FullRepresentation.qml 1a1e845 Diff: https://git.reviewboard.kde.org/r/119874/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel

Re: Review Request 119874: Make Kicker's root item a FocusScope

it receives focus the focus moves to the line edit since that one has focus: true. Diffs - applets/kicker/package/contents/ui/FullRepresentation.qml 1a1e845 Diff: https://git.reviewboard.kde.org/r/119874/diff/ Testing --- Thanks, Frederik Gladhorn

Re: Review Request 119874: Make Kicker's root item a FocusScope

--- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119870: Make TabGroup a focus scope

/plasmacomponents/qml/TabGroup.qml 8cad25f Diff: https://git.reviewboard.kde.org/r/119870/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

Diff: https://git.reviewboard.kde.org/r/119872/diff/ Testing --- Made accessibility focus handling work in KickOff. Patches for KickOff still need cleanup. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https

suspend/hibernate and lock-logout

Hi, since lately suspend and hibernate work quite well for me, I added buttons for them to the lock/lockout plasma widget. I decided to follow the current scheme and add a checkbox for each button in the config. So far choosing any two out of four buttons works perfectly, but having more than

Review Request: Sleep/Hibernate in Lock/Log out plasma applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1031/ --- Review request for Plasma. Summary --- Display Sleep and Hibernate buttons

Re: Review Request: Sleep/Hibernate in Lock/Log out plasma applet

, visit: http://reviewboard.kde.org/r/1031/#review1613 --- On 2009-07-14 21:56:47, Frederik Gladhorn wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 120352: Remove keyboard click volume setting

sounds. For virtual keybords this would certainly make sense, but this is about the hardware keyboard. If the feature never worked, then just remove it, it can always be added back and fixed when someone requests it. - Frederik Gladhorn On Sept. 28, 2014, 1:33 p.m., David Edmundson wrote

Review Request 122464: Remove bell kcm

://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122464: Remove bell kcm

1c4f552 kcms/bell/bell.desktop f1cd552 kcms/bell/bell.h fda09b5 Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

been rotting for a while. Diffs (updated) - kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Thanks, Frederik

Review Request 122540: Add screen reader to Accessibility KCM

/accessibility.ui 2e0db83 kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb kcms/access/kcmaccess.cpp 7e0217d Diff: https://git.reviewboard.kde.org/r/122540/diff/ Testing --- This allows me to start and stop Orca using meta-alt-s or the kcm. Thanks, Frederik Gladhorn

Re: Review Request 122540: Add screen reader to Accessibility KCM

or the kcm. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

--- On Feb. 12, 2015, 5:01 p.m., Frederik Gladhorn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540

Re: Review Request 122540: Add screen reader to Accessibility KCM

--- This allows me to start and stop Orca using meta-alt-s or the kcm. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

was, it seems to have been rotting for a while. Diffs - kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Thanks, Frederik

Re: Review Request 122540: Add screen reader to Accessibility KCM

and stop Orca using meta-alt-s or the kcm. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

., Frederik Gladhorn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/ --- (Updated Feb. 11, 2015, 9:25 p.m.) Review

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

) - kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Thanks, Frederik Gladhorn

D6886: Add section about screen reader to kcmaccess kcm docbook

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. Thanks! I like the additions :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6886 To: lueck, #plasma, #documentation, gladhorn Cc: plasma-devel,

D6488: Fix setting natural/inverted scroll mode for touchpad with libinput

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8132e02bb8e8: Fix setting natural/inverted scroll mode for touchpad with libinput (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D6488: Fix setting natural/inverted scroll mode for touchpad with libinput

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Copy and paste meant that the check box didn't work, thus under wayland no natural scroll direction was possible. REPOSITORY R119 Plasma

D7935: Set QtQuickControls theme in QPT

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. It would be very nice if things didn't crash when using qguiapplication and the style, but I guess that's unrelated to this patch. REPOSITORY R135 Integration for Qt applications in

D7936: Don't set QQC Style in startkde

gladhorn accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7936 To: davidedmundson, #plasma, gladhorn Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7765: make krunner accessible

gladhorn added a comment. Lovely! Just a bit of nit-picking. INLINE COMMENTS > view.cpp:65 > > +//used only by on screen readers > +setTitle(i18n("KRunner")); I'd remove the "on" :) > RunCommand.qml:120 > } > -Keys.forwardTo: [listView, results] > +

D14428: Define ownership of edid in output and do not leak it

gladhorn added a comment. The alternative would be to deprecate this and add a new function. I think this is nonetheless sensible. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14428 To: gladhorn, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D14364: Test configId in TestSerializer

gladhorn updated this revision to Diff 38518. gladhorn edited the summary of this revision. gladhorn added a comment. Add more explanations REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14364?vs=38408=38518 BRANCH arcpatch-D14364 REVISION DETAIL

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY At least on arch linux pnp.ids does not even exist (while usb.ids and pci.ids do). There seem

D14359: Use inintializers and only create m_saveTimer when needed

gladhorn updated this revision to Diff 38516. gladhorn added a comment. Initialize m_changeCompressor to nullptr REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14359?vs=38400=38516 BRANCH arcpatch-D14359 REVISION DETAIL

D14359: Create m_saveTimer lazily

gladhorn updated this revision to Diff 38517. gladhorn retitled this revision from "Use inintializers and only create m_saveTimer when needed" to "Create m_saveTimer lazily". gladhorn added a comment. Only touch saveTimer REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14410: EDID parsing: strings are up to 13 bytes

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The descriptor blocks with strings come every 18 bytes, 5

D14371: Simplify Edid::Private::parse gamma

gladhorn abandoned this revision. gladhorn added a comment. D14418 is nicer REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14371 To: gladhorn Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14326: Fix layout of resolution selection

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5b6e9767a73e: Fix layout of resolution selection (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14326?vs=38515=38543 REVISION DETAIL

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38550. gladhorn added a comment. Minor cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38549=38550 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED FILES

D14418: Add test for edid parsing and fix reading gamma

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The bug in reading the gamma value was there from the start (2012), dividing the number by 100

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38549. gladhorn added a comment. Simplify gamma parsing code REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38548=38549 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418

D14422: Add edid converter

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Make it convenient to work with various EDID formats by

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38564. gladhorn added a comment. Removed some extra parenthesis REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38553=38564 BRANCH arcpatch-D14418 REVISION DETAIL

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38553. gladhorn added a comment. Remove extra newline REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38550=38553 BRANCH autotest REVISION DETAIL https://phabricator.kde.org/D14418 AFFECTED

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38565. gladhorn added a comment. Added one more edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38564=38565 BRANCH arcpatch-D14418 REVISION DETAIL https://phabricator.kde.org/D14418

D14410: EDID parsing: strings are up to 13 bytes

This revision was automatically updated to reflect the committed changes. Closed by commit R110:c66291ec8307: EDID parsing: strings are up to 13 bytes (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14410?vs=38532=38580

D14410: EDID parsing: strings are up to 13 bytes

gladhorn added a comment. Yes, my laptop screen uses all 13 bytes, that's how I noticed (the model had one character cut off and I happened to debug and see that it was there, so I did the math :)). REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14410 To:

D14364: Test configId in TestSerializer

gladhorn added inline comments. INLINE COMMENTS > romangg wrote in serializertest.cpp:163 > Below we do some tests in regards to the current config id value. These tests > are unrelated to any changes of the config id value over time. Therefore it > should not reference the magic config id

D14418: Add test for edid parsing and fix reading gamma

gladhorn added a comment. In D14418#299028 , @romangg wrote: > I'm not sure if you could really say that the current code is with a bug, since `data[GCM_EDID_OFFSET_GAMMA]` should be dividable by 100. I.e. the result is again an integer and

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn added a comment. I'll check, if it's not public API, I'll make it. Thanks for the pointer. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To: gladhorn, #plasma, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14381: Wayland: be consistent about screen name

This revision was automatically updated to reflect the committed changes. Closed by commit R110:d7cef1a5a987: Wayland: be consistent about screen name (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14381?vs=38457=38485

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. In D14339#297849 , @ngraham wrote: > Looks nice! > > I would approve of using radio buttons or four actual inline buttons instead of a combobox. > > Also +1 on "No Rotation" instead of "Normal", and for doing

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. And I see that arc just threw away my updated commit message :(, that's just weird. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38486. gladhorn added a comment. Updated message hopefully REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38382=38486 BRANCH arcpatch-D14339 REVISION DETAIL https://phabricator.kde.org/D14339 AFFECTED

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn added a comment. Good catch, I'll have to look into it, right now I get an empty string for both. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D14368: Let edidDecodeFraction return float

gladhorn updated this revision to Diff 38593. gladhorn edited the summary of this revision. gladhorn added a comment. arc mangled two patches again :( REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14368?vs=38421=38593 BRANCH arcpatch-D14368

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38594. gladhorn added a comment. arc messup, it squashed another patch into this one REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38592=38594 REVISION DETAIL https://phabricator.kde.org/D14418

D14428: Define ownership of edid in output and do not leak it

gladhorn updated this revision to Diff 38600. gladhorn added a comment. Messed up merge :( REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14428?vs=38599=38600 REVISION DETAIL https://phabricator.kde.org/D14428 AFFECTED FILES src/output.cpp

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

This revision was automatically updated to reflect the committed changes. Closed by commit R110:106251461674: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn updated this revision to Diff 38582. gladhorn added a comment. Moved Q_REQUIRED_RESULT to the front REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14369?vs=38422=38582 BRANCH arcpatch-D14369 REVISION DETAIL

D14405: Use short pnp id as fallback when the DB file is not found

gladhorn added a comment. I think the qml code should not do logic fiddling with the EDID :) but needs investigation. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14405 To: gladhorn, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel,

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38590. gladhorn added a comment. Sort edids in test rows. I still think this is completely pointless and a waste of time. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14418?vs=38588=38590 BRANCH

D14353: Improve alignment of types

gladhorn updated this revision to Diff 38595. gladhorn added a comment. Move two more members to the right spot REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14353?vs=38379=38595 BRANCH arcpatch-D14353 REVISION DETAIL

D14428: Define ownership of edid in output and do not leak it

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Valgrind showed that in some cases we were leaking the edid in

D14353: Improve alignment of types

gladhorn added a comment. In D14353#299282 , @zzag wrote: > I suggest to describe in the summary why data members are ordered from largest to smallest. OK, this should be the default for everyone. To have structures packed tight. Then

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn added a comment. It's been there for ages, it's mentioned in the changelog at least... but actually it seems more common to put the attribute before the function, I'll update with that. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 To:

D14418: Add test for edid parsing and fix reading gamma

gladhorn updated this revision to Diff 38592. gladhorn edited the summary of this revision. gladhorn added a subscriber: romangg. gladhorn added a comment. Updated commit message and rebased. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D14353: Improve alignment of types

gladhorn updated this revision to Diff 38596. gladhorn added a comment. initializer order fixed REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14353?vs=38595=38596 BRANCH arcpatch-D14353 REVISION DETAIL https://phabricator.kde.org/D14353

D14428: Define ownership of edid in output and do not leak it

gladhorn updated this revision to Diff 38599. gladhorn added a comment. Add note about the edid pointer becoming invalid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14428?vs=38598=38599 REVISION DETAIL https://phabricator.kde.org/D14428

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

gladhorn added a comment. Looks good, please finish up cleanup/indentation and I'll accept. INLINE COMMENTS > testinprocess.cpp:142 > +if (m_backendServiceInstalled) { > qDebug() << "TT xrandr out-of-process"; > // Load the xrandr backend out-of-process Please indent.

D14370: Simplify Edid::Private::edidParseString

This revision was automatically updated to reflect the committed changes. Closed by commit R110:2dfbe8d8a6cc: Simplify Edid::Private::edidParseString (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14370?vs=38423=38501 REVISION

D14353: Improve alignment of types

gladhorn added a comment. In D14353#298417 , @romangg wrote: > Why push id down? It should stay at the top imo (or alphabetically). Rest is fine. Because of padding. On 64 bit when int is usually 4 bit, there will be a hole of 4 bits in

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when QMLScreen is destroyed (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D14514: Install the OSD icons to hicolor

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY These icons were only in breeze-icons and would not be found

D14476: QMLScreen: do not declare the engine a member

This revision was automatically updated to reflect the committed changes. Closed by commit R104:a6929de88b89: QMLScreen: do not declare the engine a member (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14476?vs=38857=38860#toc REPOSITORY R104 KScreen CHANGES

D14514: Install the OSD icons to hicolor

gladhorn added a comment. In D14514#301328 , @broulik wrote: > Why are they not in the Plasma theme, though? What does that mean? "the plasma theme" ? I'm happy to move these to wherever it makes sense. Currently they are big

D14476: QMLScreen: do not declare the engine a member

gladhorn updated this revision to Diff 38857. gladhorn added a comment. Remove more cruft REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14476?vs=38745=38857 BRANCH arcpatch-D14476 REVISION DETAIL https://phabricator.kde.org/D14476 AFFECTED FILES

D14353: Improve alignment of types

gladhorn abandoned this revision. gladhorn added a comment. seems like this is not wanted REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14353 To: gladhorn, #plasma, romangg Cc: zzag, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14549: EDID parsing: replace non-printable characters with '-'

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Simplify first to not have zero terminators suddenly replaced

D14548: testedid: make sure to use uint consistently

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY It seems like compilation was broken with some configurations,

D14548: testedid: make sure to use uint consistently

This revision was automatically updated to reflect the committed changes. Closed by commit R110:c9955376ed2d: testedid: make sure to use uint consistently (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14548?vs=38933=38960

D14361: Remove unused function

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in daemon.h:38 > Can this cause trouble with ABI since this class is exported? But it's > probably just exported as an entry point for KDED and not for use as a library Well, the header is not installed, so the export seems pretty

D14403: Change screen orientation label from Normal to No Rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R104:6dd05a592d48: Change screen orientation label from Normal to No Rotation (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

  1   2   3   >