[Differential] [Closed] D2098: [System Tray] Use TableView viewport to determin column width

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2fec0af93ccf: [System Tray] Use TableView viewport to determin column width (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabric

[Differential] [Request, 2 lines] D2099: [System Tray] Animate only the icon

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This prevents the entire

[Differential] [Request, 2 lines] D2104: [Task Manager] Close gap when there is no icon

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In case there is no icon

[Differential] [Request, 2 lines] D2106: [Task Manager] Reject wheel event if switching windows by mouse wheel is disabled

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows the containme

[Differential] [Closed] D2106: [Task Manager] Reject wheel event if switching windows by mouse wheel is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe30a37a51402: [Task Manager] Reject wheel event if switching windows by mouse wheel is… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://p

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

broulik added a comment. Don't worry, Oliver, I actually wasn't going to push this before I had further feedback from you. :) I'll address the clear all idle timeouts call (oh, how I wish I had already done the powerdevil-as-separate-binary thing) and then should be good to go, minus th

[Differential] [Commented On] D2160: [System Tray] Round item size to icon size

broulik added a comment. F179825: Screenshot_20160714_115128.png F179826: Screenshot_20160714_115121.png F179827: Screenshot_20160714_115138.png REPOSITORY rPLASMAWORKS

[Differential] [Request, 2 lines] D2160: [System Tray] Round item size to icon size

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This should fix the icons

[Differential] [Commented On] D2160: [System Tray] Round item size to icon size

broulik added a comment. So, should we get this into 5.7.2? It's definitely an improvement to the 5.7.1 situation, especially for the blurry xembed icons. As for Eike's issue, I have really no clue why that happens, I looked into CompactApplet and everywhere and don't see any additional

[Differential] [Closed] D2099: [System Tray] Animate only the icon

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE1caec23e0e92: [System Tray] Animate only the icon (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2099?vs=4979

[Differential] [Closed] D2160: [System Tray] Round item size to icon size

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6a3ea8abb5a5: [System Tray] Round item size to icon size (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2160?

[Differential] [Request, 8 lines] D2204: [Service Runner] Search through "Comment" as well

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Kickoff tr

[Differential] [Commented On] D2204: [Service Runner] Search through "Comment" as well

broulik added a comment. I changed it so the comment is shown at least when the item is currently selected in the list [1] as it often provides useful information, not just for telling apart similar entries (as the old logic did). [1] https://quickgit.kde.org/?p=milou.git&a=commit&h=f6d

[Differential] [Changed Subscribers] D1813: Fix selected name filter with multiple mimetypes

broulik added a subscriber: dfaure. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: dfaure, graesslin,

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

broulik added a comment. The spacing is completely off now and the pin overlaps the calendar... REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud,

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

broulik added a comment. See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771 What I could imagine is having a list of check boxes there: "Show visual feedback for:" - [ ] Volume change - [ ] Brightness change - etc but then I don't think we should

[Differential] [Request, 1 line] D2222: [Notifications Dataengine] Fix default timeout

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As per notification spec

[Differential] [Updated] D2222: [Notifications Dataengine] Fix default timeout

broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D2223: [Notifications] Only keep job finished notification in case of an error

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a dependency: D: [Notifications Dataengine] Fix default timeout. Restricted Application added a project: Plasma. Res

[Differential] [Updated] D2222: [Notifications Dataengine] Fix default timeout

broulik added a dependent revision: D2223: [Notifications] Only keep job finished notification in case of an error. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

broulik added inline comments. INLINE COMMENTS > graesslin wrote in Jobs.qml:88 > why !! !! is the JavaScript-way of casting to a bool, error is the KIO error number. I could do Boolean(error) or error ? true : false if you like. I do a toBool() in the notification action but I'd prefer being

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

broulik added a comment. You do know, except it won't stick around forever (I got the habit of copying files, then clearing the notification history, it's so tedious). If something went wrong you'll either have the persistent error notification or a KIO error dialog anyway... REPOSITORY r

[Differential] [Closed] D2222: [Notifications Dataengine] Fix default timeout

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc521b596e043: [Notifications Dataengine] Fix default timeout (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

[Differential] [Closed] D2223: [Notifications] Only keep job finished notification in case of an error

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE35579e66489a: [Notifications] Only keep job finished notification in case of an error (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https

[Differential] [Closed] D2204: [Service Runner] Search through "Comment" as well

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE501bba4a51ba: [Service Runner] Search through "Comment" as well (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

broulik added a comment. Pretty! Having the sub-categories shown by default and being able to navigate to them directly is a significant improvement over the old layout. The layout layout doesn't handle different font sizes very well, I run at 125 dpi with 1x device pixel ratio which cau

[Differential] [Closed] D2090: [Kickoff] Sort Favorites in-view

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe9769b99448e: [Kickoff] Sort Favorites in-view (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2090?vs=4951&id=5507#toc REPOSITORY rPLASMADESKTOP Plasma Deskto

[Differential] [Request, 243 lines] D2296: RFC: "Add Widget" runner

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This runne

[Differential] [Updated] D2296: RFC: "Add Widget" runner

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2296 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, jensreuter

[Differential] [Commented On] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik added a comment. Thanks for your patch! Can you make sure you're working on the recent-most plasma-desktop master branch? I've recently changed the favorites sorting to reorder the items live as you drag them (like task manager or kicker do it). REPOSITORY rPLASMADESKTOP Plasm

[Differential] [Accepted] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Thanks. This fixes the issue for me. Do you have commit access? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org

[Differential] [Request, 5 lines] D2325: Don't unconditionally emit buttonPressed on profile load

broulik created this revision. broulik added reviewers: Plasma, afiestas. broulik set the repository for this revision to rPOWERDEVIL Powerdevil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A button press (technically

[Differential] [Abandoned] D2044: WIP: [KSMServer] Load logout dialog after startup rather than on-demand

broulik abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, sitter Cc: mart, graesslin, plasma-devel, ali-mohamed, jensr

[Differential] [Accepted] D2322: [Kickoff] Fix start row for drag not always being correct

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2322 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma Cc: plasm

[Differential] [Request, 30 lines] D2333: [Task Manager] Add back mnemonics for context menu

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In the old Task

[Differential] [Closed] D2333: [Task Manager] Add back mnemonics for context menu

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP41064e33b965: [Task Manager] Add back mnemonics for context menu (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2333?vs=5628&id=5634#toc REPOSITORY rPLASMADES

[Differential] [Commented On] D1479: [Notifications] Limit notification size and add scroll bar if needed

broulik added a comment. Thanks for your feedback > It is possible to scroll one letter to the right, although there is a automatic line break. I suppose that's the are the scroll bar occupies, I'll have a look. > I do not know if this is intended, but it does not look correct t

[Differential] [Changed Subscribers] D2356: [shell] Add a dbus call to activate the "main" application launcher

broulik added inline comments. INLINE COMMENTS > shellcorona.cpp:1635 > +{ > +for (auto it = m_panelViews.constBegin(), end = m_panelViews.constEnd(); > it != end; it++) { > +const auto applets = it.key()->applets(); ++it? > shellcorona.cpp:1638 > +for (auto applet : applet

[Differential] [Accepted] D2338: [Kickoff] Fix start row for drag not always being correct

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. There's still something off when I drag a bottom favorite to the top if often ends up in the wrong place or doesn't move at all. This is with and without this patch, so looks good to me.

[Differential] [Accepted] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bshah, #plasma, broulik Cc

[Differential] [Accepted] D2369: Convert powerdevil backends to proper plugins

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Looks good to me. > wayland Wayland would still use upower but instead of having XRandRBrightness only use sysfs, this needs some more thought on how we could split that in the

[Differential] [Commented On] D2325: Don't unconditionally emit buttonPressed on profile load

broulik added a comment. Ping. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2325 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, afiestas Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, a

[Differential] [Request, 20 lines] D2383: [Notifications] Add "Clear Notifications" context menu entry

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Th

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

broulik added a comment. I was thinking about that but where would you want to place it? The only place where it wouldn't look like crap is right of the "Notifications" heading but this is done by system tray and we cannot place items there from within an applet. REPOSITORY rPLASMAWORKSPA

[Differential] [Accepted] D2372: Make powerdevil normal executable instead of kded module

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil BRANCH powerdevil-executable (branched from master) REVISION DETAIL https://phabricator.kde.org/D2372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Closed] D2325: Don't unconditionally emit buttonPressed on profile load

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL48c3dca61d7c: Don't unconditionally emit buttonPressed on profile load (authored by broulik). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2325?vs

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

broulik added a comment. So, what should we do with this? Since we now have powerdevil as a separate binary we could savely do KIdleTime::instance()->removeAllIdleTimeouts(); without jeopardizing other kded modules. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://ph

[Differential] [Request, 8 lines] D2387: [System Tray] Don't reserve space for expander if it's not visible

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If all system tray icons

[Differential] [Request, 4 lines] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY PlasmaCore.SortFilterMode

[Differential] [Request, 3 lines] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The MPRIS data sources are que

[Differential] [Closed] D2387: [System Tray] Don't reserve space for expander if it's not visible

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEcd19257085e8: [System Tray] Don't reserve space for expander if it's not visible (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://ph

[Differential] [Closed] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPc8799879688f: [Task Manager ToolTipDelegate] Silence warning on startup (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Closed] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7516a8fb9dac: [Plasma Calendar Integration] Filter holiday regions case-insensitively (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https

[Differential] [Request, 243 lines] D2391: [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Wayland untested but compiled.

[Differential] [Request, 80 lines] D2392: [Task Manager] Allow dropping files onto tasks

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to

[Differential] [Updated] D2392: [Task Manager] Allow dropping files onto tasks

broulik updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2392 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-

[Differential] [Commented On] D2325: Don't unconditionally emit buttonPressed on profile load

broulik added a comment. I see. Thanks for your investigation. I must say, though, that I would not expect my laptop to do anything because the lid is closed after I closed the lid. Since the bug was originally caused by broken monitor detection, which is fixed in 5.7, indeed could be r

[Differential] [Commented On] D2393: Don't check current active session at all

broulik added inline comments. INLINE COMMENTS > powerdevilpolicyagent.cpp:426 > } else if (!m_sdSessionInterface.isNull()) { > bool isActive = > m_sdSessionInterface.data()->property("Active").toBool(); > You still fetch the property, no? REPOSITORY rPOWERDEVIL Powerdevil R

[Differential] [Abandoned] D1514: [Milou] Optimize sources model

broulik abandoned this revision. REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D1514 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 65 lines] D2395: [Milou] Optimize and cleanup sources model

broulik created this revision. broulik added reviewers: Plasma, vhanda. broulik set the repository for this revision to rMILOU Milou. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Simplify queryString once, rather than

[Differential] [Request, 2 lines] D2396: [Pager] Hide minimized windows

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It didn't show minimized windo

[Differential] [Closed] D2395: [Milou] Optimize and cleanup sources model

This revision was automatically updated to reflect the committed changes. Closed by commit rMILOU7bfa1a2538fc: [Milou] Optimize and cleanup sources model (authored by broulik). REPOSITORY rMILOU Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2395?vs=5810&id=5815 REVISION DETAI

[Differential] [Request, 73 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adjusts th

[Differential] [Closed] D2396: [Pager] Hide minimized windows

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP092aeb53d36e: [Pager] Hide minimized windows (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2396?vs=5811&id=5819 R

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. F254624: Screenshot_20160811_093330.png Also on low-dpi looks identical to System Settings spacing-wise REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES https://

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. > In System Settings, the full highlight color is only used on the sidebar when it is currently focused Yeah, noticed that, but focus handling in QML is just broken beyond repair so I didn't bother with that. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

[Differential] [Request, 4 lines] D2404: [Task Manager ToolTipDelegate] If there's room, show two lines of window title

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If no subtext i

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. F254909: Screenshot_20160811_124328.png Fainter blue when it doesn't have focus REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Updated, 111 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5826. broulik added a comment. Implement focus handling for category sidebar to match System Settings: - If it has focus the line uses a strong blue and arrow keys can be used to switch between pages - If it has no focus, the line is fainter - Cli

[Differential] [Updated, 140 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5827. broulik added a comment. More closely match focus behavior of Breeze widget style: Only if the sidebar has focus and the item is current will it get intense blue, white text and selected icon state, otherwise it's a fainter blue with black text R

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. F254921: Screenshot_20160811_125837.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Updated, 143 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5829. broulik added a comment. Disable activeFocusOnTab for the content ScrollView, when tabbing from the categories bar we should focus the first control in the page rather than the content ScrollView (it having focus isn't even visible because it doesn'

[Differential] [Updated, 171 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated the summary for this revision. broulik updated this revision to Diff 5832. broulik added a comment. When tabbing through the dialog, ensure the item with focus is visible, scrolling if neccessary REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://p

[Differential] [Updated, 179 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5834. broulik added a comment. Replicate fainter colors when window has no focus (QtQuick Controls don't do that unfortunately but the sidebar does that which is the most prominent part of the window, color-wise) REPOSITORY rPLASMADESKTOP Plasma Deskto

[Differential] [Updated, 196 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5838. broulik added a comment. Let Layouts do the size calculations more REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2398?vs=5834&id=5838 REVISION DETAIL https://phabricator.kde.org/D2398 AFFECTE

[Differential] [Closed] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP817b27f44d4a: [Applet Configuration] Match category sidebar style with Breeze widget… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2398?vs=5838&id=5839#toc RE

[Differential] [Updated] D2416: [Containment Actions ContextMenu] Port to KGlobalAccel::globalShortcut()

broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2416 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jens

[Differential] [Request, 39 lines] D2416: [Containment Actions ContextMenu] Port to KGlobalAccel::globalShortcut()

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implements the FIXME ther

[Differential] [Commented On] D2419: [backlight helper] Support setting backlight through leds subclass

broulik added inline comments. INLINE COMMENTS > backlighthelper.cpp:102 > +ledsFilters << QStringLiteral("*lcd*") << QStringLiteral("*wled*"); > +ledsDir.setNameFilters(ledsFilters); > + You could simplify this to ledsDir.setNameFilters({QStringLiteral("*lcd*"), QStringLiteral("*wled*"

[Differential] [Updated] D2418: Drop the C++ text label implementation.

broulik added a comment. Fixes: - Bug 346050: No subpixel rendering in task manager - Bug 360119: Task manager text is blurry and because we no longer have a shadow to begin with: - Bug 357242: se theme-defined color for task label shadow INLINE COMMENTS > Task.qml:390 > >

[Differential] [Accepted] D2419: [backlight helper] Support setting backlight through leds subclass

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil BRANCH add-led-brightness-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D2419 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Closed] D2404: [Task Manager ToolTipDelegate] If there's room, show two lines of window title

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb2f7422862d8: [Task Manager ToolTipDelegate] If there's room, show two lines of window title (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2404?vs=5824&id=5861#

[Differential] [Closed] D2416: [Containment Actions ContextMenu] Port to KGlobalAccel::globalShortcut()

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE9b546d9310f6: [Containment Actions ContextMenu] Port to KGlobalAccel::globalShortcut() (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE http

[Differential] [Updated, 231 lines] D2391: [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application

broulik updated this revision to Diff 5863. broulik added a comment. - Throw a bunch of full stops at the code - Remove copy-paste error about base impl that does nothing - Use KWindowSystem::isPlatformX11 REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://

[Differential] [Updated, 80 lines] D2392: [Task Manager] Allow dropping files onto tasks

broulik updated this revision to Diff 5865. broulik added a comment. - Fix comments punctuation - Use JS every() and forEach() instead of hand-rolled loops - Check hoveredItem before accessing it Did not change the QUrl validation as that's been like this before and I don't know how t

[Differential] [Closed] D2391: [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4a8877bab222: [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2391?vs=5863&id=586

[Differential] [Closed] D2392: [Task Manager] Allow dropping files onto tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP56a21fe0ec12: [Task Manager] Allow dropping files onto tasks (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2392?vs

[Differential] [Request, 8 lines] D2420: [Task Manager] Fix icon placement with right-to-left languages

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY X and Y coordinates are not mi

[Differential] [Request, 3 lines] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This flips the tooltip wh

[Differential] [Request, 2 lines] D2422: [Clipboard Plasmoid] Adjust gradient for right-to-left languages

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qt already did the right

[Differential] [Request, 2 lines] D2426: [KRunner] Set componentDisplayName for shortcuts

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way the shortcut cat

[Differential] [Request, 12 lines] D2427: [Applet Configuration] Don't ask for saving changes when clicking current category

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When changing some setting and

[Differential] [Closed] D2427: [Applet Configuration] Don't ask for saving changes when clicking current category

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP9e8ff49b57ca: [Applet Configuration] Don't ask for saving changes when clicking current… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://

[Differential] [Accepted] D2418: Drop the C++ text label implementation.

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Make sure to add the aforementioned Bug numbers to the commit message. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2418 EMA

[Differential] [Accepted] D2446: Remove redundant manual focusOut handling in DesktopView

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2446 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Closed] D2420: [Task Manager] Fix icon placement with right-to-left languages

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP7034546fefe1: [Task Manager] Fix icon placement with right-to-left languages (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Closed] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEbe801f30eb89: [Digital Clock Tooltip] Enable LayoutMirroring (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2421?vs=5869&id=5925#toc REPOSITORY rPLASMAWORKS

[Differential] [Reopened] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

broulik reopened this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2421 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: pla

[Differential] [Closed] D2426: [KRunner] Set componentDisplayName for shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb0940b6b6ed1: [KRunner] Set componentDisplayName for shortcuts (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Closed] D2422: [Clipboard Plasmoid] Adjust gradient for right-to-left languages

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3b251bc6ccb1: [Clipboard Plasmoid] Adjust gradient for right-to-left languages (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2422?vs=5870&id=5931#toc REPOSIT

<    1   2   3   4   5   6   7   8   9   10   >