[Differential] [Request, 7 lines] D3559: [Notification Popup] Clear notification data after popup closed

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There's no point in keeping around

[Differential] [Request, 25 lines] D3560: [Notifications] Tighten layout

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Our notification

[Differential] [Closed] D3557: [Notifications] Default initialize notificationProperties as empty object

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f78c98068a34: [Notifications] Default initialize notificationProperties as empty object (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 1 line] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I've quite often seen

[Differential] [Request, 13 lines] D3562: [Task Manager] Create toolTipDelegate on demand

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ToolTipTelegate is quite complex

[Differential] [Commented On] D3552: Remove quoting from kscreen-console json-output (Bug 354534)

broulik added a comment. Thanks for your patch! Instead of converting to an std::string you could try qDebug().noquote() << doc.toJson(); [1] https://doc.qt.io/qt-5/qdebug.html#noquote REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3552 EMAIL

[Differential] [Updated] D3539: [Notifications] Show interactive thumbnails on notifications

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: colomar, plasma-devel, lesliezhai,

[Differential] [Updated, 374 lines] D3539: [Notifications] Show interactive thumbnails on notifications

broulik updated this revision to Diff 8625. broulik added a comment. - Reduce preview area in height (now 1/3 of the dialog width instead of 1/2 as before – I tried 1/4 but given the aspect ratio it would make the preview hard to see imho) - When there is one item but a preview could not

[Differential] [Request, 28 lines] D3545: [ConnectionItem] Allow copying network details to clipboard

broulik created this revision. broulik added reviewers: Plasma, jgrulich, Plasma: Design. broulik set the repository for this revision to R116 Plasma Network Management Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION

[Differential] [Closed] D3545: [ConnectionItem] Allow copying network details to clipboard

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c156d251ec06: [ConnectionItem] Allow copying network details to clipboard (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

[Differential] [Request, 328 lines] D3539: [Notifications] Show interactive thumbnails on notifications

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When a notification

[Differential] [Updated] D3539: [Notifications] Show interactive thumbnails on notifications

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai,

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

broulik added a comment. Nifty. That I haven't thought of that kind of placement before. I always wanted some crappy overlay like we had before. Can you please check again with opacity mask instead of just overlaying a Rectangle. Also, what's up with the Canvas thing? INLINE COMMENTS

[Differential] [Request, 14 lines] D3594: [Notifications] Never manually hide() the NotificationPopup

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise the positioner will get

[Differential] [Closed] D3559: [Notification Popup] Clear notification data after popup closed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:76baa59dea73: [Notification Popup] Clear notification data after popup closed (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3560: [Notifications] Tighten layout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6c7a2a65c1b7: [Notifications] Tighten layout (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3560?vs=8677=8769#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

[Differential] [Request, 1 line] D3593: [Folder View] Clear hover state when mouse leaves view

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures there isn't a stray

[Differential] [Closed] D3594: [Notifications] Never manually hide() the NotificationPopup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b97fdfa293dd: [Notifications] Never manually hide() the NotificationPopup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 446 lines] D3539: [Notifications] Show interactive thumbnails on notifications

broulik updated this revision to Diff 8663. broulik added a comment. - "Expire" notification when clicking a URL This will cause the popup to close properly (previous patch would just hide the window but not "free" the dialog) but it will be kept in the history if it is a persistent

[Differential] [Closed] D3539: [Notifications] Show interactive thumbnails on notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c1679ba6468: [Notifications] Show interactive thumbnails on notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3539?vs=8663=8664#toc REPOSITORY R120 Plasma

[Differential] [Updated] D3539: [Notifications] Show interactive thumbnails on notifications

broulik marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: mart, colomar, plasma-devel, lesliezhai,

[Differential] [Updated, 444 lines] D3539: [Notifications] Show interactive thumbnails on notifications

broulik updated the test plan for this revision. broulik updated this revision to Diff 8662. broulik added a comment. - Put thumbnail strip behind a Loader - Make clicking the thumbnails actually work (horrible hack because of the MouseEventListener we have in the popup) - Make thumbnails

[Differential] [Request, 15 lines] D3557: [Notifications] Default initialize notificationProperties as empty object

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Avoids accessing the object twice for

[Differential] [Request, 50 lines] D3606: RFC: Listen for broadcast notifications on system bus

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will listen for a signal on the

[Differential] [Commented On] D3088: [KDecoration] Restore application menu button

broulik added a comment. What shall we do with this (the new virtual) now? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D3088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: sitter,

[Differential] [Commented On] D3086: Clean up KAppMenu

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3086 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 3 lines] D3982: [Panel Containment] Correctly compare applets without order

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When comparing two

[Differential] [Commented On] D3834: [Panel Containment] Replace restore order logic by "algorithms"

broulik added a comment. > I think it's this part: > > appletsOrder["unordered"+i] = plasmoid.applets[i] My loop sorts elements that have no index last, maybe that's wrong somehow? It worked for me for when an applet isn't ordered yet but I can reproduce that adding a new

[Differential] [Updated, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9638. broulik added a comment. - Parent jump list QAction to the applet not to leak them REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905?vs=9637=9638 REVISION DETAIL https://phabricator.kde.org/D3905

[Differential] [Accepted] D3933: Run all selected items on Enter/Return.

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > foldermodel.cpp:527 > +foreach (const QModelIndex , m_selectionModel->selectedIndexes()) > +{ > +run(index.row()); Put { on same line REPOSITORY

[Differential] [Requested Changes To] D3933: Run all selected items on Enter/Return.

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FolderView.qml:671 > if (currentIndex != -1 && dir.hasSelection()) { > -var func = root.useListViewMode ?

[Differential] [Commented On] D3948: Add-app-to-panel string overhaul.

broulik added inline comments. INLINE COMMENTS > actionlist.cpp:144 > if (ContainmentInterface::mayAddLauncher(appletInterface, > ContainmentInterface::Panel)) { > -actionList << Kicker::createActionItem(i18n("Add to Panel"), > "addToPanel"); > } Perhaps "(Icon Widget)", or

[Differential] [Updated] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 4 lines] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QDBusArgument MapType fits all kinds

[Differential] [Abandoned] D3156: WIP: Application Menu applet

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D3706 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D3085: Use DBusMenu if available

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

[Differential] [Updated, 187 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9783. broulik added a comment. - Add basic autotest that verifies that clicking the app menu button results in an application menu request REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

[Differential] [Updated, 131 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9782. broulik added a comment. - Introduce subclass (admittedly with a quite a long name) to avoid adding new virtuals in exported class REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3870: [Converter Runner] Also convert to the user's local currency

broulik added a comment. > not units.prepend(localCurrency) so it's first? That's what I did originally but since we sort by magnitude/value at the end, the order would be lost eventually. (Reviewboard manages to pick context from the repository, Phab only does so *after* having

[Differential] [Request, 10 lines] D3870: [Converter Runner] Also convert to the user's local currency

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The "most common units" for currency

[Differential] [Request, 5 lines] D3911: [Containment Appearance] Make sure to always load a config view

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If StackView is empty, currentItem will

[Differential] [Accepted] D3926: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3926 EMAIL PREFERENCES

[Differential] [Updated, 122 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9647. broulik added a comment. - Only offer Open With when for protocols that support listing (avoids it trying to open the "parent folder" of a website url) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3902: Fix X-Plasma-Drop* types

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0f3d2429d0a: Fix X-Plasma-Drop* types (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3902?vs=9576=9630 REVISION DETAIL

[Differential] [Closed] D3906: [Icon Applet] Fully re-populate when user changes Link URL

This revision was automatically updated to reflect the committed changes. Closed by commit R120:53c4f98a3391: [Icon Applet] Fully re-populate when user changes Link URL (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D3908: [Look and feel KCM] Notify PaletteChange on DBus

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3908 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik added a comment. > for deskto files that points to an app shortcut those two entries would not be added, right? Yes, "Open With" for apps doesn't make sense (what, open desktop file in editor?) and "Open containing folder" would open /usr/share/applications, very useful ;)

[Differential] [Updated, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9637. broulik added a comment. - assign nullptr after delete REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905?vs=9580=9637 REVISION DETAIL https://phabricator.kde.org/D3905 AFFECTED FILES

[Differential] [Accepted] D3932: Set current index to start of selection range when performing rectangle selection.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, broulik, #plasma

[Differential] [Closed] D3897: [Panel Containment] Explicitly bind visible on both the container and the applet

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d674ede6e5f2: [Panel Containment] Explicitly bind visible on both the container and the applet (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3816: [Task Manager] Parent QAction to "parent" instead of this

This revision was automatically updated to reflect the committed changes. Closed by commit R119:58e932c607db: [Task Manager] Parent QAction to "parent" instead of this (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3911: [Containment Appearance] Make sure to always load a config view

This revision was automatically updated to reflect the committed changes. Closed by commit R119:76ac242c37b7: [Containment Appearance] Make sure to always load a config view (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3823: [Lock Screen] Use QtRendering for Clock

This revision was automatically updated to reflect the committed changes. Closed by commit R120:23364f7f4913: [Lock Screen] Use QtRendering for Clock (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3823?vs=9396=9520 REVISION

[Differential] [Closed] D3817: [Connection Editor] Honor lineedit_reveal_password restriction

This revision was automatically updated to reflect the committed changes. Closed by commit R116:9a639f4ce9b0: [Connection Editor] Honor lineedit_reveal_password restriction (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3870: [Converter Runner] Also convert to the user's local currency

This revision was automatically updated to reflect the committed changes. Closed by commit R114:8fea513310f2: [Converter Runner] Also convert to the user's local currency (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3818: [KUIserver] Forward "destUrl" to all clients

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eceba917244f: [KUIServer] Forward "destUrl" to all clients (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3818?vs=9373=9521

[Differential] [Closed] D3819: [Applicationjobs Data Engine] Expose job "destUrl"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b469f397e625: [Applicationjobs Data Engine] Expose job "destUrl" (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3819?vs=9374=9522

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

broulik added inline comments. INLINE COMMENTS > hein wrote in main.xml:78 > We have KActivitiesStats to track access frequency of locations, doing this > in the TM applet is wrong. I propose you add KActivitieStats support to the > places model and add a sort mode using it. I don't want to

[Differential] [Updated, 85 lines] D3892: [Icon Item] Support non-square icons

broulik updated this revision to Diff 9658. broulik added a comment. Restricted Application added a subscriber: Frameworks. - Don't blindly round both sizes, instead round one and then scale the other accordingly - Adjust unit test REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST

[Differential] [Updated] D3958: [PackageLoader] Don't access invalid KPluginMetadata

broulik updated the test plan for this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed,

[Differential] [Updated] D3958: [PackageLoader] Don't access invalid KPluginMetadata

broulik updated the test plan for this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed,

[Differential] [Request, 4 lines] D3958: [PackageLoader] Don't access invalid KPluginMetadata

broulik created this revision. broulik added reviewers: Plasma, apol. broulik set the repository for this revision to R290 KPackage. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY BUG: 374541 TEST

[Differential] [Accepted] D3979: Fix race condition causing empty favorites.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3979 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, broulik, #plasma Cc:

[Differential] [Abandoned] D3910: [Kicker] Don't nuke favorites on startup

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D3979 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart,

[Differential] [Updated] D3302: [Task Manager] Indicate applications playing audio

broulik updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, drosca, hein Cc: subdiff, apol, colomar,

[Differential] [Updated, 287 lines] D3302: [Task Manager] Indicate applications playing audio

broulik updated this revision to Diff 9750. broulik added a comment. - Improve visuals for icon-only mode - Put Audio Icon into separate qml file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3302?vs=8026=9750 REVISION DETAIL

[Differential] [Request, 16 lines] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I don't know how this ever worked but I

[Differential] [Request, 69 lines] D3961: [Fifteen Puzzle] Remove custom color picker

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The round color picker looked fancy but

[Differential] [Closed] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:52b1644c8a03: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 3 lines] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes yet another KPluginMetadata

[Differential] [Closed] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Closed] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:04854c155df3: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

broulik added a comment. Return "true" and "false" strings maybe? I *think* QVariant is even smart enough to case those to the respective bool values REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3959 EMAIL PREFERENCES

[Differential] [Commented On] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

broulik added a comment. https://cgit.kde.org/plasma-workspace.git/commit/?h=Plasma/5.8=03374b185f9bd3bc4f70726ae641014a33278fdd REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES

[Differential] [Closed] D3961: [Fifteen Puzzle] Remove custom color picker

This revision was automatically updated to reflect the committed changes. Closed by commit R114:fb6a95332a3c: [Fifteen Puzzle] Remove custom color picker (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3961?vs=9711=9714 REVISION

[Differential] [Request, 1 line] D3962: Add Appstream summary

broulik created this revision. broulik added reviewers: Plasma, bgupta, mak. broulik set the repository for this revision to R166 Spectacle. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN As criticized on kde-devel by Richard

[Differential] [Commented On] D3971: RFC: Run first action on Shift+Return

broulik added a comment. That's why I mention it in the tooltip, so when one wonders "huh, what is this icon on the right?" sees "ooh, Shift+Enter triggers it too!" REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D3971 EMAIL PREFERENCES

[Differential] [Closed] D3893: [Folder View] Let IconItem take entire delegate width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2d2f33a915d3: [Folder View] Let IconItem take entire delegate width (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3893?vs=9563=9761

[Differential] [Changed Subscribers] D3257: Close the system tray on escape - system tray

broulik added inline comments. INLINE COMMENTS > mart wrote in PlasmoidPopupsContainer.qml:30 > wouldn't this break keyboard navigation in an item if supported? (like going > up and down in the device list in the device notifier) It did break it. I can no longer automatically type in Klipper

[Differential] [Closed] D3958: [PackageLoader] Don't access invalid KPluginMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8391e022e0f0: [PackageLoader] Don't access invalid KPluginMetadata (authored by broulik). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3958?vs=9708=9756

[Differential] [Closed] D3892: [Icon Item] Support non-square icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d46a91ea57f1: [Icon Item] Support non-square icons (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3892?vs=9658=9760#toc REPOSITORY R242 Plasma Frameworks CHANGES

[Differential] [Closed] D3086: Clean up KAppMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:90de42f2976c: Clean up KAppMenu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3086?vs=7784=9767 REVISION DETAIL

[Differential] [Updated, 81 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik updated this revision to Diff 9825. broulik added a comment. - Remove now unused m_size member, we just use m_targetSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4001?vs=9824=9825 REVISION DETAIL https://phabricator.kde.org/D4001

[Differential] [Updated, 80 lines] D4001: [Image Wallpaper] Simplify width/height management

broulik updated this revision to Diff 9824. broulik marked an inline comment as done. broulik added a comment. - Use magic plasmoid.width/plasmoid.height - Emit change whenever property changes, ie. move outside of single image if statement - Drop now unused width/height also from

[Differential] [Updated] D4001: [Image Wallpaper] Simplify width/height management

broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4001 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc:

[Differential] [Commented On] D3085: Use DBusMenu if available

broulik added a comment. Meh. For the title bar button shouldn't matter, though, as there I create a new importer everytime you click the button, so the menu is always up-to-date. Dunno about the applet. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Request, 26 lines] D4012: Introduce Units singleton

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Every single

[Differential] [Updated, 30 lines] D4012: Introduce Units singleton

broulik updated this revision to Diff 9846. broulik added a comment. - Q_DISABLE_COPY - Make constructor private REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9841=9846 REVISION DETAIL https://phabricator.kde.org/D4012 AFFECTED

[Differential] [Request, 7 lines] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Reduces the

[Differential] [Request, 51 lines] D4011: [Icon Item] Fix updating implicit size when icon sizes change

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The old code

[Differential] [Request, 4 lines] D4013: [Units] Make iconSizes property constant

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's not the

[Differential] [Closed] D3821: Add a manual test for unity launchers

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ed01d6958ebe: Add a manual test for Unity launchers (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3821?vs=9384=9549 REVISION DETAIL

[Differential] [Closed] D3828: [Plasma ScrollViewStyle] Show scroll bar background only on hover

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8675a31d2a99: [Plasma ScrollViewStyle] Show scroll bar background only on hover (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3775: [KPropertiesDialog] Kill "Place in system tray" option

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3c9ae735f63: [KPropertiesDialog] Kill "Place in system tray" option (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3775?vs=9251=9547 REVISION

[Differential] [Closed] D3834: [Panel Containment] Replace restore order logic by "algorithms"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:efd188db5838: [Panel Containment] Replace restore order logic by "algorithms" (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D3893: [Folder View] Let IconItem take entire delegate width

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. broulik added a dependency: D3892: [Icon Item] Support non-square icons. Restricted Application added a project: Plasma. Restricted Application added a

[Differential] [Updated] D3892: [Icon Item] Support non-square icons

broulik added a dependent revision: D3893: [Folder View] Let IconItem take entire delegate width. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein

[Differential] [Request, 21 lines] D3897: [Panel Containment] Explicitly bind visible on both the container and the applet

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While trying to fix a random

[Differential] [Request, 60 lines] D3892: [Icon Item] Support non-square icons

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 355592 TEST

[Differential] [Request, 10 lines] D3902: Fix X-Plasma-Drop* types

broulik created this revision. broulik added reviewers: Plasma, apol. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They are supposed to

<    5   6   7   8   9   10   11   >