[Differential] [Accepted] D2585: [Applet Configuration] Only scroll down if item is barely visible

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2585 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D2583: DiscardWindowPixmap when Surface size changes

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH discard-window-pixmap-surface-size-changed REVISION DETAIL https://phabricator.kde.org/D2583 EMAIL PREFERENCES

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

mart added a comment. yeah, should be "allow applications" even if not 100% correct REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, #vdg

[Differential] [Accepted] D2588: Load QtQuickSettings

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D2588 EMAIL PREFERENCES

[Differential] [Accepted] D2594: Add new session button to SessionsModel

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:1 > +add_definitions(-DTRANSLATION_DOMAIN=\"plasmashellprivateplugin\") > + unrelated? > CMakeLists.txt:20 >

[Differential] [Accepted] D2615: Don't load the system tray containment via two different code paths

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. are we really sure that when applet::init runs we always have already an instance of the systray containment? i am under the impression (needs to be tested, would

[Differential] [Commented On] D2608: [System Tray] Silence warning

mart added a comment. the thing is that internalSystray can be assigned at any moment, since being usually its config after the one of the container in appletsrc, usually when the applet container is started and initialized, the systray containment still doesn't exist REPOSITORY

[Differential] [Commandeered] D2615: Don't load the system tray containment via two different code paths

mart commandeered this revision. mart edited reviewers, added: davidedmundson; removed: mart. mart added a comment. This revision now requires review to proceed. err, didn't mean to accept, needs such testing REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D2608: [System Tray] Silence warning

mart added a comment. accept was still enabled for me REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2608 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik, mart Cc: mart,

[Differential] [Commented On] D2595: Fix comic applet appearance

mart added a comment. yes, it should just get given sane minumuwidth/switchwidth instead REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2595 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gladhorn Cc: mart,

[Differential] [Accepted] D2610: Make icon follow styleHints

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2610 EMAIL PREFERENCES

[Differential] [Accepted] D2611: Make trash follow styleHints

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2611 EMAIL PREFERENCES

[Differential] [Accepted] D2608: [System Tray] Silence warning

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2608 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D2623: Don't set Service as parent to KJob

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2623 EMAIL PREFERENCES

[Differential] [Accepted] D2523: New lockscreen

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH login_refactor2 REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES

[Differential] [Accepted] D2542: Simplify code

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kirigamiplugin.h:85 > { > -#ifdef Q_OS_WIN > -// On Windows, the leading slash does not make sense, so let's snip > that off > -return

[Differential] [Commented On] D2544: Move logic for services autostart from klauncher to ksmserver

mart added a comment. wouldn't this need to be done all over again in wayland as there wouldn't be ksmserver anymore? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2544 EMAIL PREFERENCES

[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

mart added a comment. F267238: dadel.png F267240: dadel1.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES

[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.h:55 > this seems like a different change ah, right, i dropped the part about HasDefaultLayoutRole, will remove > davidedmundson wrote in main.qml:145 > Why the Plasma one? Everything else is QQC in this file? as

[Differential] [Request, 54 lines] D2550: add a preview button and a fullscreen preview

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY preview button for themes, launches a fullscreen preview for the theme the preview image is shown as big as possible, either 1:1 or scaled

[Differential] [Commented On] D2550: add a preview button and a fullscreen preview

mart added a comment. overlaying a theme with preview: http://imgur.com/a/FVXDH preview: http://imgur.com/a/LhBjw REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES

[Differential] [Updated] D2550: add a preview button and a fullscreen preview

mart added a reviewer: Plasma. mart added a project: VDG. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 53 lines] D2550: add a preview button and a fullscreen preview

mart updated this revision to Diff 6196. mart added a comment. - remove hasdefaultlayoutrole REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2550?vs=6194=6196 BRANCH phab/preview REVISION DETAIL https://phabricator.kde.org/D2550

[Differential] [Accepted] D2561: Remove outdated files

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2561 EMAIL PREFERENCES

[Differential] [Accepted] D2619: Finish the rest of the changes from the geometry positioning

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2619 EMAIL PREFERENCES

[Differential] [Updated] D2872: use KPluginSelector to enable runners

mart added reviewers: Plasma, broulik. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 285 lines] D2872: use KPluginSelector to enable runners

mart updated this revision to Diff 6952. mart added a comment. - remove dead code REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2872?vs=6951=6952 BRANCH phab/kpluginselector REVISION DETAIL https://phabricator.kde.org/D2872

[Differential] [Commented On] D2872: use KPluginSelector to enable runners

mart added a comment. In https://phabricator.kde.org/D2872#53355, @davidedmundson wrote: > Worst, krunner framework still reads enabledCategories, so if something was disabled there's no way to enable it. > > Finally this leaves frameworks krunner documentation being wrong. i

[Differential] [Request, 206 lines] D2872: use KPluginSelector to enable runners

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the configuration dialog for enabling runners by category was a neat idea but had several problems, gave by it reinventing the wheel too

[Differential] [Accepted] D2865: Change component shown on selection changes

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2865 EMAIL PREFERENCES

[Differential] [Accepted] D2869: Validate row exists in UsersModel::data

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D2869 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D2885: avoid duplicate desktopviews on first startup

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY on first startup all the desktop views already exist after the script has been executed, so check the screen doesn't already have a view for

[Differential] [Updated] D2885: avoid duplicate desktopviews on first startup

mart updated the summary for this revision. mart updated the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2885 EMAIL PREFERENCES

[Differential] [Closed] D2885: avoid duplicate desktopviews on first startup

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe496a2874324: avoid duplicate desktopviews on first startup (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2872: use KPluginSelector to enable runners

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP44866deb0261: use KPluginSelector to enable runners (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2872?vs=6952=6987

[Differential] [Closed] D2873: kconfig update script for enabled runners

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEad9eda5d49f2: kconfig update script for enabled runners (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2884: [Kickoff] Draw FrameSvg behind icon preview

mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2884 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, davidedmundson, mart

[Differential] [Updated] D2820: Updating the wallpaper cache only when the configuration file settles

mart added a comment. any update on that? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2820 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, davidedmundson, mart Cc: broulik, plasma-devel,

[Differential] [Updated] D2873: kconfig update script for enabled runners

mart added a dependency: D2872: use KPluginSelector to enable runners. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2873 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

[Differential] [Updated] D2872: use KPluginSelector to enable runners

mart updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, broulik, davidedmundson, #plasma Cc: davidedmundson,

[Differential] [Updated] D2872: use KPluginSelector to enable runners

mart added a dependent revision: D2873: kconfig update script for enabled runners. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, broulik, davidedmundson,

[Differential] [Accepted] D2875: index.model()->data(... -> index.data(index,..

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D2875 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2876: If the theme set in the SDDM config is missing, select first possible entry

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSDDMKCM SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D2876 EMAIL PREFERENCES

[Differential] [Request, 84 lines] D2873: kconfig update script for enabled runners

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY migrate the enabled runners from enabledCategories to the more classic [Plugins] group the krunner framework supports both, so as long the

[Differential] [Updated] D2873: kconfig update script for enabled runners

mart updated the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2873 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

[Differential] [Commented On] D2872: use KPluginSelector to enable runners

mart added a comment. with the kconfig update script of https://phabricator.kde.org/D2873 the krunner configuration seems to have proper plugins enabled REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2872 EMAIL PREFERENCES

[Differential] [Commented On] D2919: Image has width and height properties, not "size"

mart added a comment. In https://phabricator.kde.org/D2919#54183, @broulik wrote: > Make sure the image item doesn't change its size erroneously upon opening it as changing source size will cause the image to be reloaded from disk there is one single widthchanged/heightchanged at

[Differential] [Accepted] D2853: Mouse KCM: Align spin boxes, port to Qt5

mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, davidedmundson, #plasma, mart Cc: andreaska,

[Differential] [Closed] D2919: Image has width and height properties, not "size"

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP7cbcf46b332e: Image has width and height properties, not "size" (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2922: [Digital Clock] Silence warning

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2922 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D2910: don't block startkde sending DBus call to KSplash

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2910 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D2913: Make the background of the logout screen darker

mart added inline comments. INLINE COMMENTS > Logout.qml:61 > > +Rectangle { > +color: PlasmaCore.ColorScope.backgroundColor making the background darker makes sense. But you already have a translucent black Rectangle at line 83, no need to add another one, just tweak opacity of

[Differential] [Commented On] D2914: folderview: port the context menu away from KonqPopupMenu.

mart added a comment. +1 killing the copy of libkonq would be sweet, yes REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2914 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, broulik, hein Cc: mart,

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

mart added a comment. In https://phabricator.kde.org/D2853#54136, @davidedmundson wrote: > Weird, with your patch I get F350007: Spectacle.Vm2529.png which looks spot on. latest version (that uses a grid) or formlayout version with hints

[Differential] [Commented On] D2853: Mouse KCM: Align spin boxes, port to Qt5

mart added a comment. looks fine here with latest version of the patch F350250: dadel5.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2853 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D2919: Image has width and height properties, not "size"

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this makes it actually do what it was intended to, set the source size to the actual thumbnail size to keep a

[Differential] [Changed Subscribers] D2877: Use Plasma::PluginLoader to list applets

mart added inline comments. INLINE COMMENTS > widgetexplorer.cpp:138 > for (auto data : list) { > const KPluginInfo info(data); > if (!info.isValid()) { this shouldn't be necessary anymore as data should be a kplugininfo now? REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Updated] D2886: Fixing loading for the wallpaper thumbnails in the activity switcher

mart added a comment. In https://phabricator.kde.org/D2886#53635, @ivan wrote: > Note: It still does reparseConfiguration() - it does not work as expected otherwise. I'm in favor of the patch in general.. If the file was changed by another process or somewhere else in the same

[Differential] [Accepted] D2886: Fixing loading for the wallpaper thumbnails in the activity switcher

mart accepted this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2886 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, davidedmundson, #plasma, mart Cc: plasma-devel,

[Differential] [Accepted] D3161: [kcmshell] Use desktop file name of module as app's desktop file

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH desktop-file-name REVISION DETAIL https://phabricator.kde.org/D3161 EMAIL PREFERENCES

[Differential] [Accepted] D3160: [kcmshell] set application data only after parsing command line

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH kaboutdata-parse REVISION DETAIL https://phabricator.kde.org/D3160 EMAIL PREFERENCES

[Differential] [Accepted] D3098: Update screen pool connector ID ordering before adjusting desktop containments

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3098 EMAIL PREFERENCES

[Differential] [Accepted] D3165: Remove line that does nothing

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3165 EMAIL PREFERENCES

[Differential] [Accepted] D3158: Disable Qt's high DPI scaling on shutdown/switch user dialogs

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3158 EMAIL PREFERENCES

[Differential] [Accepted] D3162: Pass a desktopfile name to kcmshell5

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH useractions-desktopfile REVISION DETAIL https://phabricator.kde.org/D3162 EMAIL PREFERENCES

[Differential] [Updated, 42 lines] D3166: make sure containment actions config is up to date

mart updated this revision to Diff 7679. mart added a comment. - move the config syncing in ~ScriptEngine() REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3166?vs=7672=7679 BRANCH arcpatch-D3166 REVISION DETAIL

[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. In https://phabricator.kde.org/D3166#58841, @davidedmundson wrote: > Also this script is making an optimistic assumption that in the script where you might be modding containment configs, you'd create a containment instance. That's not always true (like from the

[Differential] [Commented On] D3166: make sure containment actions config is up to date

mart added a comment. in this version, i'm rebuilding everything on scriptengine teardown, this should make work correctly even if one adds a new plugin, or removes one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3166 EMAIL PREFERENCES

[Differential] [Accepted] D3311: Dependency resolution code was moved to KPackage

mart accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3311 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

mart added a comment. In https://phabricator.kde.org/D3282#61310, @davidedmundson wrote: > From a conusmer POV it'll be exactly the same. > > Code wise, it's much more awkward to do the first one as it needs to go through the property(_graphicsObject)() malarky. yeah, i kinda

[Differential] [Accepted] D3269: kcm_keyboard: Change text of config action in tray icon to Configure Layouts

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3269 EMAIL PREFERENCES

[Differential] [Accepted] D3033: Cancel the Switch-user-overlay by clicking on empty space

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3033 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3283: Hide Background for Panel when backgroundHints are used

mart added a comment. +1, tough https://phabricator.kde.org/D3282 should use containment.backgroundHints as well REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

mart added a comment. i prefer this to be based onto containment.backgroundhits as well, i don't like explicit api for this at all. so not having a background would remove the frame background *and* disable the effects REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D3057: Fix drawing QtQuickControls ComboBox popups

mart added a comment. any news on this? REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3057 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, broulik, hpereiradacosta Cc: mart, plasma-devel, lesliezhai,

[Differential] [Accepted] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. updates on that? could this just go in? REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3062 EMAIL

[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

mart added a comment. any news on this? i don't see issues with the patch, even if obviously kindof a workaround REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3051 EMAIL PREFERENCES

[Differential] [Accepted] D3338: [effects] Save zoom settings using kcfg generated class

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH zoom-save-config REVISION DETAIL https://phabricator.kde.org/D3338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 66 lines] D3341: add connector name to screen model

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY to uniquely identify screens (in QScreen::name()) add the conenctor name and id (such as HDMI-A-1) to the

[Differential] [Accepted] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3330 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 102 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 8093. mart added a comment. - tie the new scrollbar style to animations enabled REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=7870=8093 BRANCH arcpatch-D3210 REVISION DETAIL

[Differential] [Updated, 98 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 8094. mart added a comment. - tie the new scrollbar style to animations enabled REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=8093=8094 BRANCH arcpatch-D3210 REVISION DETAIL

[Differential] [Accepted] D3339: [effects] Drop loading shadow config from MagicLamp

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. +1 for spring cleanings REPOSITORY rKWIN KWin BRANCH magiclamp-drop-shadow-config REVISION DETAIL https://phabricator.kde.org/D3339 EMAIL PREFERENCES

[Differential] [Accepted] D3340: [effects] Clean up saving of DesktopGrid config

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH desktop-grid-drop-double-save REVISION DETAIL https://phabricator.kde.org/D3340 EMAIL PREFERENCES

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. done. It looks maybe a bit too "magic", but may be a good thing REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #vdg, hpereiradacosta

[Differential] [Accepted] D3319: Load screenpool at the same time as we connect to screenchanged signals

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3319 EMAIL PREFERENCES

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#61533, @colomar wrote: > Whoa okay, that is complex... > Given that I failed to understand what the proposed checkboxes were supposed to mean, I fear it will be the same for users. > Therefore maybe not gibing the option at

[Differential] [Commented On] D3319: Load screenpool at the same time as we connect to screenchanged signals

mart added a comment. In https://phabricator.kde.org/D3319#61870, @fvogt wrote: > A quick question: This changes what the ScreenPool constructor does, are there any potential users of ScreenPool that now miss a call to ->load(), as it was done implicitly before? Wouldn't it be safer to

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote: > Which is why I think "no" option would actually be better. > In other word, either you have 2 checkboxes that cover all four possible combinations, or you start to make arbitrary (design based)

[Differential] [Updated] D3106: Replaced the launcher pinning action with a per-activity meny

mart added a comment. In https://phabricator.kde.org/D3106#57642, @broulik wrote: > What happens if there is only one activity? I don't use activities and I don't want a complicated submenu for pinning applications in this case. probably in that case there should be the simple

[Differential] [Changed Subscribers] D3102: Do not ask for root permissions when it's unnecessary

mart added inline comments. INLINE COMMENTS > accountmodel.cpp:165 > > -m_dbus->UncacheUser(acc->userName()).waitForFinished(); > -m_dbus->CacheUser(acc->userName()); is there absolutely nothing left needing this? REPOSITORY rUSERMANAGER User Manager REVISION

[Differential] [Accepted] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH render-target-viewport REVISION DETAIL https://phabricator.kde.org/D3099 EMAIL PREFERENCES

[Differential] [Accepted] D3095: Implement cursor shape tracking on Wayland

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH cursor-tracking-wayland REVISION DETAIL https://phabricator.kde.org/D3095 EMAIL PREFERENCES

[Differential] [Accepted] D3093: Add a PlatformCursorImage to Platform and EffectsHandler

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-cursor-image REVISION DETAIL https://phabricator.kde.org/D3093 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2981: Removes preferred definition so a new wallpaper is selected.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2981 EMAIL PREFERENCES

[Differential] [Commented On] D3102: Do not ask for root permissions when it's unnecessary

mart added a comment. ping? REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3102 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Accepted] D3117: allow changing an output's modelist at runtimeThis should fix running Plasma in a windowed virtual machine, when the window is resized, the mode list changes, and libk

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/modelistchange REVISION DETAIL https://phabricator.kde.org/D3117 EMAIL PREFERENCES

[Differential] [Accepted] D3106: Replaced the launcher pinning action with a per-activity meny

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for me good to go (maybe wait for eike's ship it as well) REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3106 EMAIL PREFERENCES

[Differential] [Accepted] D3119: Add way to hide/show cursor in Platform

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-cursor-show-hide REVISION DETAIL https://phabricator.kde.org/D3119 EMAIL PREFERENCES

[Differential] [Commented On] D3008: [shell] Don't resize or reposition panel if we are doing restore

mart added inline comments. INLINE COMMENTS > panelview.h:212 > int m_thickness; > +bool m_panelRestored; > Qt::Alignment m_alignment; code looks a bit weird but i see what it's trying to do.. i would give it another name, like m_initCompleted REPOSITORY rPLASMAWORKSPACE

<    2   3   4   5   6   7   8   9   10   11   >