Re: [platform-dev] Advertising 1 "trivial" bug a week

On Tue, Oct 20, 2020 at 10:54 PM Paul Pazderski wrote: > We got a good change from a new contributor (at least his first action > in Bugzilla) for the advertised "Persist Word Wrap" bug. > https://bugs.eclipse.org/bugs/show_bug.cgi?id=491853 > Thanks Paul for notifying! -- Mickael Istria Eclips

Re: [platform-dev] Advertising 1 "trivial" bug a week

We got a good change from a new contributor (at least his first action in Bugzilla) for the advertised "Persist Word Wrap" bug. https://bugs.eclipse.org/bugs/show_bug.cgi?id=491853 signature.asc Description: OpenPGP digital signature ___ platform-dev m

Re: [platform-dev] Accidental push to eclipse.platform.debug

Why don't you just go ahead and push up a change to gerrit with the same commit for the sole purpose of running the gerrit review build?  Just put a -2 on it yourself to ensure it doesn't get merged. Tom      - Original message -From: Alex Blewitt Sent by: platform-dev-boun...@eclipse.orgTo

Re: [platform-dev] Accidental push to eclipse.platform.debug

Thanks all :) I kicked off a mini build on top of master in platform.debug and it went through successfully, so I will leave the commit as is, and ensure that I don’t make the same mistake in the future … https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/171022

Re: [platform-dev] Accidental push to eclipse.platform.debug

We build using https://ci.eclipse.org/releng/view/Builds/job/I-build-4.18/ it is scheduled for 6PM daily. For test purposes you can build SDK using https://ci.eclipse.org/platform/job/eclipse-aggregator-master/ this will do a full sdk build. But no signing of jars or notarization. Unfortunately

Re: [platform-dev] Accidental push to eclipse.platform.debug

> On 20 Oct 2020, at 17:30, Mickael Istria wrote: > > > > On Tue, Oct 20, 2020 at 6:23 PM Alex Blewitt > wrote: > I accidentally pushed to master in the platform debug repository in a change > that I thought I’d configured for Gerrit: > https://git.eclipse.org/c

Re: [platform-dev] Accidental push to eclipse.platform.debug

On Tue, Oct 20, 2020 at 6:23 PM Alex Blewitt wrote: > I accidentally pushed to master in the platform debug repository in a > change that I thought I’d configured for Gerrit: > > https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c202200d26fa8f0fb07c46d3f92f5e4338b2f32 > Wh

[platform-dev] Accidental push to eclipse.platform.debug

I accidentally pushed to master in the platform debug repository in a change that I thought I’d configured for Gerrit: https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c202200d26fa8f0fb07c46d3f92f5e4338b2f32

Re: [platform-dev] Unit test fragment

+1 to use test fragments whenever it works better, it indeed allows better testing. And I also confirm those usually work with PDE and Tycho. If some issues are found regarding visibility of classes, they deserve bugs and fixes, and I'm pretty sure such bug reports will receive good attention if th

Re: [platform-dev] Unit test fragment

. On Tue, Oct 20, 2020 at 2:07 PM Andrey Loskutov wrote: > Hi, > > Before we propose to use whatever technology in a broader scope, could we > please make sure that existing use of that technology *works*? > We use the fragments way in Linux Tools https://git.eclipse.org/c/linuxtools/org.eclip

Re: [platform-dev] Unit test fragment

Hi, Before we propose to use whatever technology in a broader scope, could we please make sure that existing use of that technology *works*? AFAIK org.eclipse.tests.urischeme tests are not executed/running at all, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=565673. Kind regards, Andrey L

Re: [platform-dev] Unit test fragment

I kinda recall that even with plugin fragments, tests fail accessing package protected methods, when running from a Maven build, even though it *might* work in Eclipse. But don't take my word for it. Le mar. 20 oct. 2020 à 12:33, Aleksandar Kurtakov a écrit : > > > On Tue, Oct 20, 2020 at 1:18 P

Re: [platform-dev] Unit test fragment

On Tue, Oct 20, 2020 at 1:18 PM Karsten Thoms wrote: > Dear all, > > As discussed in yesterday’s SDK meetup I would like to see some real unit > tests for platform related internals. Many non-trivial functionality is > buried in private methods and are hard to test just from API. In order to > ad

[platform-dev] Unit test fragment

Dear all, As discussed in yesterday’s SDK meetup I would like to see some real unit tests for platform related internals. Many non-trivial functionality is buried in private methods and are hard to test just from API. In order to add tests on a more fine grained level when solving bugs I would