Re: [Bug 106031] Regression in 4.2.x: in airplane mode each time I open my laptop lid

On Friday 23 October 2015 20:03:19 Gabriele Mazzotta wrote: > On 23/10/2015 13:14, Pali Rohár wrote: > >On Friday 23 October 2015 11:47:25 Gabriele Mazzotta wrote: > >>>In my opinion it is better to ignore user key press after resume, if it > >>>fix our problem. Better as false-positive event. >

Re: [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake

On Fri, Nov 13, 2015 at 09:49:30PM -0800, Andy Lutomirski wrote: > The XPS 13 Skylake has an rfkill button and a switchvideomode button > that aren't enumerated in the DMI table AFAICT. Add a table listing > extra un-enumerated hotkeys. To avoid breaking things that worked > before, these

Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

Hi Darren, 2015-11-20 16:19 GMT-07:00 Darren Hart : > On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote: >> The driver uses genetlink to inform userspace of events generated by >> the system, but the data passed is always zero as there is no data to >> pass,

Re: [PATCH 2/3] dell_wmi: Use a C99-style array for bios_to_linux_keycode

On Fri, Nov 13, 2015 at 09:49:31PM -0800, Andy Lutomirski wrote: > It's currently hard to follow what maps to what, and it's hard to edit > the array. Redo it as a C99-style array. > > I generated this using emacs regexes and a python one-liner. > > Signed-off-by: Andy Lutomirski

Re: [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake

On Fri, Nov 20, 2015 at 4:06 PM, Darren Hart wrote: > On Fri, Nov 13, 2015 at 09:49:30PM -0800, Andy Lutomirski wrote: >> The XPS 13 Skylake has an rfkill button and a switchvideomode button >> that aren't enumerated in the DMI table AFAICT. Add a table listing >> extra

Re: [PATCH 3/3] dell_wmi: Improve unknown hotkey handling

On Fri, Nov 13, 2015 at 09:49:32PM -0800, Andy Lutomirski wrote: > If DMI lists a hotkey that we don't recognize, log and ignore it > instead of trying to map it to keycode 0. I haven't seen this happen, > but it will help maintain the key map in the future and it will help > avoid sending bogus

Re: [PATCH 2/3] dell_wmi: Use a C99-style array for bios_to_linux_keycode

On Saturday 21 November 2015 01:09:39 Darren Hart wrote: > Pali or Matthew, do either of you care to comment? Already commented, email is in archive, see: http://thread.gmane.org/gmane.linux.drivers.platform.x86.devel/7936/focus=7941 -- Pali Rohár pali.ro...@gmail.com signature.asc

Re: [PATCH 2/3] dell_wmi: Use a C99-style array for bios_to_linux_keycode

On Fri, Nov 20, 2015 at 4:26 PM, Darren Hart wrote: > On Sat, Nov 21, 2015 at 01:20:19AM +0100, Pali Rohár wrote: >> On Saturday 21 November 2015 01:09:39 Darren Hart wrote: >> > Pali or Matthew, do either of you care to comment? >> >> Already commented, email is in archive,

Re: [PATCH 3/3] dell_wmi: Improve unknown hotkey handling

On Fri, Nov 20, 2015 at 4:29 PM, Darren Hart wrote: > On Mon, Nov 16, 2015 at 05:35:44PM -0800, Andy Lutomirski wrote: >> On Sat, Nov 14, 2015 at 1:33 AM, Pali Rohár wrote: >> > On Friday 13 November 2015 21:49:32 Andy Lutomirski wrote: >> >> If DMI

Re: [PATCH 3/3] dell_wmi: Improve unknown hotkey handling

On Fri, Nov 20, 2015 at 4:41 PM, Pali Rohár wrote: > On Saturday 21 November 2015 01:29:04 Darren Hart wrote: >> Pali, was this something you wanted to discuss more before I merge >> it? > > Just one note: > >> + if (keycode == 0) { > > What about using define

Re: [PATCH] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

On Fri, Nov 20, 2015 at 04:55:06PM -0700, Azael Avalos wrote: > Hi Darren, > > 2015-11-20 16:39 GMT-07:00 Darren Hart : > > On Mon, Nov 16, 2015 at 12:59:31PM -0700, Azael Avalos wrote: > >> Certain Toshiba models with the second generation keyboard backlight > >> (type 2)

Re: [PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

On Fri, Nov 20, 2015 at 04:46:07PM -0700, Azael Avalos wrote: > Hi Darren, > > 2015-11-20 16:16 GMT-07:00 Darren Hart : > > On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote: > >> If transflective backlight is supported and the brightness is zero > >> (lowest

Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

On Fri, Nov 20, 2015 at 05:05:37PM -0700, Azael Avalos wrote: > Hi Darren, > > 2015-11-20 16:19 GMT-07:00 Darren Hart : > > On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote: > >> The driver uses genetlink to inform userspace of events generated by > >> the

Re: [PATCH v2 2/2] toshiba_acpi: Add WWAN RFKill support

On Thu, Nov 19, 2015 at 08:49:25AM -0700, Azael Avalos wrote: Hi Azael, > A previuos patch added WWAN support to the driver, allowing to query > and set the device status. > > This patch adds RFKill support for the recently introduced WWAN device, > making use of the WWAN and *wireless_status

Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote: > The driver uses genetlink to inform userspace of events generated by > the system, but the data passed is always zero as there is no data to > pass, except for the hotkey event. > > This patch propagates the hotkey value via

Re: [PATCH v2 2/2] toshiba_acpi: Add WWAN RFKill support

Hi Darren, 2015-11-20 15:50 GMT-07:00 Darren Hart : > On Thu, Nov 19, 2015 at 08:49:25AM -0700, Azael Avalos wrote: > > Hi Azael, > >> A previuos patch added WWAN support to the driver, allowing to query >> and set the device status. >> >> This patch adds RFKill support for

Re: [PATCH v2 1/2] toshiba_acpi: Add support for WWAN devices

On Thu, Nov 19, 2015 at 08:49:24AM -0700, Azael Avalos wrote: > Toshiba laptops with WWAN devices installed cannot use the device unless > it is attached and powered, similar to how Toshiba Bluetooth devices > work. > > This patch adds support to WWAN devices, introducing three functions, > one

Re: [PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote: > If transflective backlight is supported and the brightness is zero > (lowest brightness level), the set_lcd_brightness function will activate > the transflective backlight, making the LCD appear to be turned off. > > This patch fixes

Re: [PATCH v2 1/2] toshiba_acpi: Add support for WWAN devices

Hi Darren, 2015-11-20 15:49 GMT-07:00 Darren Hart : > On Thu, Nov 19, 2015 at 08:49:24AM -0700, Azael Avalos wrote: >> Toshiba laptops with WWAN devices installed cannot use the device unless >> it is attached and powered, similar to how Toshiba Bluetooth devices >> work. >>

Re: [PATCH] toshiba_bluetooth: Add missing newline in toshiba_bluetooth_present function

On Sun, Nov 15, 2015 at 08:33:47PM -0700, Azael Avalos wrote: > This patch simply adds a missing newline in the error string printed > by the toshiba_bluetooth_present function. > > This is just a cosmetic change, no functionality was changed. > > Signed-off-by: Azael Avalos

Re: [PATCH] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

On Mon, Nov 16, 2015 at 12:59:31PM -0700, Azael Avalos wrote: > Certain Toshiba models with the second generation keyboard backlight > (type 2) do not generate the keyboard backlight changed event (0x92), > and thus, the sysfs entries are never being updated. > > This patch adds a workquee and a

Re: [PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

Hi Darren, 2015-11-20 16:16 GMT-07:00 Darren Hart : > On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote: >> If transflective backlight is supported and the brightness is zero >> (lowest brightness level), the set_lcd_brightness function will activate >> the

Re: [PATCH] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

Hi Darren, 2015-11-20 16:39 GMT-07:00 Darren Hart : > On Mon, Nov 16, 2015 at 12:59:31PM -0700, Azael Avalos wrote: >> Certain Toshiba models with the second generation keyboard backlight >> (type 2) do not generate the keyboard backlight changed event (0x92), >> and thus,

Re: [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake

On Saturday 21 November 2015 01:06:36 Darren Hart wrote: > > - keymap = kcalloc(hotkey_num + 1, sizeof(struct key_entry), > > GFP_KERNEL); + keymap = kcalloc(hotkey_num + > > ARRAY_SIZE(dell_wmi_extra_keymap), > > This previously allocated kotkey_num + 1, but you dropeed the +1, > making

Re: [PATCH 2/3] dell_wmi: Use a C99-style array for bios_to_linux_keycode

On Sat, Nov 21, 2015 at 01:20:19AM +0100, Pali Rohár wrote: > On Saturday 21 November 2015 01:09:39 Darren Hart wrote: > > Pali or Matthew, do either of you care to comment? > > Already commented, email is in archive, see: > >

Re: [PATCH 3/3] dell_wmi: Improve unknown hotkey handling

On Mon, Nov 16, 2015 at 05:35:44PM -0800, Andy Lutomirski wrote: > On Sat, Nov 14, 2015 at 1:33 AM, Pali Rohár wrote: > > On Friday 13 November 2015 21:49:32 Andy Lutomirski wrote: > >> If DMI lists a hotkey that we don't recognize, log and ignore it > >> instead of trying

Re: [PATCH 3/3] dell_wmi: Improve unknown hotkey handling

On Saturday 21 November 2015 01:29:04 Darren Hart wrote: > Pali, was this something you wanted to discuss more before I merge > it? Just one note: > + if (keycode == 0) { What about using define KEY_RESERVED instead hardcoded constant 0? > + pr_info("firmware

[PATCH v2] dell-wmi: Improve unknown hotkey handling

If DMI lists a hotkey that we don't recognize, log and ignore it instead of trying to map it to keycode 0. I haven't seen this happen, but it will help maintain the key map in the future and it will help avoid sending bogus events. This also improves the message that we log when we get an

Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling

On Fri, Nov 20, 2015 at 5:27 PM, Andy Lutomirski wrote: > If DMI lists a hotkey that we don't recognize, log and ignore it > instead of trying to map it to keycode 0. I haven't seen this happen, > but it will help maintain the key map in the future and it will help > avoid