Re: [Podofo-users] PdfWriter as a base class

2014-05-15 Thread Ilan Zisser
Hi, You're right. I missed that completely. The reason is that i didn't compile the code.  I just assumed that a method named "Write" should override a similar method in the base class. Of course it's possible to rename the method like you suggested.

Re: [Podofo-users] PdfWriter as a base class

2014-05-15 Thread zyx
On Thu, 2014-05-15 at 11:12 +0300, Ilan Zisser wrote: Of course it's possible to rename the method like you suggested. However, I feel that this method should indeed override the base class' Write. After looking at the code for the method, I realized that it duplicates some of the code from

Re: [Podofo-users] PdfWriter as a base class

2014-05-14 Thread zyx
On Mon, 2014-05-12 at 15:15 +0300, Ilan Zisser wrote: I didn't see this. My revision didn't include PdfSigIncWriter.h. The reason for the warning is obvious, missing virtual before the method Write. Hi, it's not that simple, unfortunately. The problem isn't missing 'virtual'

Re: [Podofo-users] PdfWriter as a base class

2014-05-11 Thread zyx
On Mon, 2014-05-05 at 10:20 +0300, Ilan Zisser wrote: Attached is a patch file that modifies PdfWriter.h. It makes PdfWriter usable as a base class. Hi, I applied the patch to the current trunk and there are new warnings introduced by the change. Those are: [ 1%] Building CXX