-1 for a general and automatic reformatting. I don't like my
code to be crunched by some tool in a way I do not like. When I
write down code, I have my reasons for how I am doing it. Others
may like my style or not. I'd hate no work on source code I once
wrote and now don't recognize any
What I proposed is in between: the code is reformatted *only* if it fails
more than X number of checkstyle tests.
This way if the code you write is mainly in line, it will not be changed.
If not , it will.
This would solve your problem, since code that doesn't break (the loose
standards we
From: Rainer Klute [EMAIL PROTECTED]
What I proposed is in between: the code is reformatted *only* if it fails
more than X number of checkstyle tests.
This way if the code you write is mainly in line, it will not be changed.
If not , it will.
This would solve your problem, since code that
Nicola Ken Barozzi [EMAIL PROTECTED] wrote:
The problem is, where do we store this history?
In a special Javadoc tag for each method or class. Example:
@checkstyle-results: The following is not okay with respect to
coding standards bla bla bla...
@checkstyle-resolve-until:
Nicola Ken Barozzi [EMAIL PROTECTED] wrote:
Hmmm... what about a timeframe that is shorter the higher the errors are?
For example, if the errors are 20, it could give the user 1 month, if they
are 200, 3 days.
(maybe you can come up with a better function())
Not off hand. I'd first need some
+1 I don't the see the problem with a one time code reformatting on
check-in.
Glen raises a great point about conflicts with a cron job. So I would
definitely be opposed to that.
Ryan
- Original Message -
From: Glen Stampoultzis [EMAIL PROTECTED]
To: POI Developers List [EMAIL
From: Ryan Ackley [EMAIL PROTECTED]
+1 I don't the see the problem with a one time code reformatting on
check-in.
Glen raises a great point about conflicts with a cron job. So I would
definitely be opposed to that.
How about our last proposal, about giving a fair warning and reformatting
AFAIK, Not really possible. Check style checks a number of pedantic
things that the formatter doesn't. (And Checkstyle is really annoying
with some of those) This would cause the formatter to run repetitively.
If CheckStyle provided its own pedantic formatter then it would
work...but it
Nicola Ken Barozzi wrote:
From: Ryan Ackley [EMAIL PROTECTED]
+1 I don't the see the problem with a one time code reformatting on
check-in.
Glen raises a great point about conflicts with a cron job. So I would
definitely be opposed to that.
How about our last proposal, about giving
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9033.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9033.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8757.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8687.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
What is the / Is there a .. plan for a high level api to the charting
subsystem, once the low level records are implemented?
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Hard to plan until you understand the low level stuff well. Current plan:
1. Implement all required records to get a basic chart done (there's a lot
of these).
2. Analyse record structure.
3. Have a first pass at writing a high-level API
4. Refine (refactor) until bored or happy.
5. Implement
I am definitely -1 on setting up a complex process with checkstyle. The only
benefit I see of code formatting is to make the code readable with the
correct tabbing. I don't know of any other benefits because I have never
used a pretty printer. But this is great for me because I switch between 2
16 matches
Mail list logo