Re: [NEW] audio/libdiscid

2015-09-24 Thread Jérémie Courrèges-Anglas
Donovan Watteau writes: [...] >> > Looks fine to me, two nits: >> > >> > 1. >> > CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ >> >LDFLAGS="-L${LOCALBASE}/lib" \ >> >ac_cv_header_musicbrainz5_mb5_c_h=no >> > >> > If there is no dep on other

Re: [NEW] audio/libdiscid

2015-09-24 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: [...] audio/libdiscid has been imported, thanks Stuart for the review. > Looks good to me. I'm not sure whether TEST_IS_INTERACTIVE=Yes is > really needed, actually I don't really care. :) Maybe others have > a stronger opinion. I just

Re: [NEW] audio/libdiscid

2015-09-21 Thread Donovan Watteau
On Sat, 19 Sep 2015, Donovan Watteau wrote: > On Mon, 31 Aug 2015, Jérémie Courrèges-Anglas wrote: > > Donovan Watteau writes: > > > > > On Sat, 29 Aug 2015, Stuart Henderson wrote: > > >> On 2015/08/29 11:16, Donovan Watteau wrote: > > >> > Hi, > > >> > > > >> > Here's a new

Re: [NEW] audio/libdiscid

2015-09-19 Thread Donovan Watteau
On Mon, 31 Aug 2015, Jérémie Courrèges-Anglas wrote: > Donovan Watteau writes: > > > On Sat, 29 Aug 2015, Stuart Henderson wrote: > >> On 2015/08/29 11:16, Donovan Watteau wrote: > >> > Hi, > >> > > >> > Here's a new port for libdiscid, which my next audio/cmus update > >> >

Re: [NEW] audio/libdiscid

2015-08-30 Thread Jérémie Courrèges-Anglas
Donovan Watteau tso...@gmail.com writes: On Sat, 29 Aug 2015, Stuart Henderson wrote: On 2015/08/29 11:16, Donovan Watteau wrote: Hi, Here's a new port for libdiscid, which my next audio/cmus update will use. I tried cleaning some strcpy(), strcat() and sprintf(). make test is

[NEW] audio/libdiscid

2015-08-29 Thread Donovan Watteau
Hi, Here's a new port for libdiscid, which my next audio/cmus update will use. I tried cleaning some strcpy(), strcat() and sprintf(). make test is still fine. If patch-src_disc_c looks good to you, I'll submit it to upstream. Tested on macppc. libdiscid.tgz Description: Binary data

Re: [NEW] audio/libdiscid

2015-08-29 Thread Stuart Henderson
On 2015/08/29 11:16, Donovan Watteau wrote: Hi, Here's a new port for libdiscid, which my next audio/cmus update will use. I tried cleaning some strcpy(), strcat() and sprintf(). make test is still fine. If patch-src_disc_c looks good to you, I'll submit it to upstream. Tested on

NEW: audio/libdiscid

2009-08-22 Thread Anton Yabchinskiy
Hello, ports. I've created port for python-musicbrainz2 and for this lib as a dependency. The patch for OpenBSD support in libdiscid is accepted upstream, but until next release it is in patches/. Please, test it with py-musicbrainz2. Maybe also the dependency on this could be enabled in