On Thu, Sep 07, 2023 at 05:08:11PM +0200, Landry Breuil wrote:
> Le Thu, Sep 07, 2023 at 02:47:58PM +, Sergey A. Osokin a écrit :
> >
> > There's no shared library for NJS at the moment, only static
> > library is available.
>
> right. then ... i think BUILD_DEPENDS + RUN_DEPENDS is needed
Le Thu, Sep 07, 2023 at 02:47:58PM +, Sergey A. Osokin a écrit :
> On Thu, Sep 07, 2023 at 12:16:39PM +0200, Landry Breuil wrote:
> > Le Wed, Sep 06, 2023 at 02:12:20PM +, Sergey A. Osokin a écrit :
> [...]
> > >
> > > Sure, here's the updated patch.
> >
> > i've checked and something is
On Thu, Sep 07, 2023 at 12:16:39PM +0200, Landry Breuil wrote:
> Le Wed, Sep 06, 2023 at 02:12:20PM +, Sergey A. Osokin a écrit :
[...]
> >
> > Sure, here's the updated patch.
>
> i've checked and something is wrong somewhere, because njs is detected
> at configure, the unitd binary is
Le Wed, Sep 06, 2023 at 02:12:20PM +, Sergey A. Osokin a écrit :
> On Wed, Sep 06, 2023 at 05:13:24AM +0200, Landry Breuil wrote:
> > Le Tue, Sep 05, 2023 at 05:57:09PM +, Sergey A. Osokin a écrit :
> > > Landry,
> > >
> > > the recent update in lang/njs you made includes a fix for the
>
On Wed, Sep 06, 2023 at 05:13:24AM +0200, Landry Breuil wrote:
> Le Tue, Sep 05, 2023 at 05:57:09PM +, Sergey A. Osokin a écrit :
> > Landry,
> >
> > the recent update in lang/njs you made includes a fix for the
> > njs.pc, so we may have to return to this one? Or am I missing
> > something?
Le Tue, Sep 05, 2023 at 05:57:09PM +, Sergey A. Osokin a écrit :
> Landry,
>
> the recent update in lang/njs you made includes a fix for the
> njs.pc, so we may have to return to this one? Or am I missing
> something?
maybe, dont remember the context :)
in all cases it needs REVISION bumps
Landry,
the recent update in lang/njs you made includes a fix for the
njs.pc, so we may have to return to this one? Or am I missing
something?
Thank you.
--
Sergey A. Osokin
On Fri, May 26, 2023 at 03:45:53PM +, Sergey A. Osokin wrote:
> Hi,
>
> lang/njs has been added to the ports tree
On Tue, Sep 05, 2023 at 06:43:30PM +0200, Landry Breuil wrote:
[...]
>
> the attached patch produces the same njs.pc file here.
[...]
Thanks, Landry, for the details. The patch looks good to me.
--
Sergey A. Osokin
Le Tue, Sep 05, 2023 at 04:07:41PM +, Sergey A. Osokin a écrit :
> On Tue, Sep 05, 2023 at 05:42:45PM +0200, Landry Breuil wrote:
> > Le Tue, Sep 05, 2023 at 02:59:37PM +, Sergey A. Osokin a écrit :
> > >
> > > Alright, let's keep it as is and update the lang/njs to v0.8.0, the patch
> >
On Tue, Sep 05, 2023 at 05:42:45PM +0200, Landry Breuil wrote:
> Le Tue, Sep 05, 2023 at 02:59:37PM +, Sergey A. Osokin a écrit :
> >
> > Alright, let's keep it as is and update the lang/njs to v0.8.0, the patch
> > is attached, thank you.
>
> with the order of includes:
>
Le Tue, Sep 05, 2023 at 02:59:37PM +, Sergey A. Osokin a écrit :
> On Tue, Sep 05, 2023 at 04:35:50PM +0200, Landry Breuil wrote:
> [...]
>
> > i get that for you as a maintainer it might be better/consistent, but i
> > have to disagree here. What do we gain from having them split ? users
> >
On Tue, Sep 05, 2023 at 04:35:50PM +0200, Landry Breuil wrote:
[...]
> i get that for you as a maintainer it might be better/consistent, but i
> have to disagree here. What do we gain from having them split ? users
> wanting just a binary without the header/library ? disk space ? the two
> ports
We don't use shars, please send a tar instead
--
Sent from a phone, apologies for poor formatting.
On 5 September 2023 15:29:30 "Sergey A. Osokin" wrote:
Hi Landry,
thank you for the review, comments and suggestions.
Le Sat, May 27, 2023 at 09:55:48AM +0200, Landry Breuil a écrit :
Le Tue, Sep 05, 2023 at 02:29:03PM +, Sergey A. Osokin a écrit :
> Hi Landry,
>
> thank you for the review, comments and suggestions.
>
> > Le Sat, May 27, 2023 at 09:55:48AM +0200, Landry Breuil a écrit :
>
> [...]
>
> > +post-patch:
> > + ${SUBST_CMD} ${WRKSRC}/auto/make
> > +
> >
Hi Landry,
thank you for the review, comments and suggestions.
> Le Sat, May 27, 2023 at 09:55:48AM +0200, Landry Breuil a écrit :
[...]
> +post-patch:
> + ${SUBST_CMD} ${WRKSRC}/auto/make
> +
> do-install:
[...]
I have decided to split existing lang/njs port into two ports:
-
Le Sat, May 27, 2023 at 10:02:29AM +0200, Landry Breuil a écrit :
> Le Sat, May 27, 2023 at 09:55:48AM +0200, Landry Breuil a écrit :
> > Index: Makefile
> > ===
> > RCS file: /cvs/ports/lang/njs/Makefile,v
> > retrieving revision
Le Sat, May 27, 2023 at 09:55:48AM +0200, Landry Breuil a écrit :
> Le Sat, May 27, 2023 at 09:19:24AM +0200, Landry Breuil a écrit :
> > Le Fri, May 26, 2023 at 03:45:53PM +, Sergey A. Osokin a écrit :
> > > Hi,
> > >
> > > lang/njs has been added to the ports tree recently, so
> > > here's
Le Sat, May 27, 2023 at 09:19:24AM +0200, Landry Breuil a écrit :
> Le Fri, May 26, 2023 at 03:45:53PM +, Sergey A. Osokin a écrit :
> > Hi,
> >
> > lang/njs has been added to the ports tree recently, so
> > here's the patch to enable nginx javascript for www/unit.
>
> i've had a look and
Le Fri, May 26, 2023 at 03:45:53PM +, Sergey A. Osokin a écrit :
> Hi,
>
> lang/njs has been added to the ports tree recently, so
> here's the patch to enable nginx javascript for www/unit.
i've had a look and thought this was mostly ok, but first there's
something to fix in the current njs
Hi,
lang/njs has been added to the ports tree recently, so
here's the patch to enable nginx javascript for www/unit.
Thank you.
--
Sergey A. Osokin
Index: Makefile.inc
===
RCS file: /cvs/ports/www/unit/Makefile.inc,v
retrieving
20 matches
Mail list logo
