[pfx-dev] [PATCH v3 2/2] New "debug:" table/dict/map/db type for logging table accesses

2025-06-08 Thread Richard Hansen via Postfix-devel
This reuses the existing proxy object created by the dict_debug() function. --- proto/DATABASE_README.html | 13 +++ src/postconf/Makefile.in | 1 + src/postconf/postconf.c | 10 + src/postconf/postconf_dbms.c | 12 -- src/postconf/test28-main.cf | 12 ++ src/postconf/

[pfx-dev] [PATCH v3 1/2] postconf: Revamp table variable tests for readability, coverage

2025-06-08 Thread Richard Hansen via Postfix-devel
I found the test28 and test29 tests difficult to understand, and they seemed to not provide the intended coverage. Rewrite them for clarity and completeness. --- src/postconf/Makefile.in | 40 + src/postconf/test28-main.cf | 22 ++ src/postconf/test28-ma

[pfx-dev] [PATCH v3 0/2] New "debug:" table/dict/map/db type for logging table accesses

2025-06-08 Thread Richard Hansen via Postfix-devel
On 2025-06-08 16:16:59-04:00, Wietse Venema via Postfix-devel wrote: > - postconf_dbms.c needs to be updated to skip leading debug: prefixes > just like proxy: prefixes. The purpose of that module is to > inspect database-specific config files (LDAP, SQL, etc.), and > to complain about mista

[pfx-dev] Re: [PATCH] New "debug:" table/dict/map/db type for logging table accesses

2025-06-08 Thread Wietse Venema via Postfix-devel
Good job, and thanks for adding tests. A few comments: - I was surprised that it takes a non-trivial amount of code to basically raise the DICT_DEBUG flag on a dictionary instance. But I guess that is because the debug: monitor is now also installed as a dictionary. - It handles recursion

[pfx-dev] [PATCH v2] New "debug:" table/dict/map/db type for logging table accesses

2025-06-08 Thread Richard Hansen via Postfix-devel
This reuses the existing proxy object created by the dict_debug() function. --- Changes from v1: * Don't inherit type and name from the underlying DICT; instead set type to "debug" and name to the registered name. This avoids the need for a new char * member in the DICT_DEBUG struct, at